1 | // License: GPL. For details, see LICENSE file.
|
---|
2 | package org.openstreetmap.josm.gui.dialogs.validator;
|
---|
3 |
|
---|
4 | import static org.openstreetmap.josm.tools.I18n.tr;
|
---|
5 |
|
---|
6 | import java.awt.event.KeyListener;
|
---|
7 | import java.awt.event.MouseEvent;
|
---|
8 | import java.util.ArrayList;
|
---|
9 | import java.util.Collection;
|
---|
10 | import java.util.Enumeration;
|
---|
11 | import java.util.HashSet;
|
---|
12 | import java.util.List;
|
---|
13 | import java.util.Map;
|
---|
14 | import java.util.Map.Entry;
|
---|
15 | import java.util.Set;
|
---|
16 | import java.util.function.Consumer;
|
---|
17 | import java.util.function.Predicate;
|
---|
18 |
|
---|
19 | import javax.swing.JTree;
|
---|
20 | import javax.swing.ToolTipManager;
|
---|
21 | import javax.swing.tree.DefaultMutableTreeNode;
|
---|
22 | import javax.swing.tree.DefaultTreeModel;
|
---|
23 | import javax.swing.tree.TreeNode;
|
---|
24 | import javax.swing.tree.TreePath;
|
---|
25 | import javax.swing.tree.TreeSelectionModel;
|
---|
26 |
|
---|
27 | import org.openstreetmap.josm.data.osm.OsmPrimitive;
|
---|
28 | import org.openstreetmap.josm.data.osm.event.AbstractDatasetChangedEvent;
|
---|
29 | import org.openstreetmap.josm.data.osm.event.DataChangedEvent;
|
---|
30 | import org.openstreetmap.josm.data.osm.event.DataSetListener;
|
---|
31 | import org.openstreetmap.josm.data.osm.event.DatasetEventManager;
|
---|
32 | import org.openstreetmap.josm.data.osm.event.NodeMovedEvent;
|
---|
33 | import org.openstreetmap.josm.data.osm.event.PrimitivesAddedEvent;
|
---|
34 | import org.openstreetmap.josm.data.osm.event.PrimitivesRemovedEvent;
|
---|
35 | import org.openstreetmap.josm.data.osm.event.RelationMembersChangedEvent;
|
---|
36 | import org.openstreetmap.josm.data.osm.event.TagsChangedEvent;
|
---|
37 | import org.openstreetmap.josm.data.osm.event.WayNodesChangedEvent;
|
---|
38 | import org.openstreetmap.josm.data.preferences.sources.ValidatorPrefHelper;
|
---|
39 | import org.openstreetmap.josm.data.validation.OsmValidator;
|
---|
40 | import org.openstreetmap.josm.data.validation.Severity;
|
---|
41 | import org.openstreetmap.josm.data.validation.TestError;
|
---|
42 | import org.openstreetmap.josm.gui.util.GuiHelper;
|
---|
43 | import org.openstreetmap.josm.tools.AlphanumComparator;
|
---|
44 | import org.openstreetmap.josm.tools.Destroyable;
|
---|
45 | import org.openstreetmap.josm.tools.ListenerList;
|
---|
46 | import org.openstreetmap.josm.tools.Pair;
|
---|
47 |
|
---|
48 | /**
|
---|
49 | * A panel that displays the error tree. The selection manager
|
---|
50 | * respects clicks into the selection list. Ctrl-click will remove entries from
|
---|
51 | * the list while single click will make the clicked entry the only selection.
|
---|
52 | *
|
---|
53 | * @author frsantos
|
---|
54 | */
|
---|
55 | public class ValidatorTreePanel extends JTree implements Destroyable, DataSetListener {
|
---|
56 |
|
---|
57 | private static final class GroupTreeNode extends DefaultMutableTreeNode {
|
---|
58 |
|
---|
59 | GroupTreeNode(Object userObject) {
|
---|
60 | super(userObject);
|
---|
61 | }
|
---|
62 |
|
---|
63 | @Override
|
---|
64 | public String toString() {
|
---|
65 | return tr("{0} ({1})", super.toString(), getLeafCount());
|
---|
66 | }
|
---|
67 | }
|
---|
68 |
|
---|
69 | /**
|
---|
70 | * The validation data.
|
---|
71 | */
|
---|
72 | protected DefaultTreeModel valTreeModel = new DefaultTreeModel(new DefaultMutableTreeNode());
|
---|
73 |
|
---|
74 | /** The list of errors shown in the tree, normally identical to field validationErrors in current edit layer*/
|
---|
75 | private transient List<TestError> errors;
|
---|
76 |
|
---|
77 | /**
|
---|
78 | * If {@link #filter} is not <code>null</code> only errors are displayed
|
---|
79 | * that refer to one of the primitives in the filter.
|
---|
80 | */
|
---|
81 | private transient Set<? extends OsmPrimitive> filter;
|
---|
82 |
|
---|
83 | private final transient ListenerList<Runnable> invalidationListeners = ListenerList.create();
|
---|
84 |
|
---|
85 | /** if true, buildTree() does nothing */
|
---|
86 | private boolean resetScheduled;
|
---|
87 |
|
---|
88 | /**
|
---|
89 | * Constructor
|
---|
90 | * @param errors The list of errors
|
---|
91 | */
|
---|
92 | public ValidatorTreePanel(List<TestError> errors) {
|
---|
93 | setErrorList(errors);
|
---|
94 | ToolTipManager.sharedInstance().registerComponent(this);
|
---|
95 | this.setModel(valTreeModel);
|
---|
96 | this.setRootVisible(false);
|
---|
97 | this.setShowsRootHandles(true);
|
---|
98 | this.expandRow(0);
|
---|
99 | this.setVisibleRowCount(8);
|
---|
100 | this.setCellRenderer(new ValidatorTreeRenderer());
|
---|
101 | this.getSelectionModel().setSelectionMode(TreeSelectionModel.DISCONTIGUOUS_TREE_SELECTION);
|
---|
102 | for (KeyListener keyListener : getKeyListeners()) {
|
---|
103 | // Fix #3596 - Remove default keyListener to avoid conflicts with JOSM commands
|
---|
104 | if ("javax.swing.plaf.basic.BasicTreeUI$Handler".equals(keyListener.getClass().getName())) {
|
---|
105 | removeKeyListener(keyListener);
|
---|
106 | }
|
---|
107 | }
|
---|
108 | DatasetEventManager.getInstance().addDatasetListener(this, DatasetEventManager.FireMode.IN_EDT);
|
---|
109 | }
|
---|
110 |
|
---|
111 | @Override
|
---|
112 | public String getToolTipText(MouseEvent e) {
|
---|
113 | String res = null;
|
---|
114 | TreePath path = getPathForLocation(e.getX(), e.getY());
|
---|
115 | if (path != null) {
|
---|
116 | DefaultMutableTreeNode node = (DefaultMutableTreeNode) path.getLastPathComponent();
|
---|
117 | Object nodeInfo = node.getUserObject();
|
---|
118 |
|
---|
119 | if (nodeInfo instanceof TestError) {
|
---|
120 | TestError error = (TestError) nodeInfo;
|
---|
121 | res = "<html>" + error.getNameVisitor().getText() + "<br>" + error.getMessage();
|
---|
122 | String d = error.getDescription();
|
---|
123 | if (d != null)
|
---|
124 | res += "<br>" + d;
|
---|
125 | res += "</html>";
|
---|
126 | } else {
|
---|
127 | res = node.toString();
|
---|
128 | }
|
---|
129 | }
|
---|
130 | return res;
|
---|
131 | }
|
---|
132 |
|
---|
133 | /** Constructor */
|
---|
134 | public ValidatorTreePanel() {
|
---|
135 | this(null);
|
---|
136 | }
|
---|
137 |
|
---|
138 | @Override
|
---|
139 | public void setVisible(boolean v) {
|
---|
140 | if (v) {
|
---|
141 | buildTree();
|
---|
142 | } else {
|
---|
143 | valTreeModel.setRoot(new DefaultMutableTreeNode());
|
---|
144 | }
|
---|
145 | super.setVisible(v);
|
---|
146 | invalidationListeners.fireEvent(Runnable::run);
|
---|
147 | }
|
---|
148 |
|
---|
149 | /**
|
---|
150 | * Builds the errors tree
|
---|
151 | */
|
---|
152 | public void buildTree() {
|
---|
153 | if (resetScheduled)
|
---|
154 | return;
|
---|
155 | final DefaultMutableTreeNode rootNode = new DefaultMutableTreeNode();
|
---|
156 |
|
---|
157 | if (errors == null || errors.isEmpty()) {
|
---|
158 | GuiHelper.runInEDTAndWait(() -> valTreeModel.setRoot(rootNode));
|
---|
159 | return;
|
---|
160 | }
|
---|
161 |
|
---|
162 | // Remember first selected tree row
|
---|
163 | TreePath selPath = getSelectionPath();
|
---|
164 | int selRow = selPath == null ? -1 : getRowForPath(selPath);
|
---|
165 |
|
---|
166 | // Remember the currently expanded rows
|
---|
167 | Set<Object> oldExpandedRows = new HashSet<>();
|
---|
168 | Enumeration<TreePath> expanded = getExpandedDescendants(new TreePath(getRoot()));
|
---|
169 | if (expanded != null) {
|
---|
170 | while (expanded.hasMoreElements()) {
|
---|
171 | TreePath path = expanded.nextElement();
|
---|
172 | DefaultMutableTreeNode node = (DefaultMutableTreeNode) path.getLastPathComponent();
|
---|
173 | Object userObject = node.getUserObject();
|
---|
174 | if (userObject instanceof Severity) {
|
---|
175 | oldExpandedRows.add(userObject);
|
---|
176 | } else if (userObject instanceof String) {
|
---|
177 | String msg = (String) userObject;
|
---|
178 | int index = msg.lastIndexOf(" (");
|
---|
179 | if (index > 0) {
|
---|
180 | msg = msg.substring(0, index);
|
---|
181 | }
|
---|
182 | oldExpandedRows.add(msg);
|
---|
183 | }
|
---|
184 | }
|
---|
185 | }
|
---|
186 |
|
---|
187 | Predicate<TestError> filterToUse = e -> !e.isIgnored();
|
---|
188 | if (!ValidatorPrefHelper.PREF_OTHER.get()) {
|
---|
189 | filterToUse = filterToUse.and(e -> e.getSeverity() != Severity.OTHER);
|
---|
190 | }
|
---|
191 | if (filter != null) {
|
---|
192 | filterToUse = filterToUse.and(e -> e.getPrimitives().stream().anyMatch(filter::contains));
|
---|
193 | }
|
---|
194 | Map<Severity, Map<String, Map<String, List<TestError>>>> errorsBySeverityMessageDescription
|
---|
195 | = OsmValidator.getErrorsBySeverityMessageDescription(errors, filterToUse);
|
---|
196 |
|
---|
197 | final List<TreePath> expandedPaths = new ArrayList<>();
|
---|
198 | for (Entry<Severity, Map<String, Map<String, List<TestError>>>> entry: errorsBySeverityMessageDescription.entrySet()) {
|
---|
199 | Severity severity = entry.getKey();
|
---|
200 | Map<String, Map<String, List<TestError>>> errorsByMessageDescription = entry.getValue();
|
---|
201 |
|
---|
202 | // Severity node
|
---|
203 | final DefaultMutableTreeNode severityNode = new GroupTreeNode(severity);
|
---|
204 | rootNode.add(severityNode);
|
---|
205 |
|
---|
206 | final Map<String, List<TestError>> errorsWithEmptyMessageByDescription = errorsByMessageDescription.get("");
|
---|
207 | if (errorsWithEmptyMessageByDescription != null) {
|
---|
208 | errorsWithEmptyMessageByDescription.forEach((description, noDescriptionErrors) -> {
|
---|
209 | final String msg = tr("{0} ({1})", description, noDescriptionErrors.size());
|
---|
210 | final DefaultMutableTreeNode messageNode = new DefaultMutableTreeNode(msg);
|
---|
211 | severityNode.add(messageNode);
|
---|
212 |
|
---|
213 | if (oldExpandedRows.contains(description)) {
|
---|
214 | expandedPaths.add(new TreePath(new Object[] { rootNode, severityNode, messageNode }));
|
---|
215 | }
|
---|
216 | // add the matching errors to the current node
|
---|
217 | noDescriptionErrors.stream().map(DefaultMutableTreeNode::new).forEach(messageNode::add);
|
---|
218 | });
|
---|
219 | }
|
---|
220 |
|
---|
221 | errorsByMessageDescription.forEach((message, errorsByDescription) -> {
|
---|
222 | if (message.isEmpty()) {
|
---|
223 | return;
|
---|
224 | }
|
---|
225 | // Group node
|
---|
226 | final DefaultMutableTreeNode groupNode;
|
---|
227 | if (errorsByDescription.size() > 1) {
|
---|
228 | groupNode = new GroupTreeNode(message);
|
---|
229 | severityNode.add(groupNode);
|
---|
230 | if (oldExpandedRows.contains(message)) {
|
---|
231 | expandedPaths.add(new TreePath(new Object[] {rootNode, severityNode, groupNode}));
|
---|
232 | }
|
---|
233 | } else {
|
---|
234 | groupNode = null;
|
---|
235 | }
|
---|
236 |
|
---|
237 | errorsByDescription.forEach((description, errorsWithDescription) -> {
|
---|
238 | boolean emptyDescription = description == null || description.isEmpty();
|
---|
239 | // Message node
|
---|
240 | final String msg;
|
---|
241 | if (groupNode != null) {
|
---|
242 | msg = tr("{0} ({1})", description, errorsWithDescription.size());
|
---|
243 | } else if (emptyDescription) {
|
---|
244 | msg = tr("{0} ({1})", message, errorsWithDescription.size());
|
---|
245 | } else {
|
---|
246 | msg = tr("{0} - {1} ({2})", message, description, errorsWithDescription.size());
|
---|
247 | }
|
---|
248 | final DefaultMutableTreeNode messageNode = new DefaultMutableTreeNode(msg);
|
---|
249 | if (groupNode != null) {
|
---|
250 | groupNode.add(messageNode);
|
---|
251 | } else {
|
---|
252 | severityNode.add(messageNode);
|
---|
253 | }
|
---|
254 |
|
---|
255 | if (oldExpandedRows.contains(description) || (emptyDescription && oldExpandedRows.contains(message))) {
|
---|
256 | if (groupNode != null) {
|
---|
257 | expandedPaths.add(new TreePath(new Object[] {rootNode, severityNode, groupNode, messageNode}));
|
---|
258 | } else {
|
---|
259 | expandedPaths.add(new TreePath(new Object[] {rootNode, severityNode, messageNode}));
|
---|
260 | }
|
---|
261 | }
|
---|
262 |
|
---|
263 | // add the matching errors to the current node
|
---|
264 | errorsWithDescription.stream().map(DefaultMutableTreeNode::new).forEach(messageNode::add);
|
---|
265 | });
|
---|
266 | });
|
---|
267 | }
|
---|
268 |
|
---|
269 | valTreeModel.setRoot(rootNode);
|
---|
270 | for (TreePath path : expandedPaths) {
|
---|
271 | this.expandPath(path);
|
---|
272 | }
|
---|
273 |
|
---|
274 | if (selRow >= 0 && selRow < getRowCount()) {
|
---|
275 | setSelectionRow(selRow);
|
---|
276 | scrollRowToVisible(selRow);
|
---|
277 | }
|
---|
278 |
|
---|
279 | invalidationListeners.fireEvent(Runnable::run);
|
---|
280 | }
|
---|
281 |
|
---|
282 | /**
|
---|
283 | * Sort list of errors in place (#8517).
|
---|
284 | */
|
---|
285 | void sortErrors() {
|
---|
286 | if (errors.isEmpty())
|
---|
287 | return;
|
---|
288 | // Calculate the string to sort only once for each element
|
---|
289 | // Avoids to call TestError.compare() which is costly
|
---|
290 | List<Pair<String, TestError>> toSort = new ArrayList<>();
|
---|
291 | for (int i = 0; i < errors.size(); i++) {
|
---|
292 | TestError e = errors.get(i);
|
---|
293 | toSort.add(new Pair<>(e.getNameVisitor().getText(), e));
|
---|
294 | }
|
---|
295 | toSort.sort((o1, o2) -> AlphanumComparator.getInstance().compare(o1.a, o2.a));
|
---|
296 | List<TestError> sortedErrors = new ArrayList<>(errors.size());
|
---|
297 | for (Pair<String, TestError> p : toSort) {
|
---|
298 | sortedErrors.add(p.b);
|
---|
299 | }
|
---|
300 | errors.clear();
|
---|
301 | errors.addAll(sortedErrors);
|
---|
302 | }
|
---|
303 |
|
---|
304 | /**
|
---|
305 | * Add a new invalidation listener
|
---|
306 | * @param listener The listener
|
---|
307 | */
|
---|
308 | public void addInvalidationListener(Runnable listener) {
|
---|
309 | invalidationListeners.addListener(listener);
|
---|
310 | }
|
---|
311 |
|
---|
312 | /**
|
---|
313 | * Remove an invalidation listener
|
---|
314 | * @param listener The listener
|
---|
315 | * @since 10880
|
---|
316 | */
|
---|
317 | public void removeInvalidationListener(Runnable listener) {
|
---|
318 | invalidationListeners.removeListener(listener);
|
---|
319 | }
|
---|
320 |
|
---|
321 | /**
|
---|
322 | * Sets the errors list used by a data layer
|
---|
323 | * @param errors The error list that is used by a data layer
|
---|
324 | */
|
---|
325 | public final void setErrorList(List<TestError> errors) {
|
---|
326 | this.errors = errors != null ? errors : new ArrayList<>();
|
---|
327 | sortErrors();
|
---|
328 | if (isVisible()) {
|
---|
329 | buildTree();
|
---|
330 | }
|
---|
331 | }
|
---|
332 |
|
---|
333 | /**
|
---|
334 | * Clears the current error list and adds these errors to it
|
---|
335 | * @param newerrors The validation errors
|
---|
336 | */
|
---|
337 | public void setErrors(List<TestError> newerrors) {
|
---|
338 | errors.clear();
|
---|
339 | for (TestError error : newerrors) {
|
---|
340 | if (!error.isIgnored()) {
|
---|
341 | errors.add(error);
|
---|
342 | }
|
---|
343 | }
|
---|
344 | sortErrors();
|
---|
345 | if (isVisible()) {
|
---|
346 | buildTree();
|
---|
347 | }
|
---|
348 | }
|
---|
349 |
|
---|
350 | /**
|
---|
351 | * Returns the errors of the tree
|
---|
352 | * @return the errors of the tree
|
---|
353 | */
|
---|
354 | public List<TestError> getErrors() {
|
---|
355 | return errors;
|
---|
356 | }
|
---|
357 |
|
---|
358 | /**
|
---|
359 | * Selects all errors related to the specified {@code primitives}, i.e. where {@link TestError#getPrimitives()}
|
---|
360 | * returns a primitive present in {@code primitives}.
|
---|
361 | * @param primitives collection of primitives
|
---|
362 | */
|
---|
363 | public void selectRelatedErrors(final Collection<OsmPrimitive> primitives) {
|
---|
364 | final List<TreePath> paths = new ArrayList<>();
|
---|
365 | walkAndSelectRelatedErrors(new TreePath(getRoot()), new HashSet<>(primitives)::contains, paths);
|
---|
366 | getSelectionModel().clearSelection();
|
---|
367 | getSelectionModel().setSelectionPaths(paths.toArray(new TreePath[0]));
|
---|
368 | // make sure that first path is visible
|
---|
369 | if (!paths.isEmpty()) {
|
---|
370 | scrollPathToVisible(paths.get(0));
|
---|
371 | }
|
---|
372 | }
|
---|
373 |
|
---|
374 | private void walkAndSelectRelatedErrors(final TreePath p, final Predicate<OsmPrimitive> isRelevant, final Collection<TreePath> paths) {
|
---|
375 | final int count = getModel().getChildCount(p.getLastPathComponent());
|
---|
376 | for (int i = 0; i < count; i++) {
|
---|
377 | final Object child = getModel().getChild(p.getLastPathComponent(), i);
|
---|
378 | if (getModel().isLeaf(child) && child instanceof DefaultMutableTreeNode
|
---|
379 | && ((DefaultMutableTreeNode) child).getUserObject() instanceof TestError) {
|
---|
380 | final TestError error = (TestError) ((DefaultMutableTreeNode) child).getUserObject();
|
---|
381 | if (error.getPrimitives().stream().anyMatch(isRelevant)) {
|
---|
382 | paths.add(p.pathByAddingChild(child));
|
---|
383 | }
|
---|
384 | } else {
|
---|
385 | walkAndSelectRelatedErrors(p.pathByAddingChild(child), isRelevant, paths);
|
---|
386 | }
|
---|
387 | }
|
---|
388 | }
|
---|
389 |
|
---|
390 | /**
|
---|
391 | * Returns the filter list
|
---|
392 | * @return the list of primitives used for filtering
|
---|
393 | */
|
---|
394 | public Set<? extends OsmPrimitive> getFilter() {
|
---|
395 | return filter;
|
---|
396 | }
|
---|
397 |
|
---|
398 | /**
|
---|
399 | * Set the filter list to a set of primitives
|
---|
400 | * @param filter the list of primitives used for filtering
|
---|
401 | */
|
---|
402 | public void setFilter(Set<? extends OsmPrimitive> filter) {
|
---|
403 | if (filter != null && filter.isEmpty()) {
|
---|
404 | this.filter = null;
|
---|
405 | } else {
|
---|
406 | this.filter = filter;
|
---|
407 | }
|
---|
408 | if (isVisible()) {
|
---|
409 | buildTree();
|
---|
410 | }
|
---|
411 | }
|
---|
412 |
|
---|
413 | /**
|
---|
414 | * Updates the current errors list
|
---|
415 | */
|
---|
416 | public void resetErrors() {
|
---|
417 | resetScheduled = false;
|
---|
418 | filterRemovedPrimitives();
|
---|
419 | setErrors(new ArrayList<>(errors));
|
---|
420 | }
|
---|
421 |
|
---|
422 | /**
|
---|
423 | * Expands complete tree
|
---|
424 | */
|
---|
425 | public void expandAll() {
|
---|
426 | visitTreeNodes(getRoot(), x -> expandPath(new TreePath(x.getPath())));
|
---|
427 | }
|
---|
428 |
|
---|
429 | /**
|
---|
430 | * Returns the root node model.
|
---|
431 | * @return The root node model
|
---|
432 | */
|
---|
433 | public DefaultMutableTreeNode getRoot() {
|
---|
434 | return (DefaultMutableTreeNode) valTreeModel.getRoot();
|
---|
435 | }
|
---|
436 |
|
---|
437 | @Override
|
---|
438 | public void destroy() {
|
---|
439 | DatasetEventManager.getInstance().removeDatasetListener(this);
|
---|
440 | ToolTipManager.sharedInstance().unregisterComponent(this);
|
---|
441 | errors.clear();
|
---|
442 | }
|
---|
443 |
|
---|
444 | /**
|
---|
445 | * Visitor call for all tree nodes children of root, in breadth-first order.
|
---|
446 | * @param root Root node
|
---|
447 | * @param visitor Visitor
|
---|
448 | * @since 13940
|
---|
449 | */
|
---|
450 | public static void visitTreeNodes(DefaultMutableTreeNode root, Consumer<DefaultMutableTreeNode> visitor) {
|
---|
451 | @SuppressWarnings("unchecked")
|
---|
452 | Enumeration<TreeNode> errorMessages = root.breadthFirstEnumeration();
|
---|
453 | while (errorMessages.hasMoreElements()) {
|
---|
454 | visitor.accept(((DefaultMutableTreeNode) errorMessages.nextElement()));
|
---|
455 | }
|
---|
456 | }
|
---|
457 |
|
---|
458 | /**
|
---|
459 | * Visitor call for all {@link TestError} nodes children of root, in breadth-first order.
|
---|
460 | * @param root Root node
|
---|
461 | * @param visitor Visitor
|
---|
462 | * @since 13940
|
---|
463 | */
|
---|
464 | public static void visitTestErrors(DefaultMutableTreeNode root, Consumer<TestError> visitor) {
|
---|
465 | visitTestErrors(root, visitor, null);
|
---|
466 | }
|
---|
467 |
|
---|
468 | /**
|
---|
469 | * Visitor call for all {@link TestError} nodes children of root, in breadth-first order.
|
---|
470 | * @param root Root node
|
---|
471 | * @param visitor Visitor
|
---|
472 | * @param processedNodes Set of already visited nodes (optional)
|
---|
473 | * @since 13940
|
---|
474 | */
|
---|
475 | public static void visitTestErrors(DefaultMutableTreeNode root, Consumer<TestError> visitor,
|
---|
476 | Set<DefaultMutableTreeNode> processedNodes) {
|
---|
477 | visitTreeNodes(root, n -> {
|
---|
478 | if (processedNodes == null || !processedNodes.contains(n)) {
|
---|
479 | if (processedNodes != null) {
|
---|
480 | processedNodes.add(n);
|
---|
481 | }
|
---|
482 | Object o = n.getUserObject();
|
---|
483 | if (o instanceof TestError) {
|
---|
484 | visitor.accept((TestError) o);
|
---|
485 | }
|
---|
486 | }
|
---|
487 | });
|
---|
488 | }
|
---|
489 |
|
---|
490 | @Override public void primitivesRemoved(PrimitivesRemovedEvent event) {
|
---|
491 | // Remove purged primitives (fix #8639)
|
---|
492 | if (filterRemovedPrimitives()) {
|
---|
493 | buildTree();
|
---|
494 | }
|
---|
495 | }
|
---|
496 |
|
---|
497 | @Override public void primitivesAdded(PrimitivesAddedEvent event) {
|
---|
498 | // Do nothing
|
---|
499 | }
|
---|
500 |
|
---|
501 | @Override public void tagsChanged(TagsChangedEvent event) {
|
---|
502 | // Do nothing
|
---|
503 | }
|
---|
504 |
|
---|
505 | @Override public void nodeMoved(NodeMovedEvent event) {
|
---|
506 | // Do nothing
|
---|
507 | }
|
---|
508 |
|
---|
509 | @Override public void wayNodesChanged(WayNodesChangedEvent event) {
|
---|
510 | // Do nothing
|
---|
511 | }
|
---|
512 |
|
---|
513 | @Override public void relationMembersChanged(RelationMembersChangedEvent event) {
|
---|
514 | // Do nothing
|
---|
515 | }
|
---|
516 |
|
---|
517 | @Override public void otherDatasetChange(AbstractDatasetChangedEvent event) {
|
---|
518 | // Do nothing
|
---|
519 | }
|
---|
520 |
|
---|
521 | @Override public void dataChanged(DataChangedEvent event) {
|
---|
522 | if (filterRemovedPrimitives()) {
|
---|
523 | buildTree();
|
---|
524 | }
|
---|
525 | }
|
---|
526 |
|
---|
527 | /**
|
---|
528 | * Can be called to suppress execution of buildTree() while doing multiple updates. Caller must
|
---|
529 | * call resetErrors() to end this state.
|
---|
530 | * @since 14849
|
---|
531 | */
|
---|
532 | public void setResetScheduled() {
|
---|
533 | resetScheduled = true;
|
---|
534 | }
|
---|
535 |
|
---|
536 | /**
|
---|
537 | * Remove errors which refer to removed or purged primitives.
|
---|
538 | * @return true if error list was changed
|
---|
539 | */
|
---|
540 | private boolean filterRemovedPrimitives() {
|
---|
541 | return errors.removeIf(
|
---|
542 | error -> error.getPrimitives().stream().anyMatch(p -> p.isDeleted() || p.getDataSet() == null));
|
---|
543 | }
|
---|
544 |
|
---|
545 | }
|
---|