Changeset 14463 in josm for trunk/src/org/openstreetmap/josm/gui/dialogs/ToggleDialog.java

Timestamp:

2018-11-28T22:42:32+01:00 (5 years ago)

Author:

Don-vip

Message:

fix #17040 - fix memory leaks when calling history dialog

File:

• trunk/src/org/openstreetmap/josm/gui/dialogs/ToggleDialog.java (modified) (2 diffs)

trunk/src/org/openstreetmap/josm/gui/dialogs/ToggleDialog.java

@@ -7 +7 @@
 import java.awt.BorderLayout;
 import java.awt.Component;
-import java.awt.Container;
 import java.awt.Dimension;
 import java.awt.FlowLayout;
@@ -469 +468 @@
         }
         Config.getPref().removePreferenceChangeListener(this);
-        destroyComponents(this, false);
-    }
-
-    private static void destroyComponents(Component component, boolean destroyItself) {
-        if (component instanceof Container) {
-            for (Component c: ((Container) component).getComponents()) {
-                destroyComponents(c, true);
-            }
-        }
-        if (destroyItself && component instanceof Destroyable) {
-            ((Destroyable) component).destroy();
-        }
+        GuiHelper.destroyComponents(this, false);
     }