Changeset 14412 in josm for trunk/test/unit/org/openstreetmap

Timestamp:

2018-11-05T01:16:59+01:00 (6 years ago)

Author:

Don-vip

Message:

fix #16946, fix #16947 - unit test fixes for non-headless mode (patch by ris)

Location:

trunk/test/unit/org/openstreetmap/josm

Files:

• gui/datatransfer/ClipboardUtilsTest.java (modified) (2 diffs)
• gui/help/HelpBrowserTest.java (modified) (4 diffs)
• gui/layer/markerlayer/WebMarkerTest.java (modified) (3 diffs)
• tools/PlatformHookWindowsTest.java (modified) (3 diffs)

trunk/test/unit/org/openstreetmap/josm/gui/datatransfer/ClipboardUtilsTest.java

@@ -7 +7 @@
 import static org.junit.Assert.assertSame;
 import static org.junit.Assert.assertTrue;
+import static org.junit.Assume.assumeTrue;
 
 import java.awt.GraphicsEnvironment;
@@ -118 +119 @@
     @Test
     public void testSystemSelectionDoesNotFail() {
-        assertTrue(GraphicsEnvironment.isHeadless());
+        assumeTrue(GraphicsEnvironment.isHeadless());
         assertNull(ClipboardUtils.getSystemSelection());
     }

trunk/test/unit/org/openstreetmap/josm/gui/help/HelpBrowserTest.java

@@ -13 +13 @@
 import org.openstreetmap.josm.testutils.mockers.JOptionPaneSimpleMocker;
 import org.openstreetmap.josm.tools.LanguageInfo.LocaleType;
+import org.openstreetmap.josm.tools.PlatformHook;
+import org.openstreetmap.josm.tools.PlatformManager;
 
 import com.google.common.collect.ImmutableMap;
 
 import edu.umd.cs.findbugs.annotations.SuppressFBWarnings;
+import mockit.Expectations;
+import mockit.Injectable;
 
 /**
@@ -91 +95 @@
 
     /**
-     * Unit test of {@link HelpBrowser.EditAction} class.
-     */
-    @Test
-    public void testEditAction() {
-        TestUtils.assumeWorkingJMockit();
+     * Unit test of {@link HelpBrowser.EditAction} class handling a null url.
+     * @param mockPlatformHook platform hook mock
+     * @throws Exception  in case of error
+     */
+    @Test
+    public void testEditActionNull(@Injectable final PlatformHook mockPlatformHook) throws Exception {
+        TestUtils.assumeWorkingJMockit();
+        new Expectations(PlatformManager.class) {{
+            PlatformManager.getPlatform(); result = mockPlatformHook; minTimes = 0;
+        }};
+        new Expectations() {{
+            // should not be called
+            mockPlatformHook.openUrl((String) any); times = 0;
+        }};
+
         IHelpBrowser browser = newHelpBrowser();
         assertNull(browser.getUrl());
         new HelpBrowser.EditAction(browser).actionPerformed(null);
-
+    }
+
+    /**
+     * Unit test of {@link HelpBrowser.EditAction} class handling an "internal" url.
+     * @param mockPlatformHook platform hook mock
+     * @throws Exception  in case of error
+     */
+    @Test
+    public void testEditActionInternal(@Injectable final PlatformHook mockPlatformHook) throws Exception {
+        TestUtils.assumeWorkingJMockit();
+        new Expectations(PlatformManager.class) {{
+            PlatformManager.getPlatform(); result = mockPlatformHook;
+        }};
+        new Expectations() {{
+            mockPlatformHook.openUrl(URL_2 + "?action=edit"); result = null; times = 1;
+        }};
+
+        IHelpBrowser browser = newHelpBrowser();
         browser.openUrl(URL_2);
         assertEquals(URL_2, browser.getUrl());
         new HelpBrowser.EditAction(browser).actionPerformed(null);
-
+    }
+
+    /**
+     * Unit test of {@link HelpBrowser.EditAction} class handling an "external" url.
+     * @param mockPlatformHook platform hook mock
+     * @throws Exception  in case of error
+     */
+    @Test
+    public void testEditActionExternal(@Injectable final PlatformHook mockPlatformHook) throws Exception {
+        TestUtils.assumeWorkingJMockit();
+        new Expectations(PlatformManager.class) {{
+            PlatformManager.getPlatform(); result = mockPlatformHook; minTimes = 0;
+        }};
+        new Expectations() {{
+            // should not be called
+            mockPlatformHook.openUrl((String) any); times = 0;
+        }};
         final JOptionPaneSimpleMocker jopsMocker = new JOptionPaneSimpleMocker(
             ImmutableMap.<String, Object>of(
@@ -113 +160 @@
         );
 
+        IHelpBrowser browser = newHelpBrowser();
         browser.openUrl(URL_3);
         assertEquals(URL_3, browser.getUrl());
@@ -125 +173 @@
     /**
      * Unit test of {@link HelpBrowser.OpenInBrowserAction} class.
-     */
-    @Test
-    public void testOpenInBrowserAction() {
+     * @param mockPlatformHook platform hook mock
+     * @throws Exception  in case of error
+     */
+    @Test
+    public void testOpenInBrowserAction(@Injectable final PlatformHook mockPlatformHook) throws Exception {
+        TestUtils.assumeWorkingJMockit();
+        new Expectations(PlatformManager.class) {{
+            PlatformManager.getPlatform(); result = mockPlatformHook;
+        }};
+        new Expectations() {{
+            mockPlatformHook.openUrl(URL_1); result = null; times = 1;
+        }};
+
         IHelpBrowser browser = newHelpBrowser();
         browser.openUrl(URL_1);

trunk/test/unit/org/openstreetmap/josm/gui/layer/markerlayer/WebMarkerTest.java

@@ -4 +4 @@
 import static org.junit.Assert.assertEquals;
 
-import java.net.MalformedURLException;
 import java.net.URL;
 
@@ -10 +9 @@
 import org.junit.Test;
 import org.openstreetmap.josm.JOSMFixture;
+import org.openstreetmap.josm.TestUtils;
 import org.openstreetmap.josm.data.coor.LatLon;
 import org.openstreetmap.josm.data.gpx.GpxData;
 import org.openstreetmap.josm.data.gpx.WayPoint;
+import org.openstreetmap.josm.tools.PlatformManager;
+import org.openstreetmap.josm.tools.PlatformHook;
+
+
+import mockit.Expectations;
+import mockit.Injectable;
 
 /**
@@ -29 +35 @@
     /**
      * Unit test of {@link WebMarker#WebMarker}.
-     * @throws MalformedURLException never
+     * @param mockPlatformHook platform hook mock
+     * @throws Exception  in case of error
      */
     @Test
-    public void testWebMarker() throws MalformedURLException {
+    public void testWebMarker(@Injectable final PlatformHook mockPlatformHook) throws Exception {
+        TestUtils.assumeWorkingJMockit();
+        new Expectations(PlatformManager.class) {{
+            PlatformManager.getPlatform(); result = mockPlatformHook;
+        }};
+        new Expectations() {{
+            mockPlatformHook.openUrl("http://example.com"); result = null; times = 1;
+        }};
+
         WebMarker marker = new WebMarker(
                 LatLon.ZERO,

trunk/test/unit/org/openstreetmap/josm/tools/PlatformHookWindowsTest.java

@@ -10 +10 @@
 import static org.junit.Assert.fail;
 
+import java.awt.Desktop;
 import java.io.File;
 import java.io.IOException;
@@ -20 +21 @@
 import org.junit.Test;
 import org.openstreetmap.josm.JOSMFixture;
+import org.openstreetmap.josm.TestUtils;
 import org.openstreetmap.josm.io.remotecontrol.RemoteControlHttpsServer;
 import org.openstreetmap.josm.io.remotecontrol.RemoteControlTest;
 import org.openstreetmap.josm.spi.preferences.Config;
+
+import mockit.Expectations;
+import mockit.Injectable;
 
 /**
@@ -117 +122 @@
 
     /**
-     * Test method for {@code PlatformHookWindows#openUrl}
+     * Test method for {@code PlatformHookWindows#openUrl} when Desktop works as expected
+     * @param mockDesktop desktop mock
      * @throws IOException if an error occurs
      */
     @Test
-    public void testOpenUrl() throws IOException {
-        if (PlatformManager.isPlatformWindows()) {
-            hook.openUrl(Config.getUrls().getJOSMWebsite());
-        } else {
-            try {
-                hook.openUrl(Config.getUrls().getJOSMWebsite());
-                fail("Expected IOException");
-            } catch (IOException e) {
-                Logging.info(e.getMessage());
-            }
-        }
+    public void testOpenUrlSuccess(@Injectable final Desktop mockDesktop) throws IOException {
+        TestUtils.assumeWorkingJMockit();
+        new Expectations(Desktop.class) {{
+            // real implementation would raise HeadlessException
+            Desktop.getDesktop(); result = mockDesktop; times = 1;
+        }};
+        new Expectations() {{
+            mockDesktop.browse(withNotNull()); times = 1;
+        }};
+
+        hook.openUrl(Config.getUrls().getJOSMWebsite());
+    }
+
+    /**
+     * Test method for {@code PlatformHookWindows#openUrl} when Desktop fails
+     * @param mockDesktop desktop mock
+     * @throws IOException if an error occurs
+     */
+    @Test
+    public void testOpenUrlFallback(@Injectable final Desktop mockDesktop) throws IOException {
+        TestUtils.assumeWorkingJMockit();
+        new Expectations(Desktop.class) {{
+            // real implementation would raise HeadlessException
+            Desktop.getDesktop(); result = mockDesktop; times = 1;
+        }};
+        new Expectations() {{
+            mockDesktop.browse(withNotNull()); result = new IOException(); times = 1;
+        }};
+        final Runtime anyRuntime = Runtime.getRuntime();
+        new Expectations(Runtime.class) {{
+            anyRuntime.exec(new String[] {"rundll32", "url.dll,FileProtocolHandler", Config.getUrls().getJOSMWebsite()});
+            result = null;
+            times = 1;
+            // prevent a non-matching invocation being executed
+            anyRuntime.exec((String[]) withNotNull()); result = null; times = 0;
+        }};
+
+        hook.openUrl(Config.getUrls().getJOSMWebsite());
     }