Changeset 13204 in josm for trunk/src/org/openstreetmap/josm/gui/io/DownloadFileTask.java

Timestamp:

2017-12-17T00:17:20+01:00 (6 years ago)

Author:

Don-vip

Message:

enable new PMD rule AvoidFileStream - see ​https://pmd.github.io/pmd-6.0.0/pmd_rules_java_performance.html#avoidfilestream / ​https://bugs.openjdk.java.net/browse/JDK-8080225 for details

File:

• trunk/src/org/openstreetmap/josm/gui/io/DownloadFileTask.java (modified) (4 diffs)

trunk/src/org/openstreetmap/josm/gui/io/DownloadFileTask.java

@@ -6 +6 @@
 import java.awt.Component;
 import java.io.File;
-import java.io.FileOutputStream;
 import java.io.IOException;
 import java.io.InputStream;
@@ -14 +13 @@
 import java.nio.charset.StandardCharsets;
 import java.nio.file.Files;
+import java.nio.file.InvalidPathException;
 import java.nio.file.StandardCopyOption;
 import java.util.Enumeration;
@@ -115 +115 @@
             try (
                 InputStream in = downloadConnection.getResponse().getContent();
-                OutputStream out = new FileOutputStream(file)
+                OutputStream out = Files.newOutputStream(file.toPath())
             ) {
                 byte[] buffer = new byte[32_768];
@@ -145 +145 @@
             Logging.warn(msg);
             throw new DownloadException(msg, e);
-        } catch (IOException e) {
+        } catch (IOException | InvalidPathException e) {
             if (canceled)
                 return;