Changeset 12170 in josm for trunk/src/org/openstreetmap

Timestamp:

2017-05-15T17:43:48+02:00 (7 years ago)

Author:

michael2402

Message:

"See #13175, see #14120: Remove isChanged() method call in map view - all layers should invalidate correctly now."

Location:

trunk/src/org/openstreetmap/josm/gui

Files:

• MapView.java (modified) (1 diff)
• layer/AbstractTileSourceLayer.java (modified) (1 diff)
• layer/Layer.java (modified) (1 diff)

trunk/src/org/openstreetmap/josm/gui/MapView.java

@@ -487 +487 @@
         Set<MapViewPaintable> invalidated = invalidatedListener.collectInvalidatedLayers();
         for (Layer l: visibleLayers) {
-            // `isChanged` for backward compatibility, see https://josm.openstreetmap.de/ticket/13175#comment:7
-            // Layers that still implement it (plugins) will use it to tell the MapView that they have been changed.
-            // This is why the MapView still uses it in addition to the invalidation events.
-            if (l.isChanged() || invalidated.contains(l)) {
+            if (invalidated.contains(l)) {
                 break;
             } else {

trunk/src/org/openstreetmap/josm/gui/layer/AbstractTileSourceLayer.java

@@ -1670 +1670 @@
     }
 
-    @Override
-    public boolean isChanged() {
-        return false; // we use #invalidate()
-    }
-
     /**
      * Task responsible for precaching imagery along the gpx track

trunk/src/org/openstreetmap/josm/gui/layer/Layer.java

@@ -507 +507 @@
      * @deprecated This is not supported by multiple map views.
      * Fire an {@link #invalidate()} to trigger a repaint.
-     * Let this method return false if you only use invalidation events.
      */
     @Deprecated
     public boolean isChanged() {
-        return true;
+        return false;
     }