Changeset 10988 in josm for trunk/test/unit/org/openstreetmap/josm/plugins/PluginHandlerTestIT.java

Timestamp:

2016-09-10T16:13:02+02:00 (8 years ago)

Author:

Don-vip

Message:

improve plugin integration test

File:

• trunk/test/unit/org/openstreetmap/josm/plugins/PluginHandlerTestIT.java (modified) (4 diffs)

trunk/test/unit/org/openstreetmap/josm/plugins/PluginHandlerTestIT.java

@@ -13 +13 @@
 import java.util.Map;
 import java.util.Set;
+import java.util.function.Consumer;
 import java.util.stream.Collectors;
 
@@ -23 +24 @@
 import org.openstreetmap.josm.JOSMFixture;
 import org.openstreetmap.josm.Main;
+import org.openstreetmap.josm.data.gpx.GpxData;
 import org.openstreetmap.josm.data.osm.DataSet;
+import org.openstreetmap.josm.gui.layer.GpxLayer;
+import org.openstreetmap.josm.gui.layer.Layer;
 import org.openstreetmap.josm.gui.layer.OsmDataLayer;
 import org.openstreetmap.josm.gui.progress.NullProgressMonitor;
@@ -90 +94 @@
                 .collect(Collectors.toMap(e -> e.getKey(), e -> ExceptionUtils.getRootCause(e.getValue())));
 
-        // Add/remove a data layer twice to test basic plugin good behaviour
+        // Add/remove layers twice to test basic plugin good behaviour
         Map<String, Throwable> layerExceptions = new HashMap<>();
         List<PluginInformation> loadedPlugins = PluginHandler.getPlugins();
         for (int i = 0; i < 2; i++) {
             OsmDataLayer layer = new OsmDataLayer(new DataSet(), "Layer "+i, null);
-            try {
-                Main.getLayerManager().addLayer(layer);
-            } catch (Exception | LinkageError t) {
-                Throwable root = ExceptionUtils.getRootCause(t);
-                layerExceptions.put(findFaultyPlugin(loadedPlugins, root), root);
-            }
-            try {
-                Main.getLayerManager().removeLayer(layer);
-            } catch (Exception | LinkageError t) {
-                Throwable root = ExceptionUtils.getRootCause(t);
-                layerExceptions.put(findFaultyPlugin(loadedPlugins, root), root);
-            }
+            testPlugin(Main.getLayerManager()::addLayer, layer, layerExceptions, loadedPlugins);
+            testPlugin(Main.getLayerManager()::removeLayer, layer, layerExceptions, loadedPlugins);
+        }
+        for (int i = 0; i < 2; i++) {
+            GpxLayer layer = new GpxLayer(new GpxData());
+            testPlugin(Main.getLayerManager()::addLayer, layer, layerExceptions, loadedPlugins);
+            testPlugin(Main.getLayerManager()::removeLayer, layer, layerExceptions, loadedPlugins);
         }
 
@@ -114 +113 @@
                      Arrays.toString(layerExceptions.entrySet().toArray());
         assertTrue(msg, loadingExceptions.isEmpty() && layerExceptions.isEmpty());
+    }
+
+    void testPlugin(Consumer<Layer> consumer, Layer layer,
+            Map<String, Throwable> layerExceptions, Collection<PluginInformation> loadedPlugins) {
+        try {
+            consumer.accept(layer);
+        } catch (Exception | LinkageError t) {
+            Throwable root = ExceptionUtils.getRootCause(t);
+            root.printStackTrace();
+            layerExceptions.put(findFaultyPlugin(loadedPlugins, root), root);
+        }
     }