Changeset 10098 in josm

Timestamp:

2016-04-02T16:25:53+02:00 (7 years ago)

Author:

Don-vip

Message:

add more unit tests

Location:

trunk

Files:

• src/org/openstreetmap/josm/data/notes/Note.java (modified) (2 diffs)
• src/org/openstreetmap/josm/data/notes/NoteComment.java (modified) (1 diff)
• test/unit/org/openstreetmap/josm/data/notes (added)
• test/unit/org/openstreetmap/josm/data/notes/NoteCommentTest.java (added)
• test/unit/org/openstreetmap/josm/data/notes/NoteTest.java (added)
• test/unit/org/openstreetmap/josm/gui/preferences/PreferencesTestUtils.java (modified) (1 diff)

trunk/src/org/openstreetmap/josm/data/notes/Note.java

@@ -81 +81 @@
 
     public void addComment(NoteComment comment) {
-        this.comments.add(comment);
+        comments.add(comment);
     }
 
@@ -89 +89 @@
      */
     public NoteComment getFirstComment() {
-        return this.comments.get(0);
+        return comments.isEmpty() ? null : comments.get(0);
     }
 

trunk/src/org/openstreetmap/josm/data/notes/NoteComment.java

@@ -67 +67 @@
     }
 
+    /**
+     * Sets whether this is a new comment/action and needs to be uploaded to the API
+     * @param isNew {@code true} if this is a new comment/action and needs to be uploaded to the API
+     */
     public void setNew(boolean isNew) {
         this.isNew = isNew;

trunk/test/unit/org/openstreetmap/josm/gui/preferences/PreferencesTestUtils.java

@@ -40 +40 @@
             assertEquals(tabPane.getSetting(parentClass), ((SubPreferenceSetting) setting).getTabPreferenceSetting(tabPane));
         }
+        setting.ok();
     }
 }