Changeset 10097 in josm

Timestamp:

2016-04-02T13:04:59+02:00 (9 years ago)

Author:

Don-vip

Message:

fix #12717 - Warning about short comments when submitting Chinese comment

Location:

trunk

Files:

• src/org/openstreetmap/josm/gui/io/UploadDialog.java (modified) (2 diffs)
• test/unit/org/openstreetmap/josm/gui/io/UploadDialogTest.java (modified) (2 diffs)

trunk/src/org/openstreetmap/josm/gui/io/UploadDialog.java

@@ -18 +18 @@
 import java.beans.PropertyChangeEvent;
 import java.beans.PropertyChangeListener;
+import java.lang.Character.UnicodeBlock;
 import java.util.ArrayList;
 import java.util.Collection;
@@ -503 +504 @@
         }
 
+        static boolean isUploadCommentTooShort(String comment) {
+            String s = comment.trim();
+            boolean result = true;
+            if (!s.isEmpty()) {
+                UnicodeBlock block = Character.UnicodeBlock.of(s.charAt(0));
+                if (block.toString().contains("CJK")) {
+                    result = s.length() < 4;
+                } else {
+                    result = s.length() < 10;
+                }
+            }
+            return result;
+        }
+
         @Override
         public void actionPerformed(ActionEvent e) {
-            if (dialog.getUploadComment().trim().length() < 10 && warnUploadComment()) {
+            if (isUploadCommentTooShort(dialog.getUploadComment()) && warnUploadComment()) {
                 // abort for missing comment
                 dialog.handleMissingComment();

trunk/test/unit/org/openstreetmap/josm/gui/io/UploadDialogTest.java

@@ -1 +1 @@
 // License: GPL. For details, see LICENSE file.
 package org.openstreetmap.josm.gui.io;
+
+import static org.junit.Assert.assertFalse;
+import static org.junit.Assert.assertTrue;
 
 import java.util.Map;
@@ -90 +93 @@
         new UploadDialog.UploadAction(newUploadDialog("a comment long enough", "a source long enough")).actionPerformed(null);
     }
+
+    /**
+     * Test of {@link UploadDialog.UploadAction#isUploadCommentTooShort} method.
+     */
+    @Test
+    public void testIsUploadCommentTooShort() {
+        assertTrue(UploadDialog.UploadAction.isUploadCommentTooShort(""));
+        assertTrue(UploadDialog.UploadAction.isUploadCommentTooShort("test"));
+        assertTrue(UploadDialog.UploadAction.isUploadCommentTooShort("测试"));
+        assertFalse(UploadDialog.UploadAction.isUploadCommentTooShort("geometric corrections"));
+        assertFalse(UploadDialog.UploadAction.isUploadCommentTooShort("几何校正"));
+    }
 }