source: josm/trunk/resources/data/validator/geometry.mapcss@ 17790

Last change on this file since 17790 was 17680, checked in by GerdP, 5 years ago

fix #20674: Water area inside water area not detected for waterway=riverbank

  • add checks for waterway=riverbank
  • remove check for :areaStyle where obsolete or wrong
  • Property svn:eol-style set to native
File size: 15.4 KB
RevLine 
[7735]1/* {0} on a node, should be a way */
[11477]2node[area=no],
[6550]3node[oneway],
[7960]4node[bridge],
[7707]5node[sidewalk],
[15312]6node[footway][footway!=crossing], /* footway=crossing has own warning in highway.mapcss */
[7960]7node[man_made=embankment],
[7975]8node[man_made=groyne],
[8147]9node[man_made=cutline],
[9494]10node[power=line],
[8147]11node[cutline],
[7915]12node[aerialway=cable_car],
13node[aerialway=gondola],
14node[aerialway=chair_lift],
15node[aerialway=mixed_lift],
16node[aerialway=drag_lift],
17node[aerialway=t-bar],
18node[aerialway=j-bar],
19node[aerialway=platter],
20node[aerialway=magic_carpet],
21node[aerialway=rope_tow],
22node[aerialway=goods],
[7977]23node[aeroway=taxiway],
24node[aeroway=runway],
25node[railway=rail],
26node[railway=narrow_gauge],
27node[railway=monorail],
28node[railway=preserved],
29node[railway=light_rail],
30node[railway=subway],
31node[railway=tram],
32node[railway=disused],
33node[railway=abandoned],
[7737]34node[waterway=river],
35node[waterway=canal],
36node[waterway=stream],
37node[waterway=ditch],
[7975]38node[waterway=drain],
[7735]39node[natural=coastline],
40node[natural=ridge],
[8135]41node[natural=valley],
[7735]42node[natural=tree_row] {
[7942]43 throwWarning: tr("{0} on a node. Should be used on a way.", "{0.tag}");
[6550]44 assertMatch: "node oneway=-1";
45 assertNoMatch: "way oneway=-1";
46 assertMatch: "node bridge=yes";
[7963]47 assertMatch: "node bridge=viaduct";
[6611]48}
49
[13083]50/* {0} on a node, should be a way or relation */
51node[boundary=administrative] {
52 throwWarning: tr("{0} on a node. Should be used on a way or relation.", "{0.tag}");
53}
54
[14830]55/* {0} on a node, should be an area; #10679 #16528 #16792 #12502 #17402*/
[14059]56node[golf=green],
57node[golf=bunker],
58node[golf=fairway],
[11477]59node[area=yes],
[14577]60node[area:highway],
[7735]61node[landuse],
62node[natural=scree],
63node[natural=scrub],
64node[natural=fell],
65node[natural=heath],
66node[natural=wood],
67node[natural=grassland],
68node[natural=wetland],
69node[natural=water],
70node[natural=mud],
71node[natural=beach],
72node[natural=sand],
73node[natural=wood],
74node[natural=bare_rock],
[9022]75node[natural=glacier],
[14830]76node[leisure=park][natural!=tree], /* For nodes with both tags another warning is created in combinations.mapcss */
77node[leisure=nature_reserve],
[7735]78node[waterway=riverbank],
[7960]79node[man_made=bridge],
[7975]80node[man_made=breakwater],
[7977]81node[aeroway=apron],
[7967]82node[power=plant],
[14299]83node[power=switchgear],
[8139]84node[building:part],
[7735]85node[source:outline] {
86 throwWarning: tr("{0} on a node. Should be drawn as an area.", "{0.tag}");
[7468]87}
88
[17249]89/* {0} on a node, should be a relation; Error level; #10252, #10769, #14288 */
[11500]90node[type=multipolygon],
[14712]91node[interval],
[7744]92node[route],
93node[restriction] {
[11500]94 throwError: tr("{0} on a node. Should be used in a relation", "{0.tag}");
[7744]95}
96
[7942]97/* {0} on a way, should be a node */
[15454]98way[line_attachment],
[17263]99way[line_management],
[14593]100way[emergency=fire_hydrant],
[17106]101way[emergency=defibrillator],
[7960]102way[entrance],
[14454]103way[door],
[10429]104way[railway=subway_entrance],
[7960]105way[man_made=survey_point],
[11005]106way[aeroway=holding_position],
[9500]107way[power=transformer],
[17387]108way[transformer],
[7967]109way[power=pole],
[14123]110way[power=catenary_mast],
111way[power=terminal],
[9494]112way[power=tower]!:closed,
[7977]113way[amenity=vending_machine],
[7942]114way[natural=peak],
115way[natural=saddle],
116way[natural=volcano],
[12708]117way[natural=tree],
[12775]118way[highway=give_way],
119way[highway=milestone],
120way[highway=mini_roundabout],
121way[highway=stop],
122way[highway=street_lamp],
123way[highway=traffic_signals],
124way[highway=turning_loop],
125way[highway=turning_circle],
[12708]126way[highway=motorway_junction] {
[7942]127 throwWarning: tr("{0} on a way. Should be used on a node.", "{0.tag}");
128}
129
[17249]130/* {0} on a way, should be a relation; #15642, #10252, #14288 */
[13217]131way[restriction][restriction =~ /^(no_right_turn|no_left_turn|no_u_turn|no_straight_on|only_right_turn|only_left_turn|only_straight_on|no_entry|no_exit)$/],
[11500]132way[type=multipolygon],
[14712]133way[interval][route!=ferry],
[7744]134way[route=bus] {
[11500]135 throwError: tr("{0} on a way. Should be used in a relation", "{0.tag}");
[7744]136}
137
[17249]138/* {0} on a closed way, should be a unclosed way; #19981 */
139way:closed[power=line] {
140 throwWarning: tr("{0} on a closed way. Should be used on an unclosed way.", "{1.tag}");
141}
142
[17088]143/* #14395, #17025, #19506 */
[13006]144way[highway][area!=yes][!tunnel][!covered] > node {
145 set node_in_highway;
146}
[15016]147way[highway][area!=yes][!tunnel][!covered]:closed > node {
148 set node_in_closed_highway;
149}
150way[highway][area!=yes][!tunnel][!covered] >[index=1] node,
151way[highway][area!=yes][!tunnel][!covered] >[index=-1] node {
152 set first_last_highway_node;
153}
[17088]154way[building][building!=no] > node[!entrance].node_in_closed_highway {
[17105]155 set node_connects_highway_and_building; /* avoids duplicate warnings with following rule */
[13006]156 throwWarning: tr("node connects highway and building");
157}
[17088]158way[building][building!=no] > node[!entrance].node_in_highway!.first_last_highway_node!.node_connects_highway_and_building {
159 throwWarning: tr("node connects highway and building");
160}
[13006]161
162/* #15035, must not warn for node 3815077900*/
163node[man_made!=monitoring_station][at(0.0,0.0)] {
164 throwError: tr("Object at Position 0.00E 0.00N. There is nothing at this position except an already mapped weather buoy.");
165 fixDeleteObject: this;
166}
167
[17249]168/* #10125 */
[7279]169node[source:geometry] {
170 throwWarning: tr("{0} on a node", "{0.key}");
171 fixChangeKey: "source:geometry => source:position";
172}
173
[6611]174/* Building inside building (spatial test) */
[7164]175*[building][building!~/no|entrance/][any(tag("layer"),"0") = any(parent_tag("layer"),"0")]
[15105]176area[building][building!~/no|entrance/] {
[6611]177 throwWarning: tr("Building inside building");
[6613]178}
179
[16783]180/* Building overlapping building or building:part (spatial test) */
181area[building][building!~/no|entrance/] area[building:part][building:part!~/no|entrance/],
[15961]182area[building][building!~/no|entrance/] area[building][building!~/no|entrance/] {
183 throwWarning: tr("Overlapping buildings");
184}
185
[6613]186/* Overlapping areas (spatial test) */
[17629]187area[natural =~ /^(water|wetland|coastline)$/], area[waterway=riverbank], area[landuse=reservoir] {
[6613]188 set water_area;
189}
190
[17680]191/* area:closed.water_area ⧉ area:closed.water_area -- does not work for now -- see ticket#10215 */
192area:closed[natural =~ /^(water|wetland|coastline)$/] area:closed.water_area,
193area:closed[waterway=riverbank] area:closed.water_area,
194area:closed[landuse=reservoir] area:closed.water_area {
[6613]195 throwWarning: tr("Overlapping Water Areas");
196}
197
[16145]198/* Water area inside water area (spatial test) */
[17680]199area:closed[natural =~ /^(water|wetland|coastline)$/] area:closed.water_area,
200area:closed[waterway=riverbank] area:closed.water_area,
201area:closed[landuse=reservoir] area:closed.water_area,
202area:closed[natural =~ /^(water|wetland|coastline)$/] area:closed.water_area,
203area:closed[waterway=riverbank] area:closed.water_area,
204area:closed[landuse=reservoir] area:closed.water_area {
[16145]205 throwWarning: tr("Water area inside water area");
206}
207
[6630]208area:closed:areaStyle area:closed:areaStyle {
[6613]209 throwOther: tr("Overlapping Areas");
210}
[6614]211
[17249]212/* #9311 */
[15105]213node[amenity=parking]["capacity:disabled" !~ /^(yes|[0-9]+)$/] area[amenity=parking] {
[6614]214 throwWarning: tr("{0} inside {1}", "amenity=parking", "amenity=parking");
[11353]215 group: tr("{0} inside {1}", "amenity", "amenity");
[6680]216}
217
[17629]218/* #9556, #20570 */
219area:closed:areaStyle[tag("natural") = parent_tag("natural")] area:closed:areaStyle[natural][natural !~ /^(water|wetland|coastline)$/] {
[6680]220 throwWarning: tr("Overlapping Identical Natural Areas");
221}
222
[17680]223area:closed[tag("landuse") = parent_tag("landuse")] area:closed[landuse] {
[6680]224 throwWarning: tr("Overlapping Identical Landuses");
[6719]225}
226
[17249]227/* #9522 */
[15105]228node[tag("amenity") = parent_tag("amenity")] area[amenity][amenity != parking] {
[6719]229 throwWarning: tr("{0} inside {1}", concat("amenity=", tag("amenity")), concat("amenity=", tag("amenity")));
[10710]230 group: tr("{0} inside {1}", "amenity", "amenity");
[6719]231}
[15105]232node[tag("leisure") = parent_tag("leisure")] area[leisure] {
[6719]233 throwWarning: tr("{0} inside {1}", concat("leisure=", tag("leisure")), concat("leisure=", tag("leisure")));
[10710]234 group: tr("{0} inside {1}", "leisure", "leisure");
[6719]235}
[15105]236node[tag("tourism") = parent_tag("tourism")] area[tourism] {
[6719]237 throwWarning: tr("{0} inside {1}", concat("tourism=", tag("tourism")), concat("tourism=", tag("tourism")));
[10710]238 group: tr("{0} inside {1}", "tourism", "tourism");
[6719]239}
[15105]240node[tag("shop") = parent_tag("shop")] area[shop] {
[6719]241 throwWarning: tr("{0} inside {1}", concat("shop=", tag("shop")), concat("shop=", tag("shop")));
[10710]242 group: tr("{0} inside {1}", "shop", "shop");
[6759]243}
[15105]244node[tag("power") = parent_tag("power")] area[power] {
[6759]245 throwWarning: tr("{0} inside {1}", concat("power=", tag("power")), concat("power=", tag("power")));
[10710]246 group: tr("{0} inside {1}", "power", "power");
[7793]247}
248
[17249]249/* isolated nodes which should be part of a way; #10825, #15478 */
[8522]250node:unconnected:in-downloaded-area[entrance],
251node:unconnected:in-downloaded-area[traffic_calming],
252node:unconnected:in-downloaded-area[highway=passing_place],
253node:unconnected:in-downloaded-area[highway=mini_roundabout],
254node:unconnected:in-downloaded-area[highway=motorway_junction],
255node:unconnected:in-downloaded-area[highway=turning_loop],
256node:unconnected:in-downloaded-area[highway=turning_circle],
257node:unconnected:in-downloaded-area[highway=stop],
258node:unconnected:in-downloaded-area[highway=give_way],
259node:unconnected:in-downloaded-area[highway=traffic_signals],
260node:unconnected:in-downloaded-area[highway=crossing],
261node:unconnected:in-downloaded-area[crossing],
[13074]262node:unconnected:in-downloaded-area[highway=milestone],
263node:unconnected:in-downloaded-area[railway=milestone],
[8522]264node:unconnected:in-downloaded-area[railway=crossing],
265node:unconnected:in-downloaded-area[railway=level_crossing],
266node:unconnected:in-downloaded-area[railway=buffer_stop],
267node:unconnected:in-downloaded-area[public_transport=stop_position],
[11005]268node:unconnected:in-downloaded-area[aeroway=holding_position],
[8522]269node:unconnected:in-downloaded-area[noexit],
270node:unconnected:in-downloaded-area[waterway=dam],
271node:unconnected:in-downloaded-area[waterway=weir],
272node:unconnected:in-downloaded-area[waterway=waterfall],
273node:unconnected:in-downloaded-area[amenity=ferry_terminal],
[11133]274node:unconnected:in-downloaded-area[leisure=slipway],
[8522]275node:unconnected:in-downloaded-area[mountain_pass=yes],
276node:unconnected:in-downloaded-area[barrier=gate],
277node:unconnected:in-downloaded-area[barrier=lift_gate],
278node:unconnected:in-downloaded-area[barrier=swing_gate],
279node:unconnected:in-downloaded-area[barrier=toll_booth],
280node:unconnected:in-downloaded-area[barrier=turnstile],
281node:unconnected:in-downloaded-area[barrier=full-height_turnstile],
282node:unconnected:in-downloaded-area[barrier=motorcycle_barrier],
283node:unconnected:in-downloaded-area[barrier=rope],
284node:unconnected:in-downloaded-area[barrier=sally_port],
285node:unconnected:in-downloaded-area[barrier=spikes],
286node:unconnected:in-downloaded-area[barrier=stile],
287node:unconnected:in-downloaded-area[barrier=sump_buster],
288node:unconnected:in-downloaded-area[barrier=kerb],
289node:unconnected:in-downloaded-area[barrier=border_control],
290node:unconnected:in-downloaded-area[barrier=bump_gate],
291node:unconnected:in-downloaded-area[barrier=bus_trap],
292node:unconnected:in-downloaded-area[barrier=cattle_grid],
293node:unconnected:in-downloaded-area[barrier=chain],
294node:unconnected:in-downloaded-area[barrier=cycle_barrier],
295node:unconnected:in-downloaded-area[barrier=hampshire_gate],
296node:unconnected:in-downloaded-area[barrier=height_restrictor],
297node:unconnected:in-downloaded-area[barrier=debris] {
[11138]298 throwWarning: tr("{0}", "{2.tag}");
299 group: tr("isolated node which must be connected to a way");
[8089]300}
301
[11049]302/* #11127 */
[8089]303way[railway][bridge] > node,
304way[highway][bridge] > node {
305 set node_in_bridge;
306}
307way[waterway] > node.node_in_bridge {
308 throwWarning: tr("node connects waterway and bridge");
[9540]309}
310
[13006]311/* #11128, #14812, #15032 */
[10037]312way[highway] > node[tourism=information][information=guidepost] {
313 set guidepost;
314 throwOther: tr("{0} node connected to a highway", "{1.tag}");
315}
[15016]316way >[index=1] node,
317way >[index=-1] node {
318 set first_last_node;
319}
[14861]320way[highway] > node[amenity][!entrance][amenity!~/^(parking|parking_space|parking_entrance|motorcycle_parking|bicycle_parking|bus_station|car_wash|ferry_terminal|weighbridge|taxi|toilets)$/],
[10026]321way[highway] > node[building][!entrance],
[15641]322way[highway] > node[leisure][!entrance][leisure!=slipway][leisure!=fitness_station],
[10026]323way[highway] > node[office][!entrance],
324way[highway] > node[shop][!entrance],
[13006]325way[highway] > node[tourism][!entrance][tourism!=viewpoint]!.guidepost.first_last_node:connection,
326way[highway] > node[tourism][!entrance][tourism!=viewpoint]!.guidepost!.first_last_node {
[10028]327 throwWarning: tr("{0} node connected to a highway", "{0.key}");
[10026]328}
329
[15964]330/* #18817 */
331way[man_made=pipeline][location=underground] > node[marker],
332way[power=cable ][location=underground] > node[marker] {
333 throwWarning: tr("{0} node connected to an underground object", "{0.key}");
334}
335
[9540]336way[junction=roundabout]:righthandtraffic:clockwise,
337way[junction=roundabout]!:righthandtraffic:anticlockwise {
338 throwWarning: tr("suspicious roundabout direction");
[9843]339}
340
341/* #12496 */
[10328]342area:closed[place=islet][eval(areasize()) > 1500000] {
[9843]343 throwWarning: tr("{0} on a large area", "{1.tag}");
344 suggestAlternative: "place=island";
345 fixAdd: "place=island";
346}
347
[10328]348area:closed[place=island][eval(areasize()) < 500000] {
[9843]349 throwWarning: tr("{0} on a small area", "{1.tag}");
350 suggestAlternative: "place=islet";
351 fixAdd: "place=islet";
[9985]352}
353
[11049]354/* #12561 - building larger than Aalsmeer Flower Auction (518000) and Tesla factory (510000) */
355area:closed[building][building!=no][eval(areasize()) > 520000] {
356 throwError: tr("Too large building");
[9985]357}
[10028]358
[15413]359/* #12646, #12992, #16334 */
360way[waterway=~/^(stream|river|drain)$/]!:closed >[index=-1] node[natural!=sinkhole][natural!=cave_entrance]!:connection:in-downloaded-area {
[10232]361 throwWarning: tr("Waterway ends without a connection to another waterway or the direction of the waterway is wrong.");
[10389]362}
363
[11744]364/* #10717, #14535 */
365way:closed[natural=coastline] area[natural=water],
366way:closed[natural=coastline] area[waterway=riverbank] {
[10389]367 throwError: tr("Coastline inside {1}", "{0.tag}");
[11146]368}
369
370/* #10471 */
371way[waterway] > node[ford?] { set ford_on_waterway; }
372way[highway] > node[ford?] { set ford_on_highway; }
373node[ford?]:in-downloaded-area!.ford_on_waterway, node[ford?]:in-downloaded-area!.ford_on_highway {
374 throwWarning: tr("{0} should be on the node where {1} and {2} intersect", "ford", "highway", "waterway");
[11232]375}
[11736]376
[11232]377/* #13877 */
378area:closed[waterway = canal][area!=no],
379area:closed[waterway = drain][area!=no],
380area:closed[waterway = ditch][area!=no],
381area:closed[waterway = stream][area!=no],
382area:closed[waterway = river][area!=no] {
383 throwWarning: tr("{0} is the tag for the linear waterway. To tag the water area use {1} + {2} instead.", "{1.tag}", "natural=water", "water=*");
[11736]384}
385
[12572]386/* #15097 */
387way[highway][area!=yes] > node,
388way[man_made=pier] > node {
389 set node_in_highway_pier;
390}
391way[route=ferry][tunnel=yes] > node,
392way[route=ferry][bridge=yes] > node {
393 set node_in_ferry_bridge_tunnel;
394}
395way[route=ferry]!:closed >[index= 1] node!.node_in_highway_pier!.node_in_ferry_bridge_tunnel:in-downloaded-area,
396way[route=ferry]!:closed >[index=-1] node!.node_in_highway_pier!.node_in_ferry_bridge_tunnel:in-downloaded-area {
397 throwWarning: tr("Ferry route is not connected to the road network or branches.");
398}
399way[amenity=ferry_terminal] > node,
400way[man_made=pier] > node {
401 set node_in_terminal_pier;
402}
403way[route=ferry]!:closed >[index= 1] node[amenity!=ferry_terminal][man_made!=pier]!.node_in_terminal_pier!.node_in_ferry_bridge_tunnel:in-downloaded-area,
404way[route=ferry]!:closed >[index=-1] node[amenity!=ferry_terminal][man_made!=pier]!.node_in_terminal_pier!.node_in_ferry_bridge_tunnel:in-downloaded-area {
405 throwWarning: tr("Ferry route is not connected to a ferry terminal or branches.");
[12708]406}
Note: See TracBrowser for help on using the repository browser.