source: josm/trunk/resources/data/validator/geometry.mapcss@ 17209

Last change on this file since 17209 was 17111, checked in by GerdP, 5 years ago

fix #16247: Validator issues on power related items

  • replace mapcss tests by java code, use new code 2502 for warning Node connects a power line or cable with an object which is not related to the power infrastructure.
  • Property svn:eol-style set to native
File size: 14.9 KB
RevLine 
[7735]1/* {0} on a node, should be a way */
[11477]2node[area=no],
[6550]3node[oneway],
[7960]4node[bridge],
[7707]5node[sidewalk],
[15312]6node[footway][footway!=crossing], /* footway=crossing has own warning in highway.mapcss */
[7960]7node[man_made=embankment],
[7975]8node[man_made=groyne],
[8147]9node[man_made=cutline],
[9494]10node[power=line],
[8147]11node[cutline],
[7915]12node[aerialway=cable_car],
13node[aerialway=gondola],
14node[aerialway=chair_lift],
15node[aerialway=mixed_lift],
16node[aerialway=drag_lift],
17node[aerialway=t-bar],
18node[aerialway=j-bar],
19node[aerialway=platter],
20node[aerialway=magic_carpet],
21node[aerialway=rope_tow],
22node[aerialway=goods],
[7977]23node[aeroway=taxiway],
24node[aeroway=runway],
25node[railway=rail],
26node[railway=narrow_gauge],
27node[railway=monorail],
28node[railway=preserved],
29node[railway=light_rail],
30node[railway=subway],
31node[railway=tram],
32node[railway=disused],
33node[railway=abandoned],
[7737]34node[waterway=river],
35node[waterway=canal],
36node[waterway=stream],
37node[waterway=ditch],
[7975]38node[waterway=drain],
[7735]39node[natural=coastline],
40node[natural=ridge],
[8135]41node[natural=valley],
[7735]42node[natural=tree_row] {
[7942]43 throwWarning: tr("{0} on a node. Should be used on a way.", "{0.tag}");
[6550]44 assertMatch: "node oneway=-1";
45 assertNoMatch: "way oneway=-1";
46 assertMatch: "node bridge=yes";
[7963]47 assertMatch: "node bridge=viaduct";
[6611]48}
49
[13083]50/* {0} on a node, should be a way or relation */
51node[boundary=administrative] {
52 throwWarning: tr("{0} on a node. Should be used on a way or relation.", "{0.tag}");
53}
54
[14830]55/* {0} on a node, should be an area; #10679 #16528 #16792 #12502 #17402*/
[14059]56node[golf=green],
57node[golf=bunker],
58node[golf=fairway],
[11477]59node[area=yes],
[14577]60node[area:highway],
[7735]61node[landuse],
62node[natural=scree],
63node[natural=scrub],
64node[natural=fell],
65node[natural=heath],
66node[natural=wood],
67node[natural=grassland],
68node[natural=wetland],
69node[natural=water],
70node[natural=mud],
71node[natural=beach],
72node[natural=sand],
73node[natural=wood],
74node[natural=bare_rock],
[9022]75node[natural=glacier],
[14830]76node[leisure=park][natural!=tree], /* For nodes with both tags another warning is created in combinations.mapcss */
77node[leisure=nature_reserve],
[7735]78node[waterway=riverbank],
[7960]79node[man_made=bridge],
[7975]80node[man_made=breakwater],
[7977]81node[aeroway=apron],
[7967]82node[power=plant],
[14299]83node[power=switchgear],
[8139]84node[building:part],
[7735]85node[source:outline] {
86 throwWarning: tr("{0} on a node. Should be drawn as an area.", "{0.tag}");
[7468]87}
88
[11500]89/* {0} on a node, should be a relation; Error level; see #10252, #10769, #14288 */
90node[type=multipolygon],
[14712]91node[interval],
[7744]92node[route],
93node[restriction] {
[11500]94 throwError: tr("{0} on a node. Should be used in a relation", "{0.tag}");
[7744]95}
96
[7942]97/* {0} on a way, should be a node */
[15454]98way[line_attachment],
[14593]99way[emergency=fire_hydrant],
[17106]100way[emergency=defibrillator],
[7960]101way[entrance],
[14454]102way[door],
[10429]103way[railway=subway_entrance],
[7960]104way[man_made=survey_point],
[11005]105way[aeroway=holding_position],
[9500]106way[power=transformer],
[7967]107way[power=pole],
[14123]108way[power=catenary_mast],
109way[power=terminal],
[9494]110way[power=tower]!:closed,
[7977]111way[amenity=vending_machine],
[7942]112way[natural=peak],
113way[natural=saddle],
114way[natural=volcano],
[12708]115way[natural=tree],
[12775]116way[highway=give_way],
117way[highway=milestone],
118way[highway=mini_roundabout],
119way[highway=stop],
120way[highway=street_lamp],
121way[highway=traffic_signals],
122way[highway=turning_loop],
123way[highway=turning_circle],
[12708]124way[highway=motorway_junction] {
[7942]125 throwWarning: tr("{0} on a way. Should be used on a node.", "{0.tag}");
126}
127
[13217]128/* {0} on a way, should be a relation; see #15642, #10252, #14288 */
129way[restriction][restriction =~ /^(no_right_turn|no_left_turn|no_u_turn|no_straight_on|only_right_turn|only_left_turn|only_straight_on|no_entry|no_exit)$/],
[11500]130way[type=multipolygon],
[14712]131way[interval][route!=ferry],
[7744]132way[route=bus] {
[11500]133 throwError: tr("{0} on a way. Should be used in a relation", "{0.tag}");
[7744]134}
135
[17088]136/* #14395, #17025, #19506 */
[13006]137way[highway][area!=yes][!tunnel][!covered] > node {
138 set node_in_highway;
139}
[15016]140way[highway][area!=yes][!tunnel][!covered]:closed > node {
141 set node_in_closed_highway;
142}
143way[highway][area!=yes][!tunnel][!covered] >[index=1] node,
144way[highway][area!=yes][!tunnel][!covered] >[index=-1] node {
145 set first_last_highway_node;
146}
[17088]147way[building][building!=no] > node[!entrance].node_in_closed_highway {
[17105]148 set node_connects_highway_and_building; /* avoids duplicate warnings with following rule */
[13006]149 throwWarning: tr("node connects highway and building");
150}
[17088]151way[building][building!=no] > node[!entrance].node_in_highway!.first_last_highway_node!.node_connects_highway_and_building {
152 throwWarning: tr("node connects highway and building");
153}
[13006]154
155/* #15035, must not warn for node 3815077900*/
156node[man_made!=monitoring_station][at(0.0,0.0)] {
157 throwError: tr("Object at Position 0.00E 0.00N. There is nothing at this position except an already mapped weather buoy.");
158 fixDeleteObject: this;
159}
160
[7279]161/* see ticket:#10125 */
162node[source:geometry] {
163 throwWarning: tr("{0} on a node", "{0.key}");
164 fixChangeKey: "source:geometry => source:position";
165}
166
[6611]167/* Building inside building (spatial test) */
[7164]168*[building][building!~/no|entrance/][any(tag("layer"),"0") = any(parent_tag("layer"),"0")]
[15105]169area[building][building!~/no|entrance/] {
[6611]170 throwWarning: tr("Building inside building");
[6613]171}
172
[16783]173/* Building overlapping building or building:part (spatial test) */
174area[building][building!~/no|entrance/] area[building:part][building:part!~/no|entrance/],
[15961]175area[building][building!~/no|entrance/] area[building][building!~/no|entrance/] {
176 throwWarning: tr("Overlapping buildings");
177}
178
[6613]179/* Overlapping areas (spatial test) */
180area[natural =~ /^(water|wetland|coastline)$/], area[landuse=reservoir] {
181 set water_area;
182}
183
[7280]184/* area:closed:areaStyle.water_area ⧉ area:closed:areaStyle.water_area -- does not work for now -- see ticket#10215 */
185area:closed:areaStyle[natural =~ /^(water|wetland|coastline)$/] area:closed:areaStyle.water_area,
186area:closed:areaStyle[landuse=reservoir] area:closed:areaStyle.water_area {
[6613]187 throwWarning: tr("Overlapping Water Areas");
188}
189
[16145]190/* Water area inside water area (spatial test) */
191area:closed:areaStyle[natural =~ /^(water|wetland|coastline)$/] area:closed:areaStyle.water_area,
192area:closed:areaStyle[landuse=reservoir] area:closed:areaStyle.water_area {
193 throwWarning: tr("Water area inside water area");
194}
195
[6630]196area:closed:areaStyle area:closed:areaStyle {
[6613]197 throwOther: tr("Overlapping Areas");
198}
[6614]199
200/* see ticket #9311 */
[15105]201node[amenity=parking]["capacity:disabled" !~ /^(yes|[0-9]+)$/] area[amenity=parking] {
[6614]202 throwWarning: tr("{0} inside {1}", "amenity=parking", "amenity=parking");
[11353]203 group: tr("{0} inside {1}", "amenity", "amenity");
[6680]204}
205
206/* see ticket #9556 */
207area:closed:areaStyle[tag("natural") = parent_tag("natural")] area:closed:areaStyle[natural] {
208 throwWarning: tr("Overlapping Identical Natural Areas");
209}
210
[15961]211area:closed:areaStyle[tag("landuse") = parent_tag("landuse")] area:closed:areaStyle[landuse] {
[6680]212 throwWarning: tr("Overlapping Identical Landuses");
[6719]213}
214
215/* see ticket:#9522 */
[15105]216node[tag("amenity") = parent_tag("amenity")] area[amenity][amenity != parking] {
[6719]217 throwWarning: tr("{0} inside {1}", concat("amenity=", tag("amenity")), concat("amenity=", tag("amenity")));
[10710]218 group: tr("{0} inside {1}", "amenity", "amenity");
[6719]219}
[15105]220node[tag("leisure") = parent_tag("leisure")] area[leisure] {
[6719]221 throwWarning: tr("{0} inside {1}", concat("leisure=", tag("leisure")), concat("leisure=", tag("leisure")));
[10710]222 group: tr("{0} inside {1}", "leisure", "leisure");
[6719]223}
[15105]224node[tag("tourism") = parent_tag("tourism")] area[tourism] {
[6719]225 throwWarning: tr("{0} inside {1}", concat("tourism=", tag("tourism")), concat("tourism=", tag("tourism")));
[10710]226 group: tr("{0} inside {1}", "tourism", "tourism");
[6719]227}
[15105]228node[tag("shop") = parent_tag("shop")] area[shop] {
[6719]229 throwWarning: tr("{0} inside {1}", concat("shop=", tag("shop")), concat("shop=", tag("shop")));
[10710]230 group: tr("{0} inside {1}", "shop", "shop");
[6759]231}
[15105]232node[tag("power") = parent_tag("power")] area[power] {
[6759]233 throwWarning: tr("{0} inside {1}", concat("power=", tag("power")), concat("power=", tag("power")));
[10710]234 group: tr("{0} inside {1}", "power", "power");
[7793]235}
236
[13074]237/* isolated nodes which should be part of a way, see #10825, #15478 */
[8522]238node:unconnected:in-downloaded-area[entrance],
239node:unconnected:in-downloaded-area[traffic_calming],
240node:unconnected:in-downloaded-area[highway=passing_place],
241node:unconnected:in-downloaded-area[highway=mini_roundabout],
242node:unconnected:in-downloaded-area[highway=motorway_junction],
243node:unconnected:in-downloaded-area[highway=turning_loop],
244node:unconnected:in-downloaded-area[highway=turning_circle],
245node:unconnected:in-downloaded-area[highway=stop],
246node:unconnected:in-downloaded-area[highway=give_way],
247node:unconnected:in-downloaded-area[highway=traffic_signals],
248node:unconnected:in-downloaded-area[highway=crossing],
249node:unconnected:in-downloaded-area[crossing],
[13074]250node:unconnected:in-downloaded-area[highway=milestone],
251node:unconnected:in-downloaded-area[railway=milestone],
[8522]252node:unconnected:in-downloaded-area[railway=crossing],
253node:unconnected:in-downloaded-area[railway=level_crossing],
254node:unconnected:in-downloaded-area[railway=buffer_stop],
255node:unconnected:in-downloaded-area[public_transport=stop_position],
[11005]256node:unconnected:in-downloaded-area[aeroway=holding_position],
[8522]257node:unconnected:in-downloaded-area[noexit],
258node:unconnected:in-downloaded-area[waterway=dam],
259node:unconnected:in-downloaded-area[waterway=weir],
260node:unconnected:in-downloaded-area[waterway=waterfall],
261node:unconnected:in-downloaded-area[amenity=ferry_terminal],
[11133]262node:unconnected:in-downloaded-area[leisure=slipway],
[8522]263node:unconnected:in-downloaded-area[mountain_pass=yes],
264node:unconnected:in-downloaded-area[barrier=gate],
265node:unconnected:in-downloaded-area[barrier=lift_gate],
266node:unconnected:in-downloaded-area[barrier=swing_gate],
267node:unconnected:in-downloaded-area[barrier=toll_booth],
268node:unconnected:in-downloaded-area[barrier=turnstile],
269node:unconnected:in-downloaded-area[barrier=full-height_turnstile],
270node:unconnected:in-downloaded-area[barrier=motorcycle_barrier],
271node:unconnected:in-downloaded-area[barrier=rope],
272node:unconnected:in-downloaded-area[barrier=sally_port],
273node:unconnected:in-downloaded-area[barrier=spikes],
274node:unconnected:in-downloaded-area[barrier=stile],
275node:unconnected:in-downloaded-area[barrier=sump_buster],
276node:unconnected:in-downloaded-area[barrier=kerb],
277node:unconnected:in-downloaded-area[barrier=border_control],
278node:unconnected:in-downloaded-area[barrier=bump_gate],
279node:unconnected:in-downloaded-area[barrier=bus_trap],
280node:unconnected:in-downloaded-area[barrier=cattle_grid],
281node:unconnected:in-downloaded-area[barrier=chain],
282node:unconnected:in-downloaded-area[barrier=cycle_barrier],
283node:unconnected:in-downloaded-area[barrier=hampshire_gate],
284node:unconnected:in-downloaded-area[barrier=height_restrictor],
285node:unconnected:in-downloaded-area[barrier=debris] {
[11138]286 throwWarning: tr("{0}", "{2.tag}");
287 group: tr("isolated node which must be connected to a way");
[8089]288}
289
[11049]290/* #11127 */
[8089]291way[railway][bridge] > node,
292way[highway][bridge] > node {
293 set node_in_bridge;
294}
295way[waterway] > node.node_in_bridge {
296 throwWarning: tr("node connects waterway and bridge");
[9540]297}
298
[13006]299/* #11128, #14812, #15032 */
[10037]300way[highway] > node[tourism=information][information=guidepost] {
301 set guidepost;
302 throwOther: tr("{0} node connected to a highway", "{1.tag}");
303}
[15016]304way >[index=1] node,
305way >[index=-1] node {
306 set first_last_node;
307}
[14861]308way[highway] > node[amenity][!entrance][amenity!~/^(parking|parking_space|parking_entrance|motorcycle_parking|bicycle_parking|bus_station|car_wash|ferry_terminal|weighbridge|taxi|toilets)$/],
[10026]309way[highway] > node[building][!entrance],
[15641]310way[highway] > node[leisure][!entrance][leisure!=slipway][leisure!=fitness_station],
[10026]311way[highway] > node[office][!entrance],
312way[highway] > node[shop][!entrance],
[13006]313way[highway] > node[tourism][!entrance][tourism!=viewpoint]!.guidepost.first_last_node:connection,
314way[highway] > node[tourism][!entrance][tourism!=viewpoint]!.guidepost!.first_last_node {
[10028]315 throwWarning: tr("{0} node connected to a highway", "{0.key}");
[10026]316}
317
[15964]318/* #18817 */
319way[man_made=pipeline][location=underground] > node[marker],
320way[power=cable ][location=underground] > node[marker] {
321 throwWarning: tr("{0} node connected to an underground object", "{0.key}");
322}
323
[9540]324way[junction=roundabout]:righthandtraffic:clockwise,
325way[junction=roundabout]!:righthandtraffic:anticlockwise {
326 throwWarning: tr("suspicious roundabout direction");
[9843]327}
328
329/* #12496 */
[10328]330area:closed[place=islet][eval(areasize()) > 1500000] {
[9843]331 throwWarning: tr("{0} on a large area", "{1.tag}");
332 suggestAlternative: "place=island";
333 fixAdd: "place=island";
334}
335
[10328]336area:closed[place=island][eval(areasize()) < 500000] {
[9843]337 throwWarning: tr("{0} on a small area", "{1.tag}");
338 suggestAlternative: "place=islet";
339 fixAdd: "place=islet";
[9985]340}
341
[11049]342/* #12561 - building larger than Aalsmeer Flower Auction (518000) and Tesla factory (510000) */
343area:closed[building][building!=no][eval(areasize()) > 520000] {
344 throwError: tr("Too large building");
[9985]345}
[10028]346
[15413]347/* #12646, #12992, #16334 */
348way[waterway=~/^(stream|river|drain)$/]!:closed >[index=-1] node[natural!=sinkhole][natural!=cave_entrance]!:connection:in-downloaded-area {
[10232]349 throwWarning: tr("Waterway ends without a connection to another waterway or the direction of the waterway is wrong.");
[10389]350}
351
[11744]352/* #10717, #14535 */
353way:closed[natural=coastline] area[natural=water],
354way:closed[natural=coastline] area[waterway=riverbank] {
[10389]355 throwError: tr("Coastline inside {1}", "{0.tag}");
[11146]356}
357
358/* #10471 */
359way[waterway] > node[ford?] { set ford_on_waterway; }
360way[highway] > node[ford?] { set ford_on_highway; }
361node[ford?]:in-downloaded-area!.ford_on_waterway, node[ford?]:in-downloaded-area!.ford_on_highway {
362 throwWarning: tr("{0} should be on the node where {1} and {2} intersect", "ford", "highway", "waterway");
[11232]363}
[11736]364
[11232]365/* #13877 */
366area:closed[waterway = canal][area!=no],
367area:closed[waterway = drain][area!=no],
368area:closed[waterway = ditch][area!=no],
369area:closed[waterway = stream][area!=no],
370area:closed[waterway = river][area!=no] {
371 throwWarning: tr("{0} is the tag for the linear waterway. To tag the water area use {1} + {2} instead.", "{1.tag}", "natural=water", "water=*");
[11736]372}
373
[12572]374/* #15097 */
375way[highway][area!=yes] > node,
376way[man_made=pier] > node {
377 set node_in_highway_pier;
378}
379way[route=ferry][tunnel=yes] > node,
380way[route=ferry][bridge=yes] > node {
381 set node_in_ferry_bridge_tunnel;
382}
383way[route=ferry]!:closed >[index= 1] node!.node_in_highway_pier!.node_in_ferry_bridge_tunnel:in-downloaded-area,
384way[route=ferry]!:closed >[index=-1] node!.node_in_highway_pier!.node_in_ferry_bridge_tunnel:in-downloaded-area {
385 throwWarning: tr("Ferry route is not connected to the road network or branches.");
386}
387way[amenity=ferry_terminal] > node,
388way[man_made=pier] > node {
389 set node_in_terminal_pier;
390}
391way[route=ferry]!:closed >[index= 1] node[amenity!=ferry_terminal][man_made!=pier]!.node_in_terminal_pier!.node_in_ferry_bridge_tunnel:in-downloaded-area,
392way[route=ferry]!:closed >[index=-1] node[amenity!=ferry_terminal][man_made!=pier]!.node_in_terminal_pier!.node_in_ferry_bridge_tunnel:in-downloaded-area {
393 throwWarning: tr("Ferry route is not connected to a ferry terminal or branches.");
[12708]394}
Note: See TracBrowser for help on using the repository browser.