source: josm/trunk/data/validator/unnecessary.mapcss @ 14954

Last change on this file since 14954 was 14954, checked in by Don-vip, 2 years ago

fix #17547 - make test stricter (patch by mkoniecz)

  • Property svn:eol-style set to native
File size: 6.2 KB
Line 
1*[access][highway=proposed],
2*[motor_vehicle?][!vehicle][!access][bicycle_road!=yes][highway =~ /^(motorway|motorway_link|trunk|trunk_link|primary|primary_link|secondary|secondary_link|tertiary|tertiary_link|unclassified|residential|service|living_street)$/],
3*[bridge=no],
4*[building=no],
5*[elevation="0"],
6*[layer="0"] {
7  /* see #9365 - Useless tag layer=0 */
8  throwWarning: tr("{0} is unnecessary", "{0.tag}");
9  group: tr("unnecessary tag");
10  fixRemove: "{0.key}";
11  assertMatch: "way layer=0";
12  assertMatch: "way bridge=no";
13  assertMatch: "way highway=proposed access=no";
14  assertMatch: "way highway=motorway motor_vehicle=yes";
15  assertNoMatch: "way highway=motorway access=no motor_vehicle=yes";
16}
17
18area:closed[amenity ][area?][!highway],
19area:closed[building][area?],
20area:closed[landuse ][area?][!highway],
21area:closed[leisure ][area?][!highway][leisure!=track][leisure!=slipway],
22area:closed[natural ][area?],
23area:closed[shop    ][area?] {
24  throwWarning: tr("{0} is unnecessary for {1}", "{2.key}", "{1.key}");
25  group: tr("unnecessary tag");
26  fixRemove: "{2.key}";
27}
28
29/* #14256, #15664 */
30area:closed[highway=rest_area][area?],
31area:closed[highway=services][area?],
32area:closed[aeroway=aerodrome][area?],
33area:closed[aeroway=helipad][area?] {
34  throwWarning: tr("{0} is unnecessary for {1}", "{2.key}", "{1.tag}");
35  group: tr("unnecessary tag");
36  fixRemove: "{2.key}";
37}
38
39/* #9257, #17482 */
40way[foot =~ /^(yes|designated)$/][highway =~ /^(footway|pedestrian)$/][!access],
41way[bicycle =~ /^(yes|designated)$/][highway=cycleway][!vehicle][!access][foot!=designated],
42*[building:ruian:type=2][building=farm_auxiliary],
43*[building:ruian:type=7][building=house],
44*[building:ruian:type=11][building=hotel],
45*[building:ruian:type=12][building=warehouse],
46*[building:ruian:type=13][building=barn],
47*[building:ruian:type=18][building=garage],
48*[building:ruian:type=21][building=greenhouse],
49*[gnis:Class="Populated Place"][place=city],
50*[gnis:Class="Populated Place"][place=town],
51*[gnis:Class="Populated Place"][place=village],
52*[gnis:Class="Populated Place"][place=hamlet],
53*[gnis:Class=Summit][natural=peak] {
54  throwWarning: tr("{0} is unnecessary for {1}", "{0.tag}", "{1.tag}");
55  group: tr("unnecessary tag");
56  fixRemove: "{0.key}";
57  assertMatch: "way highway=pedestrian foot=designated";
58  assertNoMatch: "way highway=pedestrian access=no foot=designated";
59  assertNoMatch: "node gnis:Class="Populated Place" place=locality";
60}
61
62*[emergency=permissive] {
63  /* see #9458 - emergency=permissive makes no sense */
64  throwWarning: tr("{0} makes no sense", "{0.tag");
65  fixAdd: "emergency=yes";
66  assertMatch: "way emergency=permissive";
67  assertNoMatch: "way emergency=designated";
68}
69
70/* see ticket #7639 -- Warn when a node has the same tags as its parent way. */
71way >:sameTags node:tagged {
72  throwWarning: tr("Nodes duplicating parent way tags");
73}
74
75/* #15477 */
76*[payment:cash][payment:coins][payment:notes] {
77  throwWarning: tr("{0} together with {1} and {2}. Remove {0}.", "{0.key}", "{1.key}", "{2.key}");
78  group: tr("unnecessary tag");
79  fixRemove: "payment:cash";
80}
81
82/* see #10346, #15667 */
83way[waterway][oneway?] {
84  throwWarning: tr("{0} is unnecessary for {1}", "{1.key}", "{0.key}");
85  group: tr("unnecessary tag");
86  fixRemove: "{1.key}";
87}
88way[waterway][oneway=-1] {
89  throwWarning: tr("{0} is unnecessary for {1}. The flow direction is defined by the way direction.", "{1.key}", "{0.key}");
90  group: tr("unnecessary tag");
91}
92
93/* #15774 */
94node[emergency=fire_hydrant][fire_hydrant:count=1] {
95  throwWarning: tr("{0} is unnecessary for {1}", "{1.tag}", "{0.tag}");
96  group: tr("unnecessary tag");
97  fixRemove: "{1.key}";
98}
99
100/* #17100, #17471 */
101*[name][name=~/^(?i)(parking|parkplatz)$/][amenity=parking],
102*[name][name=~/^(?i)(playground|spielplatz)$/][leisure=playground],
103*[name][name=~/^(?i)(shop)$/][shop][shop!=no],
104*[name][name=~/^(?i)(building)$/][building][building!=no],
105*[name][name=~/^(?i)(house|rumah)$/][building=house],
106*[name][name=~/^(?i)(kiosk)$/][shop=kiosk],
107*[name][name=~/^(?i)(jalan)$/][highway],
108*[name][name=~/^(?i)(silo)$/][man_made=silo],
109*[name][name=~/^(?i)(silo)$/][building=silo],
110*[name][name=~/^(?i)(cemetery|cmentarz)$/][amenity=graveyard],
111*[name][name=~/^(?i)(cemetery|cmentarz)$/][amenity=cemetery],
112*[name="АГЗС"][amenity=fuel],
113*[name="АЗС"][amenity=fuel] {
114  throwWarning: tr("{0}", "{0.tag}");
115  group: tr("descriptive name");
116  fixRemove: "name";
117  assertMatch: "node name=parking amenity=parking";
118  assertMatch: "node name=Parking amenity=parking";
119  assertNoMatch: "node name=Parking_with_suffix amenity=parking";
120  assertNoMatch: "node name=Megaparking amenity=parking";
121  assertMatch: "relation name=parking amenity=parking type=multipolygon";
122  assertMatch: "relation name=Parking amenity=parking type=multipolygon";
123  assertNoMatch: "way name=parking";
124  assertMatch: "relation name=PLAYGROUND leisure=playground type=multipolygon";
125  assertMatch: "node name=PLaYGrOUNd leisure=playground";
126  assertMatch: "node name=shop shop=whatever";
127  assertNoMatch: "node name=shop shop=no";
128  assertNoMatch: "way name=shop leisure=playground";
129  assertMatch: "way name=building building=yes";
130  assertMatch: "way name=building building=house";
131  assertMatch: "way name=Rumah building=house";
132  assertNoMatch: "way name=Rumah building=yes";
133  assertMatch: "way name=house building=house";
134  assertNoMatch: "way name=house building=yes";
135  assertMatch: "way name=kiosk building=yes shop=kiosk";
136  assertNoMatch: "way name=kiosk building=yes";
137  assertMatch: "way name=silo man_made=silo";
138  assertMatch: "way name=Silo man_made=silo building=silo";
139  assertMatch: "way name=Silo building=silo";
140  assertMatch: "way name=cemetery amenity=graveyard";
141  assertMatch: "way name=Cmentarz amenity=graveyard";
142  assertNoMatch: "way name=kiosk amenity=graveyard";
143} 
144*[name][name=~/^(?i)(house|rumah)$/][building][building!=house][building!=no] {
145  throwWarning: tr("{0}", "{0.tag}");
146  group: tr("descriptive name");
147  /* without fixRemove to avoid possible information loss */
148  assertNoMatch: "way name=building building=yes";
149  assertNoMatch: "way name=building building=house";
150  assertNoMatch: "way name=Rumah building=house";
151  assertMatch: "way name=Rumah building=yes";
152  assertNoMatch: "way name=house building=house";
153  assertMatch: "way name=house building=yes";
154}
Note: See TracBrowser for help on using the repository browser.