| 1 | /* Rules partially derived from Taginfo statistics - see ticket #5017
|
|---|
| 2 | * Taginfo query: select keypairs.key1, keypairs.key2, keypairs.count_all, keys.count_all, cast(keypairs.count_all as real)/keys.count_all as from_fraction_all from keys, keypairs where key1='waterway' and keys.key=keypairs.key2 and (key1<>'highway' or keypairs.count_all>12000) and (key1<>'railway' or keypairs.count_all>3000) and (key1<>'waterway' or keypairs.count_all>800) and key2 not like '%:%' and from_fraction_all>0.97 and 1 union select keypairs.key2, keypairs.key1, keypairs.count_all, keys.count_all, cast(keypairs.count_all as real)/keys.count_all as from_fraction_all from keys, keypairs where key2='waterway' and keys.key=keypairs.key1 and (key2<>'highway' or keypairs.count_all>12000) and (key2<>'railway' or keypairs.count_all>3000) and (key2<>'waterway' or keypairs.count_all>800) and key1 not like '%:%' and from_fraction_all>0.97 and 1 order by keypairs.count_all desc limit 1000;
|
|---|
| 3 | */
|
|---|
| 4 |
|
|---|
| 5 | /* {0.key} without {1.key} (warning level) */
|
|---|
| 6 | way[junction ][!highway][junction!=yes],
|
|---|
| 7 | way[lanes ][!highway],
|
|---|
| 8 | way[living_street ][!highway],
|
|---|
| 9 | way[maintenance ][!highway],
|
|---|
| 10 | way[median ][!highway],
|
|---|
| 11 | way[motorroad ][!highway],
|
|---|
| 12 | node[ntd_id ][!highway],
|
|---|
| 13 | way[sac_scale ][!highway],
|
|---|
| 14 | way[sidewalk ][!highway],
|
|---|
| 15 | way[step_count ][!highway],
|
|---|
| 16 | way[tracktype ][!highway],
|
|---|
| 17 | way[trail_visibility ][!highway],
|
|---|
| 18 | way[trolley_wire ][!highway],
|
|---|
| 19 | way[zip_left ][!highway],
|
|---|
| 20 | way[zip_right ][!highway],
|
|---|
| 21 | way[detail ][!railway][route!=railway],
|
|---|
| 22 | way[eddy_current_brake ][!railway][route!=railway],
|
|---|
| 23 | way[electrified ][!railway][route!=railway],
|
|---|
| 24 | way[etcs ][!railway][route!=railway],
|
|---|
| 25 | way[gauge ][!railway][route!=railway],
|
|---|
| 26 | way[grade_of_track ][!railway][route!=railway],
|
|---|
| 27 | way[kursbuchstrecke ][!railway][route!=railway],
|
|---|
| 28 | way[lzb ][!railway][route!=railway],
|
|---|
| 29 | way[old_railway_operator ][!railway][route!=railway],
|
|---|
| 30 | way[operating_procedure ][!railway][route!=railway],
|
|---|
| 31 | way[pzb ][!railway][route!=railway],
|
|---|
| 32 | way[structure_gauge ][!railway][route!=railway],
|
|---|
| 33 | way[tilting_technology ][!railway][route!=railway],
|
|---|
| 34 | way[track_class ][!railway][route!=railway],
|
|---|
| 35 | way[tracks ][!railway][route!=railway],
|
|---|
| 36 | way[traffic_mode ][!railway][route!=railway],
|
|---|
| 37 | way[usage ][!railway][route!=railway][man_made!=pipeline],
|
|---|
| 38 | way[workrules ][!railway][route!=railway],
|
|---|
| 39 | way[stream ][!waterway],
|
|---|
| 40 | way[length_unit ][!waterway],
|
|---|
| 41 | way[canal ][!waterway],
|
|---|
| 42 | way[have_riverbank ][!waterway],
|
|---|
| 43 | *[border_type ][!boundary],
|
|---|
| 44 | way[bridge:structure ][!bridge],
|
|---|
| 45 | *[piste:difficulty ][!piste:type],
|
|---|
| 46 | *[source:date ][!source],
|
|---|
| 47 | *[source:name ][!name],
|
|---|
| 48 | *[source:maxspeed:forward ][!maxspeed:forward],
|
|---|
| 49 | *[source:maxspeed:backward ][!maxspeed:backward],
|
|---|
| 50 | *[source:maxspeed:forward ][!source:maxspeed:backward],
|
|---|
| 51 | *[source:maxspeed:backward ][!source:maxspeed:forward],
|
|---|
| 52 | *[source:building ][!building],
|
|---|
| 53 | *[source:ref ][!ref],
|
|---|
| 54 | *[source:population ][!population],
|
|---|
| 55 | *[source:postal_code ][!postal_code],
|
|---|
| 56 | *[source:ele ][!ele],
|
|---|
| 57 | *[source:ref:INSEE ][!ref:INSEE],
|
|---|
| 58 | *[source:lit ][!lit],
|
|---|
| 59 | *[source:hgv ][!hgv],
|
|---|
| 60 | *[source:highway ][!highway],
|
|---|
| 61 | *[source:maxaxleload ][!maxaxleload],
|
|---|
| 62 | *[source:surface ][!surface],
|
|---|
| 63 | *[source:bridge ][!bridge],
|
|---|
| 64 | *[source:old_name ][!old_name],
|
|---|
| 65 | *[source:bicycle ][!bicycle],
|
|---|
| 66 | *[source:designation ][!designation],
|
|---|
| 67 | *[source:height ][!height],
|
|---|
| 68 | *[source:lanes ][!lanes],
|
|---|
| 69 | *[source:postcode ][!addr:postcode],
|
|---|
| 70 | *[source:housenumber ][!addr:housenumber],
|
|---|
| 71 | *[source:addr:postcode ][!addr:postcode],
|
|---|
| 72 | *[source:addr:housenumber ][!addr:housenumber],
|
|---|
| 73 | *[source:addr ][!/^addr:/],
|
|---|
| 74 | *[source:maxspeed ][!/^maxspeed:?/] {
|
|---|
| 75 | throwWarning: tr("{0} without {1}", "{0.key}", "{1.key}");
|
|---|
| 76 | group: tr("missing tag");
|
|---|
| 77 | assertMatch: "way lanes=42";
|
|---|
| 78 | assertNoMatch: "way lanes=42 highway=unclassified";
|
|---|
| 79 | assertMatch: "node source:addr:postcode=postman";
|
|---|
| 80 | assertMatch: "node source:addr=postman";
|
|---|
| 81 | assertNoMatch: "node source:addr=postman addr:housenumber=42";
|
|---|
| 82 | }
|
|---|
| 83 |
|
|---|
| 84 | /* {0.key} without {1.key} (info level) */
|
|---|
| 85 | way[lanes:forward][!lanes:backward][oneway!=yes][oneway!=-1],
|
|---|
| 86 | way[lanes:backward][!lanes:forward][oneway!=yes][oneway!=-1],
|
|---|
| 87 | *[leaf_type ][!leaf_cycle],
|
|---|
| 88 | *[leaf_cycle][!leaf_type] {
|
|---|
| 89 | throwOther: tr("{0} without {1}", "{0.key}", "{1.key}");
|
|---|
| 90 | group: tr("missing tag");
|
|---|
| 91 | }
|
|---|
| 92 |
|
|---|
| 93 | /* {0.key} without {1.tag} */
|
|---|
| 94 | *[transformer ][!power],
|
|---|
| 95 | way[fence_type ][barrier!=fence],
|
|---|
| 96 | *[recycling_type ][amenity!=recycling],
|
|---|
| 97 | *[information ][tourism!=information],
|
|---|
| 98 | node[board_type ][information!=board],
|
|---|
| 99 | *[shelter_type ][amenity!=shelter],
|
|---|
| 100 | node[lamp_type ][highway!=street_lamp],
|
|---|
| 101 | node[map_type ][information!=map],
|
|---|
| 102 | *[site_type ][historic!=archaeological_site],
|
|---|
| 103 | *[artwork_type ][tourism!=artwork],
|
|---|
| 104 | *[castle_type ][historic!=castle],
|
|---|
| 105 | *[bridge:movable ][bridge!=movable],
|
|---|
| 106 | *[parking ][amenity!~/^(parking|parking_space|parking_entrance|motorcycle_parking)$/],
|
|---|
| 107 | way[cutline ][man_made!=cutline],
|
|---|
| 108 | *[bunker_type ][military!=bunker] {
|
|---|
| 109 | throwWarning: tr("{0} without {1}", "{0.key}", "{1.tag}");
|
|---|
| 110 | group: tr("missing tag");
|
|---|
| 111 | }
|
|---|
| 112 |
|
|---|
| 113 | /* {0.key} without {1.tag} or {2.tag} */
|
|---|
| 114 | *[substation ][power!=substation][pipeline!=substation],
|
|---|
| 115 | *[reservoir_type ][landuse!=reservoir][water!=reservoir] {
|
|---|
| 116 | throwWarning: tr("{0} without {1} or {2}", "{0.key}", "{1.tag}", "{2.tag}");
|
|---|
| 117 | group: tr("missing tag");
|
|---|
| 118 | }
|
|---|
| 119 |
|
|---|
| 120 | /* {0.tag} without {1.key} (warning level) */
|
|---|
| 121 | relation[route=bicycle][!network][type=route],
|
|---|
| 122 | relation[route=hiking][!network][type=route],
|
|---|
| 123 | relation[route=foot][!network][type=route],
|
|---|
| 124 | relation[route=horse][!network][type=route],
|
|---|
| 125 | relation[route=piste][!piste:type][type=route],
|
|---|
| 126 | relation[route=ski][!piste:type][type=route],
|
|---|
| 127 | *[tourism=information][!information],
|
|---|
| 128 | *[leisure=pitch][!sport],
|
|---|
| 129 | *[aeroway=terminal][!building],
|
|---|
| 130 | *[power=generator][!generator:source],
|
|---|
| 131 | *[amenity=social_facility][!social_facility],
|
|---|
| 132 | *[amenity=place_of_worship][!religion] {
|
|---|
| 133 | throwWarning: tr("{0} without {1}", "{0.tag}", "{1.key}");
|
|---|
| 134 | group: tr("missing tag");
|
|---|
| 135 | }
|
|---|
| 136 |
|
|---|
| 137 | /* {0.tag} without {1.key} (info level) */
|
|---|
| 138 | way[power=cable ][!location],
|
|---|
| 139 | node[power=transformer ][!voltage],
|
|---|
| 140 | way[power=line ][!voltage],
|
|---|
| 141 | way[power=minor_line ][!voltage],
|
|---|
| 142 | way[power=cable ][!voltage],
|
|---|
| 143 | *[power=generator ][!voltage][generator:output:electricity],
|
|---|
| 144 | *[power=plant ][!voltage][plant:output:electricity],
|
|---|
| 145 | *[power=substation ][!substation],
|
|---|
| 146 | *[power=transformer ][!transformer],
|
|---|
| 147 | *[amenity=parking ][!parking],
|
|---|
| 148 | *[amenity=parking_entrance ][!parking] {
|
|---|
| 149 | throwOther: tr("{0} without {1}", "{0.tag}", "{1.key}");
|
|---|
| 150 | group: tr("missing tag");
|
|---|
| 151 | assertMatch: "way power=line";
|
|---|
| 152 | assertNoMatch: "way power=line voltage=1";
|
|---|
| 153 | assertNoMatch: "way power=switch";
|
|---|
| 154 | assertMatch: "way power=substation";
|
|---|
| 155 | assertMatch: "way power=substation transformer=foobar";
|
|---|
| 156 | assertNoMatch: "way power=substation substation=foobar";
|
|---|
| 157 | assertMatch: "way power=generator generator:output:electricity=yes";
|
|---|
| 158 | assertNoMatch: "way power=generator";
|
|---|
| 159 | assertNoMatch: "way power=generator generator:output:electricity=yes voltage=1";
|
|---|
| 160 | }
|
|---|
| 161 |
|
|---|
| 162 | /* {0.key} without {1.key} or {2.key} */
|
|---|
| 163 | way[oneway][!highway][!railway] {
|
|---|
| 164 | throwWarning: tr("{0} without {1} or {2}", "{0.key}", "{1.key}", "{2.key}");
|
|---|
| 165 | group: tr("missing tag");
|
|---|
| 166 | }
|
|---|
| 167 |
|
|---|
| 168 | /* {0.key} without {1.key} or {2.tag} */
|
|---|
| 169 | *[smoothness ][!highway][amenity!~/^(parking|parking_space|parking_entrance|motorcycle_parking|bicycle_parking)$/],
|
|---|
| 170 | *[segregated ][!highway][railway!=crossing] {
|
|---|
| 171 | throwWarning: tr("{0} without {1} or {2}", "{0.key}", "{1.key}", "{2.tag}");
|
|---|
| 172 | group: tr("missing tag");
|
|---|
| 173 | }
|
|---|
| 174 |
|
|---|
| 175 | /* {0.tag} without {1.tag} (info level) see #11600 #11393 #11850 */
|
|---|
| 176 | way[highway=motorway][!oneway][junction!=roundabout],
|
|---|
| 177 | way[highway=motorway_link][!oneway][junction!=roundabout] {
|
|---|
| 178 | throwOther: tr("{0} without {1}", "{0.tag}", "{1.tag}");
|
|---|
| 179 | group: tr("missing tag");
|
|---|
| 180 | }
|
|---|
| 181 |
|
|---|
| 182 | /* {0.tag} without {1.tag} or {2.tag} */
|
|---|
| 183 | *[amenity=recycling][recycling_type!=container][recycling_type!=centre] {
|
|---|
| 184 | throwWarning: tr("{0} without {1} or {2}", "{0.tag}", "{1.tag}", "{2.tag}");
|
|---|
| 185 | group: tr("missing tag");
|
|---|
| 186 | }
|
|---|
| 187 |
|
|---|
| 188 | /* {0.key} without {1.key}, {2.tag} or {3.tag} */
|
|---|
| 189 | *[intermittent ][!waterway][natural!~/^(water|spring)$/][ford!=yes],
|
|---|
| 190 | *[boat ][!waterway][natural!=water][landuse!=basin] {
|
|---|
| 191 | throwWarning: tr("{0} without {1}, {2} or {3}", "{0.key}", "{1.key}", "{2.tag}", "{3.tag}");
|
|---|
| 192 | group: tr("missing tag");
|
|---|
| 193 | }
|
|---|
| 194 |
|
|---|
| 195 | /* {0.key} without {1.key}, {2.key} or {3.key} */
|
|---|
| 196 | *[snowplowing ][!highway][!amenity][!leisure] {
|
|---|
| 197 | throwWarning: tr("{0} without {1}, {2} or {3}", "{0.key}", "{1.key}", "{2.key}", "{3.key}");
|
|---|
| 198 | group: tr("missing tag");
|
|---|
| 199 | }
|
|---|
| 200 |
|
|---|
| 201 | /* {0.key} without {1.key}, {2.key} or {3.tag} */
|
|---|
| 202 | way[incline ][!highway][!railway][aeroway!~/^(runway|taxiway)$/],
|
|---|
| 203 | *[toll ][!highway][!barrier][route!~/^(ferry|road)$/] {
|
|---|
| 204 | throwWarning: tr("{0} without {1}, {2} or {3}", "{0.key}", "{1.key}", "{2.key}", "{3.tag}");
|
|---|
| 205 | group: tr("missing tag");
|
|---|
| 206 | }
|
|---|
| 207 |
|
|---|
| 208 | /* {0.tag} together with {1.key}, see #10837, #14034 */
|
|---|
| 209 | *[amenity=vending_machine][shop],
|
|---|
| 210 | *[noname?][name] {
|
|---|
| 211 | throwWarning: tr("{0} together with {1}", "{0.tag}", "{1.key}");
|
|---|
| 212 | group: tr("suspicious tag combination");
|
|---|
| 213 | }
|
|---|
| 214 |
|
|---|
| 215 | /* {0.tag} together with {1.key}, see #9389, #11977, #13156 */
|
|---|
| 216 | way[oneway=yes][/:backward/][!traffic_sign:backward][bicycle:backward!=use_sidepath],
|
|---|
| 217 | way[oneway=yes][/:forward/][!traffic_sign:forward][bicycle:forward!=use_sidepath],
|
|---|
| 218 | way[oneway=-1 ][/:backward/][!traffic_sign:backward][bicycle:backward!=use_sidepath],
|
|---|
| 219 | way[oneway=-1 ][/:forward/][!traffic_sign:forward][bicycle:forward!=use_sidepath] {
|
|---|
| 220 | throwWarning: tr("{0} together with {1}", "{0.tag}", "{1.key}");
|
|---|
| 221 | group: tr("suspicious tag combination");
|
|---|
| 222 | }
|
|---|
| 223 |
|
|---|
| 224 | /* {0.tag} together with {1.tag} (info level), see #9696 */
|
|---|
| 225 | way[highway=footway][oneway=no] {
|
|---|
| 226 | throwOther: tr("{0} together with {1}", "{0.tag}", "{1.tag}");
|
|---|
| 227 | group: tr("suspicious tag combination");
|
|---|
| 228 | }
|
|---|
| 229 |
|
|---|
| 230 | /* {0.tag} together with {1.tag}, see #10186 */
|
|---|
| 231 | way[highway=footway][bicycle=designated] {
|
|---|
| 232 | throwWarning: tr("{0} together with {1}", "{0.tag}", "{1.tag}");
|
|---|
| 233 | group: tr("suspicious tag combination");
|
|---|
| 234 | }
|
|---|
| 235 |
|
|---|
| 236 | /* #11127, #13727 */
|
|---|
| 237 | way[waterway][bridge=yes][waterway!=weir] {
|
|---|
| 238 | throwWarning: tr("{0} together with {1}", "{0.key}", "{1.tag}");
|
|---|
| 239 | suggestAlternative: "bridge=aqueduct";
|
|---|
| 240 | group: tr("suspicious tag combination");
|
|---|
| 241 | fixAdd: "bridge=aqueduct";
|
|---|
| 242 | }
|
|---|
| 243 | way[waterway=weir][bridge=yes][highway] {
|
|---|
| 244 | throwWarning: tr("{0} together with {1}", "{0.tag}", "{1.tag}");
|
|---|
| 245 | suggestAlternative: "waterway=weir + ford=yes";
|
|---|
| 246 | suggestAlternative: "waterway=dam";
|
|---|
| 247 | suggestAlternative: tr("two objects, one with {0} and one with {1} + {2} + {3}", "{0.tag}", "{2.key}", "{1.tag}", "layer");
|
|---|
| 248 | group: tr("suspicious tag combination");
|
|---|
| 249 | }
|
|---|
| 250 |
|
|---|
| 251 | /* only {0.key}, see #11104 #12422 */
|
|---|
| 252 | *[area][eval(number_of_tags()) = 1],
|
|---|
| 253 | *[name][eval(number_of_tags()) = 1],
|
|---|
| 254 | *[ref][eval(number_of_tags()) = 1],
|
|---|
| 255 | *[lit][eval(number_of_tags()) = 1] {
|
|---|
| 256 | throwWarning: tr("incomplete object: only {0}", "{0.key}");
|
|---|
| 257 | group: tr("missing tag");
|
|---|
| 258 | }
|
|---|
| 259 | /* only {0.key} and {1.key}, see #11104 */
|
|---|
| 260 | *[name][area][eval(number_of_tags()) = 2],
|
|---|
| 261 | *[name][ref][eval(number_of_tags()) = 2] {
|
|---|
| 262 | throwWarning: tr("incomplete object: only {0} and {1}", "{0.key}", "{1.key}");
|
|---|
| 263 | group: tr("missing tag");
|
|---|
| 264 | }
|
|---|
| 265 |
|
|---|
| 266 | /* #9811, #11491, #12865 */
|
|---|
| 267 | *[place][place!=farm][/^addr:/],
|
|---|
| 268 | *[boundary][/^addr:/],
|
|---|
| 269 | *[highway][/^addr:/][highway!=services][highway!=rest_area][!"addr:postcode"] {
|
|---|
| 270 | throwWarning: tr("{0} together with addr:*", "{0.key}");
|
|---|
| 271 | group: tr("suspicious tag combination");
|
|---|
| 272 | }
|
|---|
| 273 | *[!highway][postal_code]["addr:postcode"][postal_code=*"addr:postcode"] {
|
|---|
| 274 | throwWarning: tr("{0} together with {1}", "{1.key}", "{2.key}");
|
|---|
| 275 | group: tr("suspicious tag combination");
|
|---|
| 276 | }
|
|---|
| 277 | *[!highway][postal_code]["addr:postcode"][postal_code!=*"addr:postcode"] {
|
|---|
| 278 | throwWarning: tr("{0} together with {1} and conflicting values", "{1.key}", "{2.key}");
|
|---|
| 279 | group: tr("suspicious tag combination");
|
|---|
| 280 | }
|
|---|
| 281 | way[highway][postal_code]["addr:postcode"][postal_code=*"addr:postcode"] {
|
|---|
| 282 | throwWarning: tr("{0} together with {1}", "{1.key}", "{2.key}");
|
|---|
| 283 | group: tr("suspicious tag combination");
|
|---|
| 284 | fixRemove: "addr:postcode";
|
|---|
| 285 | }
|
|---|
| 286 | way[highway][postal_code]["addr:postcode"][postal_code!=*"addr:postcode"] {
|
|---|
| 287 | throwWarning: tr("{0} together with {1} and conflicting values", "{1.key}", "{2.key}");
|
|---|
| 288 | group: tr("suspicious tag combination");
|
|---|
| 289 | }
|
|---|
| 290 | way[highway][highway!=services][highway!=rest_area][!postal_code]["addr:postcode"] {
|
|---|
| 291 | throwWarning: tr("{0} together with {1}", "{0.key}", "{4.key}");
|
|---|
| 292 | suggestAlternative: "postal_code";
|
|---|
| 293 | group: tr("suspicious tag combination");
|
|---|
| 294 | fixChangeKey: "addr:postcode=>postal_code";
|
|---|
| 295 | }
|
|---|
| 296 |
|
|---|
| 297 | /* #9195 */
|
|---|
| 298 | way[highway=footway][cycleway=lane] {
|
|---|
| 299 | throwWarning: tr("{0} together with {1}", "{0.tag}", "{1.tag}");
|
|---|
| 300 | suggestAlternative: "highway=path + foot=designated + bicycle=designated + segregated=yes";
|
|---|
| 301 | group: tr("suspicious tag combination");
|
|---|
| 302 | }
|
|---|
| 303 |
|
|---|
| 304 | /* {0} on suspicious object */
|
|---|
| 305 | *[tunnel ][!highway][!railway][!waterway][public_transport != platform][man_made != pipeline],
|
|---|
| 306 | *[bridge ][!highway][!railway][!waterway][!piste:type][public_transport != platform][man_made !~ /^(bridge|pipeline)$/][building != bridge],
|
|---|
| 307 | *[psv ][!highway][!railway][!waterway][amenity !~ /^parking.*/],
|
|---|
| 308 | *[width ][!highway][!railway][!waterway][!aeroway][!cycleway][!footway][!barrier][!man_made][!entrance],
|
|---|
| 309 | *[maxspeed][!highway][!railway][traffic_sign !~ /^((.*;)?maxspeed(;.*)?|[A-Z][A-Z]:.+)$/][type != enforcement][waterway !~ /^(river|canal|lock)$/][!traffic_calming] {
|
|---|
| 310 | throwWarning: tr("{0} on suspicious object", "{0.key}");
|
|---|
| 311 | group: tr("suspicious tag combination");
|
|---|
| 312 | }
|
|---|
| 313 |
|
|---|
| 314 | node[amenity][amenity =~ /^(restaurant|cafe|fast_food)$/][!name][noname!=yes] {
|
|---|
| 315 | throwOther: tr("{0} without {1}", "{0.tag}", "{2.key}");
|
|---|
| 316 | group: tr("missing tag");
|
|---|
| 317 | assertMatch: "node amenity=restaurant";
|
|---|
| 318 | assertNoMatch: "node amenity=restaurant noname=yes";
|
|---|
| 319 | assertNoMatch: "node amenity=restaurant name=Foobar";
|
|---|
| 320 | }
|
|---|
| 321 |
|
|---|
| 322 | way[highway][barrier],
|
|---|
| 323 | *[highway][waterway][waterway!=dam][waterway!=weir],
|
|---|
| 324 | way[highway][natural],
|
|---|
| 325 | *[landuse][building] {
|
|---|
| 326 | throwWarning: tr("{0} together with {1}", "{0.key}", "{1.key}");
|
|---|
| 327 | group: tr("suspicious tag combination");
|
|---|
| 328 | assertNoMatch: "node highway=street_lamp natural=birds_nest note=josm#10193";
|
|---|
| 329 | }
|
|---|
| 330 |
|
|---|
| 331 | /* #6932 */
|
|---|
| 332 | *[natural=water][leisure=swimming_pool] {
|
|---|
| 333 | throwWarning: tr("natural water used for swimming pool");
|
|---|
| 334 | group: tr("suspicious tag combination");
|
|---|
| 335 | fixRemove: "natural";
|
|---|
| 336 | }
|
|---|
| 337 |
|
|---|
| 338 | /* #9593, #11183, #12418, #12761 */
|
|---|
| 339 | *[sport][sport!=skiing][!building][!club][tourism != hotel][highway != raceway][leisure !~ /^(sports_centre|stadium|track|pitch|golf_course|water_park|swimming_pool|recreation_ground|ice_rink|horse_riding)$/][natural !~ /^(beach|bare_rock|cliff|peak|water)$/][amenity !~ /^(pub|restaurant|swimming_pool)$/][landuse !~ /^(recreation_ground|piste|farm|farmland)$/][barrier !~ /^(wall|retaining_wall)$/][!"piste:type"][shop!=sports] {
|
|---|
| 340 | throwWarning: tr("sport without physical feature");
|
|---|
| 341 | group: tr("missing tag");
|
|---|
| 342 | assertMatch: "node sport=tennis";
|
|---|
| 343 | assertNoMatch: "node sport=tennis leisure=pitch";
|
|---|
| 344 | assertNoMatch: "node sport=beachvolleyball natural=beach";
|
|---|
| 345 | assertNoMatch: "node sport=skiing"; /* skiing has deprecated warning */
|
|---|
| 346 | assertNoMatch: "node sport=swimming tourism=hotel";
|
|---|
| 347 | assertNoMatch: "node sport=10pin amenity=restaurant";
|
|---|
| 348 | }
|
|---|
| 349 |
|
|---|
| 350 | /* #10140 */
|
|---|
| 351 | *[building:levels][!building][!building:part] {
|
|---|
| 352 | throwWarning: tr("{0} without {1} or {2}", "{0.key}", "{1.key}", "{2.key}");
|
|---|
| 353 | group: tr("missing tag");
|
|---|
| 354 | }
|
|---|
| 355 |
|
|---|
| 356 | /* any other *_name tag (with some exceptions) but not a name , see #10837 #11297 #11539 */
|
|---|
| 357 | *[/_name$/][!name][!old_name][!loc_name][!uic_name][!artist_name][!"osak:municipality_name"][!"osak:street_name"][noname!=yes] {
|
|---|
| 358 | throwWarning: tr("alternative name without {0}", "{1.key}");
|
|---|
| 359 | group: tr("missing tag");
|
|---|
| 360 | }
|
|---|
| 361 |
|
|---|
| 362 | /* #10837 */
|
|---|
| 363 | way[destination][!oneway?][junction!=roundabout][highway] {
|
|---|
| 364 | throwWarning: tr("incomplete usage of {0} on a way without {1}", "{0.key}", "{1.key}");
|
|---|
| 365 | suggestAlternative: "destination:forward";
|
|---|
| 366 | suggestAlternative: "destination:backward";
|
|---|
| 367 | }
|
|---|
| 368 |
|
|---|
| 369 | /* #11389 */
|
|---|
| 370 | way["maxspeed:forward"=*"maxspeed:backward"][!maxspeed] {
|
|---|
| 371 | throwWarning: tr("Same value of {0} and {1}", "{0.key}", "{1.key}");
|
|---|
| 372 | suggestAlternative: "maxspeed";
|
|---|
| 373 | group: tr("suspicious tag combination");
|
|---|
| 374 | fixChangeKey: "maxspeed:forward=>maxspeed";
|
|---|
| 375 | fixRemove: "maxspeed:backward";
|
|---|
| 376 | }
|
|---|
| 377 | way["maxspeed:forward"=*maxspeed]["maxspeed:backward"=*maxspeed][maxspeed] {
|
|---|
| 378 | throwWarning: tr("Same value of {0}, {1} and {2}", "{0.key}", "{1.key}", "{2.key}");
|
|---|
| 379 | set AllSameMaxspeed;
|
|---|
| 380 | suggestAlternative: "maxspeed";
|
|---|
| 381 | group: tr("suspicious tag combination");
|
|---|
| 382 | fixRemove: "maxspeed:forward";
|
|---|
| 383 | fixRemove: "maxspeed:backward";
|
|---|
| 384 | }
|
|---|
| 385 | way["maxspeed:forward"]["maxspeed:backward"][maxspeed]!.AllSameMaxspeed {
|
|---|
| 386 | throwWarning: tr("{0} and {1} together with {2} and conflicting values", "{0.key}", "{1.key}", "{2.key}");
|
|---|
| 387 | group: tr("suspicious tag combination");
|
|---|
| 388 | }
|
|---|
| 389 | way["maxspeed:forward"][maxspeed][!"maxspeed:backward"],
|
|---|
| 390 | way["maxspeed:backward"][maxspeed][!"maxspeed:forward"] {
|
|---|
| 391 | throwWarning: tr("{0} together with {1}", "{0.key}", "{1.key}");
|
|---|
| 392 | group: tr("suspicious tag combination");
|
|---|
| 393 | }
|
|---|
| 394 |
|
|---|
| 395 | /* #11837 */
|
|---|
| 396 | way[layer][layer<0][bridge][bridge!=no][location!=underground][indoor!=yes][!tunnel],
|
|---|
| 397 | way[layer][layer>0][tunnel][tunnel!=no][location!=overground][indoor!=yes][!bridge] {
|
|---|
| 398 | throwWarning: tr("{0} together with {1}", "{2.tag}", "{0.tag}");
|
|---|
| 399 | group: tr("suspicious tag combination");
|
|---|
| 400 | }
|
|---|
| 401 |
|
|---|
| 402 | /* #12942 */
|
|---|
| 403 | relation[oneway][type!=route] {
|
|---|
| 404 | throwWarning: tr("{0} on a relation without {1}", "{0.key}", "{1.tag}");
|
|---|
| 405 | }
|
|---|
| 406 |
|
|---|
| 407 | /* #9182 */
|
|---|
| 408 | way[waterway][layer][layer=~/^(-1|-2|-3|-4|-5)$/][!tunnel][culvert!=yes][covered!=yes][pipeline!=yes][location!=underground][eval(waylength()) > 400] {
|
|---|
| 409 | throwWarning: tr("Long waterway with {0} but without a tag which defines it as tunnel or underground. Remove {1} or add a tunnel tag if applicable. Also check crossing bridges and their {1} tags.", "{1.tag}", "{1.key}");
|
|---|
| 410 | group: tr("suspicious tag combination");
|
|---|
| 411 | }
|
|---|
| 412 | way[waterway][layer][layer=~/^(-1|-2|-3|-4|-5)$/][!tunnel][culvert!=yes][covered!=yes][pipeline!=yes][location!=underground][eval(waylength()) <= 400] {
|
|---|
| 413 | throwOther: tr("Short waterway with {0} but without a tag which defines it as tunnel or underground. Remove {1} or add a tunnel tag if applicable. Also check crossing bridges and their {1} tags.", "{1.tag}", "{1.key}");
|
|---|
| 414 | group: tr("suspicious tag combination");
|
|---|
| 415 | }
|
|---|
| 416 |
|
|---|
| 417 | /* #13144 */
|
|---|
| 418 | *[unisex=yes][female=yes][male!=yes],
|
|---|
| 419 | *[unisex=yes][male=yes][female!=yes] {
|
|---|
| 420 | throwWarning: tr("{0} together with {1}", "{0.tag}", "{1.tag}");
|
|---|
| 421 | group: tr("suspicious tag combination");
|
|---|
| 422 | }
|
|---|
| 423 | *[unisex=yes][female=yes][male=yes] {
|
|---|
| 424 | throwWarning: tr("{0} together with {1} and {2}. Remove {1} and {2}", "{0.tag}", "{1.tag}", "{2.tag}");
|
|---|
| 425 | group: tr("suspicious tag combination");
|
|---|
| 426 | fixRemove: "female";
|
|---|
| 427 | fixRemove: "male";
|
|---|
| 428 | }
|
|---|
| 429 | *[female=yes][male=yes][!unisex][shop=hairdresser] { /* for toilets male=yes female=yes unisex=no combination is valid */
|
|---|
| 430 | throwWarning: tr("{0} together with {1}", "{0.tag}", "{1.tag}");
|
|---|
| 431 | suggestAlternative: "unisex=yes";
|
|---|
| 432 | group: tr("suspicious tag combination");
|
|---|
| 433 | fixRemove: "female";
|
|---|
| 434 | fixRemove: "male";
|
|---|
| 435 | fixAdd: "unisex=yes";
|
|---|
| 436 | }
|
|---|
| 437 |
|
|---|
| 438 | /* #13138 */
|
|---|
| 439 | area:closed[water][natural!=water][water!=intermittent] { /* water=intermittent is deprecated and has an own warning */
|
|---|
| 440 | throwWarning: tr("{0} without {1}", "{1.key}", "{2.tag}");
|
|---|
| 441 | group: tr("missing tag");
|
|---|
| 442 | fixAdd: "natural=water";
|
|---|
| 443 | }
|
|---|
| 444 | way!:closed[water][natural!=water][water!=intermittent] {
|
|---|
| 445 | throwWarning: tr("{0} without {1}", "{1.key}", "{2.tag}");
|
|---|
| 446 | group: tr("missing tag");
|
|---|
| 447 | }
|
|---|
| 448 |
|
|---|
| 449 | /* see #8519, #11529, limited to motorways and trunks to avoid false positives for streets with lanes for non motorized traffic */
|
|---|
| 450 | way[highway =~ /^(motorway|motorway_link|trunk|trunk_link)$/][lanes][turn:lanes ][tag(lanes)!=eval(count(split("|", tag("turn:lanes"))))],
|
|---|
| 451 | way[highway =~ /^(motorway|motorway_link|trunk|trunk_link)$/][lanes][change:lanes ][tag(lanes)!=eval(count(split("|", tag("change:lanes"))))],
|
|---|
| 452 | way[highway =~ /^(motorway|motorway_link|trunk|trunk_link)$/][lanes][maxspeed:lanes ][tag(lanes)!=eval(count(split("|", tag("maxspeed:lanes"))))],
|
|---|
| 453 | way[highway =~ /^(motorway|motorway_link|trunk|trunk_link)$/][lanes][minspeed:lanes ][tag(lanes)!=eval(count(split("|", tag("minspeed:lanes"))))],
|
|---|
| 454 | way[highway =~ /^(motorway|motorway_link|trunk|trunk_link)$/][lanes][destination:lanes ][tag(lanes)!=eval(count(split("|", tag("destination:lanes"))))],
|
|---|
| 455 | way[highway =~ /^(motorway|motorway_link|trunk|trunk_link)$/][lanes][destination:ref:lanes ][tag(lanes)!=eval(count(split("|", tag("destination:ref:lanes"))))],
|
|---|
| 456 | way[highway =~ /^(motorway|motorway_link|trunk|trunk_link)$/][lanes][destination:symbol:lanes][tag(lanes)!=eval(count(split("|", tag("destination:symbol:lanes"))))] {
|
|---|
| 457 | throwWarning: tr("Different number of lanes in the keys {0} and {1}", "{1.key}", "{2.key}");
|
|---|
| 458 | group: tr("suspicious tag combination");
|
|---|
| 459 | }
|
|---|
| 460 |
|
|---|
| 461 | /* #13680 */
|
|---|
| 462 | area[golf=bunker][natural=beach] {
|
|---|
| 463 | throwWarning: tr("{0} together with {1}", "{0.tag}", "{1.tag}");
|
|---|
| 464 | suggestAlternative: "natural=sand";
|
|---|
| 465 | suggestAlternative: "surface=sand";
|
|---|
| 466 | group: tr("suspicious tag combination");
|
|---|
| 467 | }
|
|---|
| 468 |
|
|---|
| 469 | /* #13705 */
|
|---|
| 470 | relation[type=multipolygon][building] > way {
|
|---|
| 471 | set part_of_building_MP;
|
|---|
| 472 | }
|
|---|
| 473 | way["addr:housenumber"][!building][!"building:part"][!"demolished:building"][!note][!amenity][!leisure][!landuse][!man_made][!tourism][!barrier]!.part_of_building_MP {
|
|---|
| 474 | /* don't exclude shop because a lot of real missing bulding tag cases have a shop tag. */
|
|---|
| 475 | throwOther: tr("possibly missing {0} tag", "{1.key}");
|
|---|
| 476 | group: tr("missing tag");
|
|---|
| 477 | }
|
|---|
| 478 |
|
|---|
| 479 | way[highway][lanes][!lanes:forward][!lanes:backward][oneway!=yes][oneway!=-1][lanes>2],
|
|---|
| 480 | way[highway][lanes][!lanes:backward][!lanes:forward][oneway!=yes][oneway!=-1][lanes>2] {
|
|---|
| 481 | throwWarning: tr("street with {0} > 2, but without {1} and {2} or {3}", "{1.key}", "{2.key}", "{3.key}", "{4.key}");
|
|---|
| 482 | group: tr("missing tag");
|
|---|
| 483 | assertNoMatch: "way highway=primary lanes=2";
|
|---|
| 484 | assertNoMatch: "way highway=primary lanes=3 lanes:backward=2";
|
|---|
| 485 | assertNoMatch: "way highway=primary lanes=3 oneway=-1";
|
|---|
| 486 | assertMatch: "way highway=primary lanes=3";
|
|---|
| 487 | }
|
|---|