Modify

Opened 5 years ago

Closed 4 years ago

Last modified 4 years ago

#8336 closed defect (fixed)

does not check for associatedStreet relation

Reported by: skyper Owned by: OliverW
Priority: major Milestone:
Component: Plugin fixaddresses Version:
Keywords: check relation Cc:

Description

FixAddress does not check for associatedStreet relation (did not test Street relation).

Please, have the plugin check these relations before adding duplicate data.

Repository Root: http://josm.openstreetmap.de/svn
Build-Date: 2013-01-04 02:32:00
Last Changed Author: Don-vip
Revision: 5662
Repository UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b
URL: http://josm.openstreetmap.de/svn/trunk
Last Changed Date: 2013-01-04 01:49:12 +0100 (Fri, 04 Jan 2013)
Last Changed Rev: 5662

Identification: JOSM/1.5 (5662 de)
Memory Usage: 158 MB / 643 MB (34 MB allocated, but free)
Java version: 1.6.0_24, Sun Microsystems Inc., OpenJDK 64-Bit Server VM
Operating system: Linux
Dataset consistency test: No problems found

Plugin: FixAddresses (28807)

Attachments (0)

Change History (13)

comment:1 Changed 5 years ago by OliverW

It did this check in earlier times, but there was a quite significant protest by the community. Personally I preferred relations due to data integrity reasons, but most people did not share this view and reuquest me to remove this feature under the flag of "user simplicity".

comment:2 Changed 5 years ago by OliverW

Resolution: needinfo
Status: newclosed

comment:3 Changed 5 years ago by OliverW

Resolution: needinfo
Status: closedreopened

comment:4 Changed 5 years ago by Don-vip

Well, things have changed. associatedStreet has become very popular now with 94.000 occurences and cannot be simply ignored :)

comment:5 in reply to:  1 Changed 5 years ago by skyper

Replying to OliverW:

It did this check in earlier times, but there was a quite significant protest by the community. Personally I preferred relations due to data integrity reasons, but most people did not share this view and reuquest me to remove this feature under the flag of "user simplicity".

And now the user does not care and even does not get any information about these relations. Sorry, but this seems to be ignorant and leads to duplicate if not contradicting data.

I wonder, that you got that deeply influenced to remove it completely without any option to turn it on.

Well as time did pass, "associatedStreet" and "Street" relations got more and more popular and I kindly ask you to reimplement the relation support.

Thanks

comment:6 Changed 5 years ago by OliverW

You do not need to convince me :)

It was just a frustrating experience and I would like to avoid it a second time. But ok, I can reimplement it. What do you think about the Option to convert a tagged street into a Street with a relation? This could reduce the amount of redundant data dramatically.

comment:7 in reply to:  6 Changed 5 years ago by skyper

Replying to OliverW:

It was just a frustrating experience and I would like to avoid it a second time. But ok, I can reimplement it.

You gonna have some supporter this time, but I do not really know the user of this plugin.
I did already post my opinion above.

What do you think about the Option to convert a tagged street into a Street with a relation? This could reduce the amount of redundant data dramatically.

Wow, this would be 180° turn and would open up the plugin for more users. Right now, I either simply select the relations and look for houses/addresses which are not member (highlighted) or use some filter.

A plugin which checks and makes conversion/inclusion to a relation and fixing possible in one step would be a nice enhancement. Lately there was some code added to core to sort these relations and to guess the right role. Maybe this plugin could use some of it.

comment:8 Changed 4 years ago by skyper

Any news or opinions ?

comment:9 Changed 4 years ago by OliverW

Nope, sorry

comment:10 Changed 4 years ago by OliverW

Could you provide me some coordinates where I can find streets using a relation? Currently I have some time to have a look at it... thanks in advance!

comment:11 Changed 4 years ago by skyper

For associatedStreet relations, please, have a look at this City. Especially the southern and western neighbourhoods contain a lot. If you are only looking for some use this link.

Thanks in advance.

comment:12 Changed 4 years ago by OliverW

Relations should now be recognized correctly - please test ([o29969])

Last edited 4 years ago by Don-vip (previous) (diff)

comment:13 Changed 4 years ago by OliverW

Resolution: fixed
Status: reopenedclosed

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain OliverW.
as The resolution will be set.
The resolution will be deleted.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.