Opened 13 years ago
Closed 5 years ago
#8266 closed defect (needinfo)
validator issues incorrect warning for "route" relation
| Reported by: | Gilbert54 | Owned by: | Gilbert54 |
|---|---|---|---|
| Priority: | normal | Milestone: | |
| Component: | Core validator | Version: | |
| Keywords: | public_transport role check | Cc: | Xapitoun |
Description
Role <empty> missing - Role verification problem (1)
org.openstreetmap.josm.data.validation.TestError@1db6fbe
relation: 2592193
I deleted all stop and platform members and the warning won't go away. Eventually restored the relation to it's original state.In my opinion the validator gives incorrect results.
When I test this relation with the OSM relation analyzer everything checks out OK.
http://ra.osmsurround.org/analyzeRelation?relationId=2592193&_noCache=on#
Repository Root: http://josm.openstreetmap.de/svn
Build-Date: 2012-11-29 02:31:07
Last Changed Author: stoecker
Revision: 5608
Repository UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b
URL: http://josm.openstreetmap.de/svn/trunk
Last Changed Date: 2012-11-28 23:47:46 +0100 (Wed, 28 Nov 2012)
Last Changed Rev: 5608
Identification: JOSM/1.5 (5608 en_GB)
Memory Usage: 439 MB / 494 MB (36 MB allocated, but free)
Java version: 1.7.0_09, Oracle Corporation, Java HotSpot(TM) Client VM
Operating system: Windows 7
Dataset consistency test: No problems found
Attachments (0)
Change History (14)
comment:1 by , 13 years ago
comment:2 by , 13 years ago
| Summary: | validator issues incorrect warning for relation → validator issues incorrect warning for "route" relation |
|---|
comment:4 by , 12 years ago
| Cc: | added |
|---|
comment:6 by , 12 years ago
| Keywords: | public_transport role check added; incorrect validation result removed |
|---|
comment:7 by , 12 years ago
| Owner: | changed from to |
|---|---|
| Status: | new → needinfo |
Are you sure that highway=bus_stop with role platform is correct according to the older and/or newer PT mapping scheme. I think either highway=bus_stop with role stop is correct in the older one, or public_transport=platform with role platform according to the newer one.
comment:8 by , 12 years ago
| Milestone: | → 14.02 |
|---|
comment:9 by , 12 years ago
| Resolution: | → needinfo |
|---|---|
| Status: | needinfo → closed |
comment:10 by , 12 years ago
| Milestone: | 14.02 |
|---|
follow-up: 14 comment:11 by , 5 years ago
| Resolution: | needinfo |
|---|---|
| Status: | closed → reopened |
Wait was this resolved or not? I have same issue in 2020 (version 15937).
Relation 8860865 is type=route_master
Relation 8860864 is a member of 8860865 with empty role, as prescribed by https://wiki.openstreetmap.org/wiki/Relation:route_master#Members
Validator says that 8860864 has "Role verification problem - Role '<empty>' missing"
follow-up: 13 comment:12 by , 5 years ago
I tried to assign role=<empty>, the above warning still remains but there is another one on top of that: "Role '<empty>' is not in templates"
comment:13 by , 5 years ago
Replying to anonymous:
I tried to assign role=<empty>, the above warning still remains but there is another one on top of that: "Role '<empty>' is not in templates"
Please, recheck if the role is really "empty". I have found fixed white spaces as role value. So change the role and make sure you add nothing. One way is to use the relation editor and use the role box at the bottom. You should be warned about adding an empty value with default settings.
comment:14 by , 5 years ago
| Resolution: | → needinfo |
|---|---|
| Status: | reopened → closed |
Replying to anonymous:
Wait was this resolved or not? I have same issue in 2020 (version 15937).
Relation 8860865 is type=route_master
Relation 8860864 is a member of 8860865 with empty role, as prescribed by https://wiki.openstreetmap.org/wiki/Relation:route_master#Members
Validator says that 8860864 has "Role verification problem - Role '<empty>' missing"
Hey, the warning is about the members of the type=route relation (8860864 which does not have any way and no object with <empty> role as member. As public_transport:version=2 is present the warning is correct.



I agree that this warning is unwanted. Reason: relation is validated also according to new public transport scheme – see also my comment:6:ticket:8255.