JOSM doesn't recognise a 412 precondition failed when a relation is uploaded.

[shaunmcdonald131@…]

If the server returns a 412 for a relation, JOSM just accepts it, and thinks it's ok. It doesn't tell the user that there is a problem like when the server returns a 500.

[allgemein@…]

I experienced the same.

You can reproduce it with the following steps:

• run josm r741 (here: debian testing with java5)
• download ​http://www.openstreetmap.org/api/0.5/map?bbox=13.377506251548391,52.51615009149084,13.377518925752623,52.516162177499965 (location of the node of Berlin)
• download ​http://www.openstreetmap.org/api/0.5/map?bbox=11.414744073860579,53.62881485680221,11.414855969023005,53.628921559039966 (location of the node of Schwerin in Mecklenburg-Western Pomerania)
• add the relation 22956 (realm "Mecklenburg-Vorpommern") to relation 7887 (nation "Deutschland")
• upload the change
• wait for the timeout (minutes?)
• check the return code in the console: got return: 412 with id 7887

The error was reproducible with the following variations:

• download the incomplete relations 22956 and 7887 before adding the first one to the second
• add node 21993086 (instead of relation 22956) to relation 7887

Adding relations or nodes to other relations (besides 7887) works properly here. Maybe there is something wrong with relation 7887?

An error message after the upload would surely be helpful to avoid user madness :)

Thanks for your work!

[anonymous]

Should be fixed in newer versions. Reopen report, when still existing.

[OSM@…]

The error still exists in JOSM Version 1479. I tried to add a bus_stop to relation 79221 and got the error "412 precondition failed", but JOSM did as if everything was OK. But my changes did not got uploaded.

[anonymous]

Ticket #1748 has been marked as a duplicate of this ticket.

[raffourtit@…]

see also #2437 which includes a patch for a similar issue

[Gubaer]

JOSM version: current from SVN, 1566

Tried to reproduce the bug following the steps above. Took a long time but ultimatelly completed with ... OK.

In addition, framm has provided a fix which improves improves notification of API errors, similar but slightly different to the patch from #2437.

I therefore close this ticket. Reopen report, when still existing.