#7288 closed defect (fixed)
relationeditor shortcut conflicts
Reported by: | skyper | Owned by: | team |
---|---|---|---|
Priority: | normal | Milestone: | |
Component: | Core | Version: | latest |
Keywords: | short cut conflict | Cc: |
Description
Thanks for your work !
Once again there are short cut conflicts within josm core.
Repository Root: http://josm.openstreetmap.de/svn Build-Date: 2012-01-17 02:31:43 Last Changed Author: stoecker Revision: 4806 Repository UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b URL: http://josm.openstreetmap.de/svn/trunk Last Changed Date: 2012-01-16 22:12:18 +0100 (Mon, 16 Jan 2012) Last Changed Rev: 4806 Warnung: Fehlende Einstellungsdatei "$HOME/.josm/preferences.xml". Datei mit Standardeinstellungen wird erstellt. GET http://api.openstreetmap.org/api/capabilities... OK Kommunikation mit http://api.openstreetmap.org/api mittels Protokollversion 0.6 etabliert. Silent shortcut conflict: 'relationeditor:sort' moved by 'menu:Tools' to 'Alt+B'. Silent shortcut conflict: 'relationeditor:removeselected' moved by 'properties:edit' to 'Alt+G'.
Attachments (0)
Change History (12)
comment:1 by , 12 years ago
comment:2 by , 12 years ago
They get even more:
Last Changed Rev: 4881 GET http://api.openstreetmap.org/api/capabilities... OK lade Plugin 'turnlanes' (Version 27355) lade Plugin 'reverter' (Version 27604) RemoteControl: adding command "revert_changeset" (handled by RevertChangesetHandler) lade Plugin 'utilsplugin2' (Version 27624) ... Silent shortcut conflict: 'relationeditor:moveup' moved by 'menu:Selection' to 'Alt+B'. Silent shortcut conflict: 'relationeditor:remove' moved by 'tools:extnode' to 'Alt+G'. Silent shortcut conflict: 'relationeditor:sort' moved by 'menu:Tools' to 'Alt+K'. Silent shortcut conflict: 'relationeditor:reverse' moved by 'menu:More tools' to 'Alt+M'. Silent shortcut conflict: 'relationeditor:downloadincomplete' moved by 'relationeditor:sort' to 'Alt+O'. Silent shortcut conflict: 'relationeditor:removeselected' moved by 'properties:edit' to 'Alt+Q'.
Especially the third and fifth move is not very clever.
comment:3 by , 12 years ago
As for me, relationeditor:* shortcuts does not work even without utilsplugin2!
follow-up: 6 comment:4 by , 12 years ago
@All
Can someone confirm tha some shortcut is working in relation editor(even without plugins)? Which one does?
comment:6 by , 12 years ago
Replying to akks:
@All
Can someone confirm tha some shortcut is working in relation editor(even without plugins)? Which one does?
As I have never used shortcuts in relation editor and they all do not work on my system, I felt I was not asked to comment.
Think the whole shortcut system for relation editor is broken !
Repository Root: http://josm.openstreetmap.de/svn Build-Date: 2012-02-06 02:32:18 Last Changed Author: Don-vip Revision: 4903 Repository UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b URL: http://josm.openstreetmap.de/svn/trunk Last Changed Date: 2012-02-05 21:35:37 +0100 (Sun, 05 Feb 2012) Last Changed Rev: 4903 Warnung: Fehlende Einstellungsdatei "$HOME/.josm/preferences.xml". Datei mit Standardeinstellungen wird erstellt. GET http://api.openstreetmap.org/api/capabilities... OK Open file: $HOME/Downloads/relations_sort.osm (12290 bytes) Silent shortcut conflict: 'relationeditor:sort' moved by 'menu:Tools' to 'Alt+B'. Silent shortcut conflict: 'relationeditor:removeselected' moved by 'properties:edit' to 'Alt+G'.
Repository Root: http://josm.openstreetmap.de/svn Build-Date: 2012-02-06 02:32:18 Last Changed Author: Don-vip Revision: 4903 Repository UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b URL: http://josm.openstreetmap.de/svn/trunk Last Changed Date: 2012-02-05 21:35:37 +0100 (Sun, 05 Feb 2012) Last Changed Rev: 4903 Identification: JOSM/1.5 (4903 de) Memory Usage: 25 MB / 248 MB (5 MB allocated, but free) Java version: 1.6.0_18, Sun Microsystems Inc., OpenJDK Client VM Operating system: Linux
comment:7 by , 12 years ago
On Windows they do not work too. And it is not because of conficts - I tried to change the code. So, only way to close tis ticket is to remove all shortcut definitions from the relation editor :-) Are there Other options?
@Stoecker: You know the shortcut system much better than us, can you tell what is wrong with these ones? Or maybe fix it...
comment:8 by , 12 years ago
I wonder why they *should* work from a technical point of view. GenericRelationEditor
contains several Shortcut.registerShortcut(...)
statements without doing anything with the shortcut. I assume, all of them can be dropped, or be replaced with a working implementation, right?
follow-up: 10 comment:9 by , 12 years ago
I think so :) I did not notice such trivial thing :)
So maybe you extend your patch from #7301 to these shortcuts and apply it (with changed shortcuts)?
comment:10 by , 12 years ago
comment:12 by , 12 years ago
Please have a look at changes and reopen this ticket if conflicts remain or reappear.
Strange - it seems that there are no working shortcuts in relation editor!
When I change shortcuts in code, conflicts change or vanish but shortcuts are not working...
(With clean SVN code too, Windows 7, tested with Russian and English locale)