Fail to update a way loaded from osmChange that have been deleted after

[Don-vip]

When loading this changeset (via Ctrl-L):
​http://api.openstreetmap.org/api/0.6/changeset/482681/download

This error occurs: "Deleted node referenced: {way...}".

I managed to avoid this error, but I'm not sure at all it's the best way to handle this, and I'm afraid of potential side effects, can someone take a look at my patch, please ?

[stoecker]

Can you please explain what and why you do?

[Don-vip]

Replying to stoecker:

Can you please explain what and why you do?

Yep.

This error comes from calling setDeleted(true) on a way containing deleted nodes (because the way and at least some of its nodes have been deleted after the time of the changeset). There's a data integrity check in Way.checkNodes() that forbids that:

                if (n.isDeleted())
                    throw new DataIntegrityProblemException("Deleted node referenced: " + toString());

The question is: I'm not sure of the proper way to fix that. Is removing all the nodes safe ? Maybe just removing deleted nodes ? Maybe another obvious option I've missed ? :)

[bastiK]

In DownloadOsmChangeTask, it shouldn't update the data. A changeset is the transition from one historic state to the next. Has nothing to do with the present.

Instead we should offer to load the missing data for the given date&time (load node history and use matching old version).

[Don-vip]

Replying to bastiK:

In DownloadOsmChangeTask, it shouldn't update the data. A changeset is the transition from one historic state to the next. Has nothing to do with the present.

Instead we should offer to load the missing data for the given date&time (load node history and use matching old version).

OK I'll fix that and see if the data is correctly updated with a manual update, after changeset loading.

[Don-vip]

It works :)

[Don-vip]

In [4734/josm]:

fix #7194 - Reworking of osmChange downloads (Fail to update a way loaded from osmChange that have been deleted after)