property toggle dialog: possibility to select and perform actions on several entries at once.

[skyper]

I like to have a possibility to select several entries at the property toggle dialog and perform actions on them like delete, copy key/value ...

Have a look at #6857 for some background.

The best solution for "Edit" needs to be discussed. See ticket/6857

Thanks for your work !

r4453

[stoecker]

I think this was already requested in the past and I still feel that it would be much more dangerous to implement this than it would bring benefits. We improved the selection e.g. after delete, so deleting multiple elements most time means to press delete repeatedly.

[skyper]

Replying to stoecker:

I think this was already requested in the past and I still feel that it would be much more dangerous to implement this than it would bring benefits. We improved the selection e.g. after delete, so deleting multiple elements most time means to press delete repeatedly.

Actually, important for me in first place would be a copy key+value action on several entries.

I notized that in the relations toggle dialog some actions are disabled when several entries (relations) are selected.

[joshdoe]

allow deletion of multiple properties or tags

[joshdoe]

I've been doing lots of TIGER clean up lately, and have been removing tiger: tags quite a bit. So I made the attached patch to allow deleting multiple properties (tags). This is related to the now closed #1478 and #1752.

[bastiK]

In [4697/josm]:

see #6883 - property toggle dialog: possibility to select and perform actions on several entries at once. (patch by joshdoe)

[bastiK]

I don't see how this is dangerous. You normally don't select multiple properties, and it is pretty clear and straight forward behaviour anyway.

[joshdoe]

Replying to bastiK:

I don't see how this is dangerous. You normally don't select multiple properties, and it is pretty clear and straight forward behaviour anyway.

I'd agree. One thing I'm not sure about though is that right now multiple commands are issued for the deletion, so if you delete 10 tags than you'd have to run the undo command 10 times. Should I implement a new command that deletes multiple tags?

[skyper]

Replying to joshdoe:

Replying to bastiK:

I don't see how this is dangerous. You normally don't select multiple properties, and it is pretty clear and straight forward behaviour anyway.

I think the normal focus behaviour (click to focus) is much more dangerous. At least speaking for myself. See comment:12:ticket:3278

I'd agree. One thing I'm not sure about though is that right now multiple commands are issued for the deletion, so if you delete 10 tags than you'd have to run the undo command 10 times. Should I implement a new command that deletes multiple tags?

This way you might be able to only undo some changes. (You can always undo many steps at once in the command stack dialog.)

Only real problem, I see is with un/redo.

[joshdoe]

Thanks for committing the patch bastiK.

The above patch (attachment:modify_multiple_properties_at_once.patch​) modifies ChangePropertyCommand to support modifying (including deleting) multiple properties of multiple objects at once (creating just one command instead of multiple commands as now). This improves speed when deleting many tags (e.g. TIGER tags) on many objects, since each object is only iterated over once and begin/endUpdate() is only executed once. The patch also uses this command when deleting multiple properties, which is why I am attaching this here.

I tried to reduce redundant code as much as possible, but if it is preferred to have a dedicated code path for deleting single properties let me know.

[bastiK]

In [4773/josm]:

applied #6883 - property toggle dialog: possibility to select and perform actions on several entries at once. (patch by joshdoe)