Modify

#6641 closed defect (irreproducible)

Validator: All checks for a "needed roles" should be disabled for incomplete relations (WAS: Do not run role checks on incomplete relations)

Reported by: skyper Owned by: team
Priority: normal Component: Core validator
Version: Keywords: validator incomplete relations role
Cc:

Description (last modified by skyper)

I get several false positives on role checks of incomplete relations.

Just happened with associatedStreet and role=street incomplete but have a look at #6357 and #6069 for more examples.

Please, do not run role checks on incomplete relations.
Maybe the empty role check is ok but almost all other role checks get more false positives than real errors with incomplete relations.

Thanks

r4261

Attachments (0)

Change History (4)

comment:1 Changed 22 months ago by skyper

  • Description modified (diff)

comment:2 in reply to: ↑ description ; follow-up: Changed 22 months ago by skyper

  • Summary changed from Validator: Do not run role checks on incomplete relations to Validator: All checks for a "needed roles" should be disabled for incomplete relations (WAS: Do not run role checks on incomplete relations)

Replying to skyper:

I get several false positives on role checks of incomplete relations.

Just happened with associatedStreet and role=street incomplete but have a look at #6357 and #6069 for more examples.

Please, do not run role checks on incomplete relations.
Maybe the empty role check is ok but almost all other role checks get more false positives than real errors with incomplete relations.

Sorry, was a bit to harsh and fast.

All checks for a "needed role" should be disabled for incomplete relations

Thanks

r4261

comment:3 in reply to: ↑ 2 Changed 21 months ago by simon04

Replying to skyper:

All checks for a "needed role" should be disabled for incomplete relations

Please add an example which shows this undesired behaviour.

Stupid question: Do incomplete relations (not relations with incomplete members) exist at all?

comment:4 Changed 20 months ago by skyper

  • Resolution set to irreproducible
  • Status changed from new to closed

Seems to be fixed.

r4475

Last edited 20 months ago by skyper (previous) (diff)

Add Comment

Modify Ticket

Change Properties
<Author field>
Action
as closed .
as The resolution will be set. Next status will be 'closed'.
The resolution will be deleted. Next status will be 'reopened'.
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.