turnlane plugin: needs better info (WAS: seems to be broken after core changes (exception))

[skyper]

I did not get the plugin to work, please help.

The description so far is quite small but I think this would be a very useful plugin and might solve the big problem with lanes in the future.

All I got were 2 warning:

An error occured while constructing the model. Please, run the validator to make sure the data is consistent
Error: Ways can not be ordered

or

Error: The tag "lanes" is missing

Repository Root: http://josm.openstreetmap.de/svn
Build-Date: 2011-06-02 01:31:20
Last Changed Author: stoecker
Revision: 4114
Repository UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b
URL: http://josm.openstreetmap.de/svn/trunk
Last Changed Date: 2011-06-01 22:23:11 +0200 (Wed, 01 Jun 2011)
Last Changed Rev: 4114

GET http://api.openstreetmap.org/api/capabilities... OK
Communications with http://api.openstreetmap.org/api established using protocol version 0.6.
loading plugin 'turnlanes' (version 25908)
GET http://api.openstreetmap.org/api/0.6/map?bbox=7.843844,47.9846654,7.844265099999999,47.9849544
java.lang.IllegalArgumentException: Ways can't be ordered.
	at org.openstreetmap.josm.plugins.turnlanes.model.Utils.findPathSegment(Utils.java:203)
	at org.openstreetmap.josm.plugins.turnlanes.model.Utils.findPath(Utils.java:181)
	at org.openstreetmap.josm.plugins.turnlanes.model.Utils.orderWays(Utils.java:160)
	at org.openstreetmap.josm.plugins.turnlanes.model.ModelContainer.<init>(ModelContainer.java:113)
	at org.openstreetmap.josm.plugins.turnlanes.model.ModelContainer.create(ModelContainer.java:26)
	at org.openstreetmap.josm.plugins.turnlanes.gui.TurnLanesDialog$3.selectionChanged(TurnLanesDialog.java:82)
	at org.openstreetmap.josm.data.osm.DataSet.fireSelectionChanged(DataSet.java:404)
	at org.openstreetmap.josm.data.osm.DataSet.toggleSelected(DataSet.java:480)
	at org.openstreetmap.josm.actions.mapmode.SelectAction.selectPrims(SelectAction.java:672)
	at org.openstreetmap.josm.actions.mapmode.SelectAction.mouseReleased(SelectAction.java:500)
	at java.awt.AWTEventMulticaster.mouseReleased(AWTEventMulticaster.java:289)
	at java.awt.Component.processMouseEvent(Component.java:6136)
	at javax.swing.JComponent.processMouseEvent(JComponent.java:3267)
	at java.awt.Component.processEvent(Component.java:5901)
	at java.awt.Container.processEvent(Container.java:2105)
	at java.awt.Component.dispatchEventImpl(Component.java:4497)
	at java.awt.Container.dispatchEventImpl(Container.java:2163)
	at java.awt.Component.dispatchEvent(Component.java:4323)
	at java.awt.LightweightDispatcher.retargetMouseEvent(Container.java:4461)
	at java.awt.LightweightDispatcher.processMouseEvent(Container.java:4125)
	at java.awt.LightweightDispatcher.dispatchEvent(Container.java:4055)
	at java.awt.Container.dispatchEventImpl(Container.java:2149)
	at java.awt.Window.dispatchEventImpl(Window.java:2478)
	at java.awt.Component.dispatchEvent(Component.java:4323)
	at java.awt.EventQueue.dispatchEventImpl(EventQueue.java:649)
	at java.awt.EventQueue.access$000(EventQueue.java:96)
	at java.awt.EventQueue$1.run(EventQueue.java:608)
	at java.awt.EventQueue$1.run(EventQueue.java:606)
	at java.security.AccessController.doPrivileged(Native Method)
	at java.security.AccessControlContext$1.doIntersectionPrivilege(AccessControlContext.java:105)
	at java.security.AccessControlContext$1.doIntersectionPrivilege(AccessControlContext.java:116)
	at java.awt.EventQueue$2.run(EventQueue.java:622)
	at java.awt.EventQueue$2.run(EventQueue.java:620)
	at java.security.AccessController.doPrivileged(Native Method)
	at java.security.AccessControlContext$1.doIntersectionPrivilege(AccessControlContext.java:105)
	at java.awt.EventQueue.dispatchEvent(EventQueue.java:619)
	at java.awt.EventDispatchThread.pumpOneEventForFilters(EventDispatchThread.java:275)
	at java.awt.EventDispatchThread.pumpEventsForFilter(EventDispatchThread.java:200)
	at java.awt.EventDispatchThread.pumpEventsForHierarchy(EventDispatchThread.java:190)
	at java.awt.EventDispatchThread.pumpEvents(EventDispatchThread.java:185)
	at java.awt.EventDispatchThread.pumpEvents(EventDispatchThread.java:177)
	at java.awt.EventDispatchThread.run(EventDispatchThread.java:138)
....

[stoecker]

Plugin is missing any description how it should work and as author seems not reachable.

[skyper]

It does not work with tested (r4064).

I set up a warning on the osm wiki proposal page (section plugin).

[benshu]

Sorry, I absolutely did not monitor the Trac for tickets.

The second issue is easily explained: A lanes tag must be present on all roads joining at the selected junction, otherwise turn information can't really be interpreted. I will add a more descriptive error message.

The first error is harder to diagnose. It usually comes up when not all junction nodes and ways of a dual carriageway junction are selected. If you see this happening in other cases, please help me reproduce them, thanks.

[skyper]

Replying to benshu:

Sorry, I absolutely did not monitor the Trac for tickets.

Welcome.
Thanks I got it working. (Gonna delete warning on OSM wiki.)

The second issue is easily explained: A lanes tag must be present on all roads joining at the selected junction, otherwise turn information can't really be interpreted. I will add a more descriptive error message.

Would be nice, but lanes=1 is the default and there is no need to tag defaults. At least with oneway=yes/-1, this is possible.

Do you mean, I should count all lanes (including turn-only-lanes) and add for example lanes=4 (1 only-left, 1 left+straight, 1 straight, 1 only-right) to the main line tagged with highway=*.
Please, add an example with tags somewhere.

You could also create a plugin page under Help/Plugins and include a help button in your plugin to link directly to the help page.

The first error is harder to diagnose. It usually comes up when not all junction nodes and ways of a dual carriageway junction are selected. If you see this happening in other cases, please help me reproduce them, thanks.

I gonna open a new ticket if this happens again.

cu skyper

[benshu]

Replying to skyper:

Would be nice, but lanes=1 is the default and there is no need to tag defaults. At least with oneway=yes/-1, this is possible.

Is that specified/documented somewhere?

Do you mean, I should count all lanes (including turn-only-lanes) and add for example lanes=4 (1 only-left, 1 left+straight, 1 straight, 1 only-right) to the main line tagged with highway=*.

The number of lanes is independent of allowed turns. Just ignore all turn lanes (i.e. those short lanes right at the junction) and specify the lanes based on that.

Please, add an example with tags somewhere.

You could also create a plugin page under Help/Plugins and include a help button in your plugin to link directly to the help page.

Will do; probably a good idea.

I'll probably need until wednesday or so to get to all of this.

[skyper]

Replying to benshu:

Replying to skyper:

Would be nice, but lanes=1 is the default and there is no need to tag defaults. At least with oneway=yes/-1, this is possible.

Is that specified/documented somewhere?

My fault, thought it was but did not find it.

Will do; probably a good idea.

I'll probably need until wednesday or so to get to all of this.

No problem, I could help you with the wiki. For now I just have linked to OSM.

[anonymous]

Okay, I added two video demonstrations to the OSM wiki. It took me like 4 hours because apparently youtube accepts any input, but mangles any but WebM. I probably won't have time for anything more this week.

[benshu]

Woups, sorry, that was me.

Replying to anonymous:

Okay, I added two video demonstrations to the OSM wiki. It took me like 4 hours because apparently youtube accepts any input, but mangles any but WebM. I probably won't have time for anything more this week.

[skyper]

Thanks

I think it is working for now and if needed we can reopen the ticket with detailed description about the missing info.