[patch] Relation editor fails to detect closed path

[Zverikk]

Download one of those relations: 1429033, 72196, 1111196. They consist of one closed path (made of several ways), but in relation editor those are not shown as closed. It was ok in tested version, I guess — it cannot be started after josm-latest, so I cannot test it. JOSM 3901.

[stoecker]

This is caused by the fact that there is a node in the relation. Seems this case is overlooked now.

[Zverikk]

For relations with one node and multiple ways removing that node solves the problem indeed. But, for example, relation 1059483 not only has a node, but also an unconnected way — but all closed areas are detected and displayed as such.

[Zverikk]

More specific: closed path is not detected when a point is located (in the relation members order) inside or right after the area. For example: WWNWWWW (W=way,N=node) first path will be show as unclosed, second path — as closed. NWWWWWW (moving node to the head of the list) — both paths will be detected as closed.

[Petr_Dlouhy]

patch fixing this bug

[Petr_Dlouhy]

updated testing cases

[Petr_Dlouhy]

I made patch for this issue. I tested only the case, I made for relation_analysis.osm​, so please retest your relations.

[bastiK]

Petr_Dlouhy: are you still working on the perfection of this tool? We are going to have a tested version soon, so it would be nice to see some improvement till then.

[Petr_Dlouhy]

I haven't had enough time recently, but I might safe some time this weekend. I will take look on the remaining issues, but I can't promise to give it a large portion of work, if it became too complicated.

[bastiK]

In [3925/josm]:

fixed #5963 (patch by Petr_Dlouhy) - Relation editor fails to detect closed path