Modified state is not reset after save/commit

[Zverikk]

Take attached file, open it in latest josm (tested on 3501).
Change it: move a node, for example.
Save file.
Try to delete layer/close josm: a message will appear asking to save changes. Also, '*' in title bar never disappears.

The same bug is when downloading-changing-uploading. Very misleading.

[Zverikk]

It can be any file, this one was downloaded from St. Petersburg area

[vsandre]

The same with 3514 which will be next tested version.

[Zverikk]

How is it tested then?
This bug will lead to a great frustration among new users.
I've made it critical.

[bastiK]

Cannot reproduce.

When I follow the steps, a dialog pops up that shows that there are changes that are not uploaded yet. It does not say you need to save.

[Zverikk]

Hmm, I cannot reproduce this either.

[vsandre]

I can reproduce it every time and it is confusing if you wait for finishing the upload and only watching the window title.

Downloading an area -> adding a node -> Uploading -> Status changed correctly

Downloading an area -> changing the position of a node or it its tags -> Uploading -> Status unsaved '*'

[Ldp]

The asterisk in the title bar isn't very helpful, especially if you keep a few working files around to work in and don't actually upload anything yet.

I once suggested to have per-layer upload/save status: ​http://josm.openstreetmap.de/ticket/3888 . Then you can easily see which layers have yet to be saved or uploaded.

[jcollie]

I can confirm that this happens to me as well.

[Zverikk]

Just to bump it a bit, this happens to me every time I make changes in OSM (even by moving one node), but I can't make a reasonable test case. Probably if one of the authors would edit OSM data, they will see the problem.

[bastiK]

Replying to vsandre, Zverikk:

I can reproduce it every time and it is confusing if you wait for finishing the upload and only watching the window title.

Downloading an area -> adding a node -> Uploading -> Status changed correctly

ok

Downloading an area -> changing the position of a node or it its tags -> Uploading -> Status unsaved '*'

cannot reproduce - tried both (changing position of node and its tags). After uploading the '*' star was gone and i could delete the layer without further questions.

Maybe it helps to be more precise what you are doing. When you say every time do you mean "it happens so often it drives me mad" or literally every time? Please check with only a single change after fresh download.

[vsandre]

Can't reproduce it with the latest version of today. I will test it while normal mapping. And of course I meant "every" single time.

[Zverikk]

As for me, by every I meant only when I'm editing a lot of objects for a long time. I've tried to reproduce this bug by creating, modifying and deleting a couple of objects, and it didn't happen.

What can we do to record state when modified flag is not reset? I can make a video next time, but I doubt it will be of any use.

[bastiK]

I'm quite sure that whatever you are doing when editing a lot of objects for a long time can also be done with few objects and in short time, you "just" have to isolate the sequence of actions that trigger the bug.

Could be, that for some reason, after upload, there are still modified objects in the data layer. So it might be interesting to search for "modified" in such a situation. Also save file to disk and look for the string "action" in a text editor.

[Zverikk]

Replying to bastiK:

I'm quite sure that whatever you are doing when editing a lot of objects for a long time can also be done with few objects and in short time, you "just" have to isolate the sequence of actions that trigger the bug.

Of course. Or there may be some stack overflow problems. I'll check it later. For now I can say that this bug appeared between builds 3400 and 3480.

[vsandre]

Replying to bastiK:

I'm quite sure that whatever you are doing when editing a lot of objects for a long time can also be done with few objects and in short time, you "just" have to isolate the sequence of actions that trigger the bug.

I did that way Zverikk did. And the problem occurs again. But until now I am not able to tell you the exact steps to reproduce it.

Could be, that for some reason, after upload, there are still modified objects in the data layer. So it might be interesting to search for "modified" in such a situation. Also save file to disk and look for the string "action" in a text editor.

modified objects via josm search: no
action string in saved file: no

But layers information shows me that I have deleted some nodes and ways.

[Zverikk]

After a 4-hour editing session I've uploaded everything to server, but state was not reset. There is no "action"/"modified" strings in saved .osm file. But properties window tells that there are "8703 nodes (13 deleted); 1818 ways (3 deleted); 5 relations; API 0.6". Probably some deleted nodes are not accounted for. I'm attaching "saved-modified-osm.zip" with .osm file for you to check.

[bastiK]

(In [3541]) fixed #5397 - Modified state is not reset after save/commit

[bastiK]

Thanks for the additional info. The problem shows up, when you create new objects and delete them afterwards.