Modify

Opened 15 years ago

Closed 15 years ago

#5101 closed defect (fixed)

Livegps incompatible to gpsd 2.92

Reported by: weller@… Owned by: framm
Priority: normal Milestone:
Component: Plugin livegps Version: latest
Keywords: livegps, gpsd Cc: framm

Description

Hi!
Today I wanted to do some mapping using josm with Live-GPS (Version
20431) and surveyor (Version 19681) plugin.

I use Ubuntu 10.04 with josm-latest (Revision: 328) - it connects to
gpsd but after some time it simply disconnects.

This is the console output:

LiveGps tries to connect to gpsd
LiveGps: Connected to gpsd
LiveGps: Disconnected from gpsd}}

Here some extract from gpsd's logfile:
gpsd: client 127.0.0.1 (0) connect on fd 7
gpsd: => client(0):
{"class":"VERSION","release":"2.92","rev":"svn","proto_major":3,"proto_minor":1}

gpsd: checking client(0)
gpsd: <= client(0): w
gpsd: => client(0): =
[....]
gpsd: client(0) timed out before assignment request.
gpsd: detaching 127.0.0.1 (sub 0, fd 7) in detach_client

For me it seems livegps issues the wrong command: gpsd simply receives a
"w" - please refer to http://gpsd.berlios.de/client-howto.html - it
should be something like "?WATCH={"enable":true,"json":true}"...

See line 143 of LiveGpsAcquirer.java:
new byte[] { 'w', 13, 10 });

Anyone can confirm a working livegps plugin with gpsd 2.92?

Regards,

Andreas Weller

Attachments (0)

Change History (13)

comment:1 by anonymous, 15 years ago

Ticket #5014 has been marked as a duplicate of this ticket.

comment:2 by anonymous, 15 years ago

Very likely an interface change in gpsd. They probably turned of some compatibility code. Could you provide an update? Depending on the fact how long the new interface exists there must be a workaround in livegps plugin or not.

in reply to:  2 comment:3 by anonymous, 15 years ago

Replying to anonymous:

Very likely an interface change in gpsd. They probably turned of some compatibility code. Could you provide an update? Depending on the fact how long the new interface exists there must be a workaround in livegps plugin or not.

Please see http://gpsd.berlios.de/protocol-transition.html#_how_the_command_set_has_changed

in reply to:  2 comment:4 by anonymous, 15 years ago

Priority: normalcritical

Replying to anonymous:

Depending on the fact how long the new interface exists there must be a workaround in livegps plugin or not.

AFAIK the code changed in dec. 2009 and the backwards compatibility was removed in march 2010...

comment:5 by stoecker, 15 years ago

Removing outside world interfaces after 4 months? This is more than strange. 2 years would have been appropriate. So we need a workaround and support old as well as new variant.

comment:6 by stoecker, 15 years ago

The question is what happens when we send first the "w" command and directly afterwards the new one. As the return is not checked anyway that may solve this issue.

in reply to:  5 comment:7 by anonymous, 15 years ago

Replying to stoecker:

Removing outside world interfaces after 4 months? This is more than strange. 2 years would have been appropriate. So we need a workaround and support old as well as new variant.

That's simply not true - the change had first been announced abt. 2006/07

I suggest to completely discard the old protocol handler as gpsd will only support the new JSON interface starting with version 3.0

comment:8 by framm, 15 years ago

Priority: criticalnormal

I think it doesn't matter. Fact is, it's broken and somebody has to fix it. This ticket means exactly that - it's broken and somebody has to fix it. Now let's wait until somebody fixes it. I'm also downgrading to normal because while critical to the livegps plugin this is not critical to JOSM as a whole.

If you read this and are capable of Java programming, please fix it and submit a patch.

comment:9 by stoecker, 15 years ago

Dropping old interface is no option. There are too many old installations around (e.g. mine) who can't update so easily. As already said - 4 months is much to little time. Java 6 was released 4 years ago and JOSM switching to Java6 makes more trouble than worth the effort.

comment:10 by stoecker, 15 years ago

Component: PluginPlugin livegps
Owner: changed from team to framm

comment:12 by stoecker, 15 years ago

See [o21622].

comment:13 by glebius, 15 years ago

Resolution: fixed
Status: newclosed

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain framm.
as The resolution will be set.
The resolution will be deleted. Next status will be 'reopened'.

Add Comment


E-mail address and name can be saved in the Preferences .
 
Note: See TracTickets for help on using tickets.