Modify

Opened 5 years ago

Closed 5 years ago

#507 closed defect (fixed)

The path for waypoint links is composed erronously

Reported by: RaSchu Owned by: framm
Priority: major Component: Core
Version: latest Keywords:
Cc:

Description

If a gpx-file "abc.gpx" contains the following lines

  <wpt lat="54.47613000" lon="9.78714500">
    <ele>47.50000000</ele>
    <name>Beginn des Trampelpfads</name>
    <time>2007-11-11T11:25.06Z</time>
    <link href="voice.wav"/>
  </wpt>

JOSM composes a path like ".../abc.gpx/voice.wav" - which isn't (usually) a valid path.

Attachments (1)

marker_link.diff (725 bytes) - added by anonymous 5 years ago.
patch to fix this bug

Download all attachments as: .zip

Change History (6)

comment:1 Changed 5 years ago by RaSchu

I edited my local copy of the josm sources to get a workaround for this situation.

I changed line 91 of .../gui.layer.markerlayer/Marker.java

from

uri = new File(relativePath, uri).toURI().toString();

to

uri = new File(relativePath.getParentFile(), uri).toURI().toString();

comment:2 Changed 5 years ago by anonymous

  • Version set to latest

I've just tried to use audio waypoints today, and hit the same problem.
It would be very nice to have a fix for this commited.
If you prefer patches, I just attach the above mentionned change as a
unified diff file.

Changed 5 years ago by anonymous

patch to fix this bug

comment:3 Changed 5 years ago by dodi@…

this one is related to http://josm.openstreetmap.de/ticket/570, could it be fixed too

Thanx. Dodi

comment:4 Changed 5 years ago by anonymous

No it's not.
This bug is trivial to reproduce and trivial to fix.
It's sad that no one had a look at it in a month and a half.

comment:5 Changed 5 years ago by tom_evans_a at yahoo co uk

  • Resolution set to fixed
  • Status changed from new to closed

Applied in r576.

I can't see how the code ever did work, which makes me slightly nervous, but it does appear to need fixing.

Add Comment

Modify Ticket

Change Properties
<Author field>
Action
as closed .
as The resolution will be set. Next status will be 'closed'.
The resolution will be deleted. Next status will be 'reopened'.
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.