NPE when dragging virtual node

[dieterdreist]

Repository Root: http://josm.openstreetmap.de/svn Build-Date: 2009-11-09 02:31:34 Last Changed Author: Gubaer Revision: 2417 Repository UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b URL: http://josm.openstreetmap.de/svn/trunk Last Changed Date: 2009-11-09 01:03:08 +0100 (Mon, 09 Nov 2009) Last Changed Rev: 2417

Memory Usage: 142 MB / 1016 MB (11 MB allocated, but free) Java version: 1.6.0_0

Plugins: AddrInterpolationAgPifoJCreate_grid_of_waysDirectUploadbuildings_toolscolorschemedataimporteditgpxgraphviewmeasurementmultipolyopenvisibleosmarenderremotecontrolroutingterracerutilspluginvalidatorwalkingpaperswaydownloaderwmsplugin Plugin AddrInterpolation Version: 18503 Plugin AgPifoJ Version: 18287 Plugin Create_grid_of_ways Version: 17367 Plugin DirectUpload Version: 17532 Plugin buildings_tools Version: 24 Plugin colorscheme Version: 18413 Plugin dataimport Version: 18071 Plugin editgpx Version: 18426 Plugin graphview Version: 18415 Plugin measurement Version: 17377 Plugin multipoly Version: 18415 Plugin openvisible Version: 17536 Plugin osmarender Version: 18480 Plugin remotecontrol Version: 18503 Plugin routing Version: 18415 Plugin terracer Version: 17874 Plugin utilsplugin Version: 18503 Plugin validator Version: 18524 Plugin walkingpapers Version: 18484 Plugin waydownloader Version: 18503 Plugin wmsplugin Version: 18408

java.lang.NullPointerException

at org.openstreetmap.josm.command.MoveCommand.executeCommand(MoveCommand.java:94) at org.openstreetmap.josm.command.SequenceCommand.executeCommand(SequenceCommand.java:51) at org.openstreetmap.josm.data.UndoRedoHandler.addNoRedraw(UndoRedoHandler.java:39) at org.openstreetmap.josm.data.UndoRedoHandler.add(UndoRedoHandler.java:59) at org.openstreetmap.josm.actions.mapmode.SelectAction.mouseDragged(SelectAction.java:217) at java.awt.AWTEventMulticaster.mouseDragged(AWTEventMulticaster.java:320) at java.awt.Component.processMouseMotionEvent(Component.java:6156) at javax.swing.JComponent.processMouseMotionEvent(JComponent.java:3294) at java.awt.Component.processEvent(Component.java:5877) at java.awt.Container.processEvent(Container.java:2105) at java.awt.Component.dispatchEventImpl(Component.java:4469) at java.awt.Container.dispatchEventImpl(Container.java:2163) at java.awt.Component.dispatchEvent(Component.java:4295) at java.awt.LightweightDispatcher.retargetMouseEvent(Container.java:4461) at java.awt.LightweightDispatcher.processMouseEvent(Container.java:4142) at java.awt.LightweightDispatcher.dispatchEvent(Container.java:4055) at java.awt.Container.dispatchEventImpl(Container.java:2149) at java.awt.Window.dispatchEventImpl(Window.java:2478) at java.awt.Component.dispatchEvent(Component.java:4295) at java.awt.EventQueue.dispatchEvent(EventQueue.java:604) at java.awt.EventDispatchThread.pumpOneEventForFilters(EventDispatchThread.java:275) at java.awt.EventDispatchThread.pumpEventsForFilter(EventDispatchThread.java:200) at java.awt.EventDispatchThread.pumpEventsForHierarchy(EventDispatchThread.java:190) at java.awt.EventDispatchThread.pumpEvents(EventDispatchThread.java:185) at java.awt.EventDispatchThread.pumpEvents(EventDispatchThread.java:177) at java.awt.EventDispatchThread.run(EventDispatchThread.java:138)

[Gubaer]

(In [2435]) see #3892: can't reproduce but added two assert statement in case it happens again.

[Gubaer]

Closing. Reopen if it happens again and attach the stack trace from the assertion failure and the dataset.

[mjulius]

Ticket #4529 has been marked as a duplicate of this ticket.

[mjulius]

There it was again.

I guess the assertions are not evaluated.

[bastiK]

(In [3172]) make assertions work (see #3892)

[bastiK]

Ticket #4863 has been marked as a duplicate of this ticket.

[bastiK]

See #4845 and #4898.

[anonymous]

Ticket #4898 has been marked as a duplicate of this ticket.

[jttt]

(In [3253]) See #3892: NPE when dragging virtual node (further debugging info)

[bastiK]

Interesting bug...

It's quite easy to verify that it cannot exist, albeit it comes frequently (but not reproducibly) and in many variations.

[jttt]

Not in many variations - it always come from SelectionAction.mouseDragged and it's usually null eastNorth. Only in one case (#4845) was the node added to the dataset twice.

#4845 might happen if SelectAction.mouseDragged is called twice at the same time. NPE might happen if projection returns null for east north or when Main.proj is null for some time.

But none of these three causes should be possible.

[bastiK]

Ticket #4845 has been marked as a duplicate of this ticket.

[Upliner]

Error with null coordinates in buildings_tools

[Upliner]

Error appeared again while using buildings_tools plugin. It's really simple plugin and it's easy to make sure that it cannot create a node with null coordinates. Situation looks like a race condition. Is dataset system multithreaded?

[bastiK]

Application of filters is in different thread (edt). (See #3475, for the time line when it was introduced; #4861 for some of the thread issues - they were partly fixed/hidden; #5018 for remaining issues (see also duplicates))

But maybe it's a totally unrelated issue.

[anonymous]

Ticket #5161 has been marked as a duplicate of this ticket.

[Wim Lewis <wiml@…>]

This just happened to me again, circumstances the same as #4898. Running ver 3359 on OSX/10.6.2.

org.openstreetmap.josm.data.osm.DataIntegrityProblemException: Complete node with null coordinates: {Way id=-2261 version=0 MV nodes=[{Node id=-2259 version=0 V lat=47.578432112368745,lon=-122.31738002678352}, {Node id=-2260 version=0 V lat=47.57832478113313,lon=-122.31758885603452}, {Node id=-2262 version=0 V lat=47.57736976648906,lon=-122.31763019774887}, {Node id=-2264 version=0 V lat=47.57736725086471,lon=-122.31744125699795}, {Node id=-2269 version=0 V lat=47.57760609153897,lon=-122.31741417494008}, {Node id=-2267 version=0 MV lat=47.577841929721195,lon=-122.31738115692232}, {Node id=-2259 version=0 V lat=47.578432112368745,lon=-122.31738002678352}]}Unexpected error. Please report it to http://josm.openstreetmap.de/ticket/3892
{Node id=-2269 version=0 V lat=47.57760609153897,lon=-122.31741417494008}
EastNorth: EastNorth[e=-2.1348416098782876, n=0.946494097812089]
Mercator

	at org.openstreetmap.josm.data.osm.Way.checkNodes(Way.java:431)
	at org.openstreetmap.josm.data.osm.Way.fireNodesChanged(Way.java:438)
	at org.openstreetmap.josm.data.osm.Way.setNodes(Way.java:65)
	at org.openstreetmap.josm.data.osm.Way.cloneFrom(Way.java:242)
	at org.openstreetmap.josm.command.ChangeCommand.executeCommand(ChangeCommand.java:43)
	at org.openstreetmap.josm.command.SequenceCommand.executeCommand(SequenceCommand.java:53)
	at org.openstreetmap.josm.data.UndoRedoHandler.addNoRedraw(UndoRedoHandler.java:37)
	at org.openstreetmap.josm.data.UndoRedoHandler.add(UndoRedoHandler.java:59)
	at org.openstreetmap.josm.actions.mapmode.SelectAction.mouseDragged(SelectAction.java:214)
	at java.awt.AWTEventMulticaster.mouseDragged(AWTEventMulticaster.java:303)
	at java.awt.Component.processMouseMotionEvent(Component.java:6396)
	at javax.swing.JComponent.processMouseMotionEvent(JComponent.java:3273)
	at java.awt.Component.processEvent(Component.java:6117)
	at java.awt.Container.processEvent(Container.java:2085)

[anonymous]

Ticket #5313 has been marked as a duplicate of this ticket.

[bastiK]

Ticket #5211 has been marked as a duplicate of this ticket.

[malenki]

Please report it to http://josm.openstreetmap.de/ticket/3892[[BR]] done

Last steps before this error occured: added some ways to a relation and removed some other, not intersectings ways from the relation. Then as I pressed ctrl-f the exception occured

org.openstreetmap.josm.data.osm.DataIntegrityProblemException: Complete node with null coordinates: {Node id=-253937 version=0 V }Unexpected error. Please report it to http://josm.openstreetmap.de/ticket/3892
{Node id=-253937 version=0 V }
Coor is null

	at org.openstreetmap.josm.data.osm.Node.setDataset(Node.java:132)
	at org.openstreetmap.josm.data.osm.DataSet.addPrimitive(DataSet.java:257)
	at org.openstreetmap.josm.data.osm.DataSet.getPrimitiveById(DataSet.java:627)
	at org.openstreetmap.josm.command.AddPrimitivesCommand.executeCommand(AddPrimitivesCommand.java:30)
	at org.openstreetmap.josm.data.UndoRedoHandler.addNoRedraw(UndoRedoHandler.java:37)
	at org.openstreetmap.josm.data.UndoRedoHandler.add(UndoRedoHandler.java:59)
	at org.openstreetmap.josm.actions.PasteAction.pasteData(PasteAction.java:147)
	at org.openstreetmap.josm.actions.PasteAction.actionPerformed(PasteAction.java:42)
	at javax.swing.SwingUtilities.notifyAction(SwingUtilities.java:1633)
	at javax.swing.JComponent.processKeyBinding(JComponent.java:2851)
	at javax.swing.KeyboardManager.fireBinding(KeyboardManager.java:267)
	at javax.swing.KeyboardManager.fireKeyboardAction(KeyboardManager.java:216)
	at javax.swing.JComponent.processKeyBindingsForAllComponents(JComponent.java:2928)
	at javax.swing.JComponent.processKeyBindings(JComponent.java:2920)
	at javax.swing.JComponent.processKeyEvent(JComponent.java:2814)
	at java.awt.Component.processEvent(Component.java:6044)
	at java.awt.Container.processEvent(Container.java:2041)
	at java.awt.Component.dispatchEventImpl(Component.java:4630)
	at java.awt.Container.dispatchEventImpl(Container.java:2099)
	at java.awt.Component.dispatchEvent(Component.java:4460)
	at java.awt.KeyboardFocusManager.redispatchEvent(KeyboardFocusManager.java:1850)
	at java.awt.DefaultKeyboardFocusManager.dispatchKeyEvent(DefaultKeyboardFocusManager.java:712)
	at java.awt.DefaultKeyboardFocusManager.preDispatchKeyEvent(DefaultKeyboardFocusManager.java:990)
	at java.awt.DefaultKeyboardFocusManager.typeAheadAssertions(DefaultKeyboardFocusManager.java:855)
	at java.awt.DefaultKeyboardFocusManager.dispatchEvent(DefaultKeyboardFocusManager.java:676)
	at java.awt.Component.dispatchEventImpl(Component.java:4502)
	at java.awt.Container.dispatchEventImpl(Container.java:2099)
	at java.awt.Window.dispatchEventImpl(Window.java:2478)
	at java.awt.Component.dispatchEvent(Component.java:4460)
	at java.awt.EventQueue.dispatchEvent(EventQueue.java:599)
	at java.awt.EventDispatchThread.pumpOneEventForFilters(EventDispatchThread.java:269)
	at java.awt.EventDispatchThread.pumpEventsForFilter(EventDispatchThread.java:184)
	at java.awt.EventDispatchThread.pumpEventsForHierarchy(EventDispatchThread.java:174)
	at java.awt.EventDispatchThread.pumpEvents(EventDispatchThread.java:169)
	at java.awt.EventDispatchThread.pumpEvents(EventDispatchThread.java:161)
	at java.awt.EventDispatchThread.run(EventDispatchThread.java:122)

[malenki]

(btw: JOSM version 3438)

followed by

Autosave failed: 
java.lang.NullPointerException
	at org.openstreetmap.josm.io.OsmWriter.visit(OsmWriter.java:117)
	at org.openstreetmap.josm.io.OsmWriter.writeContent(OsmWriter.java:84)
	at org.openstreetmap.josm.io.OsmExporter.save(OsmExporter.java:74)
	at org.openstreetmap.josm.io.OsmExporter.exportData(OsmExporter.java:44)
	at org.openstreetmap.josm.data.AutosaveTask.savelayer(AutosaveTask.java:156)
	at org.openstreetmap.josm.data.AutosaveTask.run(AutosaveTask.java:172)
	at java.util.TimerThread.mainLoop(Timer.java:512)
	at java.util.TimerThread.run(Timer.java:462)

[bastiK]

No reports for 1 year, let's hope it is fixed.

[Don-vip]

Ticket #5252 has been marked as a duplicate of this ticket.