Default to GTK look and feel on Linux systems

[anonymous]

Josm currently uses the Java metal look and feel by default on Linux. In the interest of UI consistency with other applications, I've written a patch to make it default to the GTK+ look and feel on Linux.

This bug was initially reported on Launchpad, but #441619, here:
​https://bugs.launchpad.net/ubuntu/+source/josm/+bug/441619

[mathieu.tl@…]

default laf to GTK on Linux

[mathieu.tl@…]

My bad, forgot to set the email when reporting the bug.

[xeen]

Can we really assume that "WINDOWS" or "LINUX" are at the beginning of the OS string? Old version searched for it anywhere in the string, so can either verfiy or modify the patch please?

[stoecker]

Actually that check should be moved to the OS hooks completely!

[stoecker]

Cleanup in r2371. WONTFIX, as GTK style wastes too much space especially in sidebar.

[avarab@…]

Replying to stoecker:

Cleanup in r2371. WONTFIX, as GTK style wastes too much space especially in sidebar.

I think the GTK+ style looks crappy since it's a bad emulation of a proper GTK look, but on my system/GTK versions does it use too much space?

On my GTK (2.16.1-0ubuntu2) the toolbar which contains 21 icons and 7 spacers is horizontally wider by the equivalent of 1/2 a single icon width under GTK.

Under GTK the sidebar icons take up the equivalent of 1/10 (or less) icon space vertically and horizontally the GTK sidebar takes up noticeably less space, leaving more for the map area.

Perhaps you're using some unusual GTK+ skin that takes up too much space?

[avarab@…]

Replying to avar:

Replying to stoecker:

Cleanup in r2371. WONTFIX, as GTK style wastes too much space especially in sidebar.

I think the GTK+ style looks crappy since it's a bad emulation of a proper GTK look, but on my system/GTK versions does it use too much space?

Should be "but on what system..."

[avarab@…]

JOSM default style

[avarab@…]

JOSM gtk style

[bastiK]

The GTK laf integrates much better for me. (I have a custom skin.)

I would like to have it as default, as well.

However I don't know how KDE users feel about it...

[bastiK]

(In [2391]) improved Toolbar to the left:

• removed strange left margin (in Metal L&F, see #3721: josm-default.png)
• show scroll-buttons only if necessary
• allow mousewheel scrolling

[Candid Dauth]

Hm, the GTK look does not really work here in JOSM 2255. All GUI elements have no borders, so I cannot see where I can click. Some GUI elements such as arrows aren’t displayed either.

[simon04]

I personally prefer the Metal L&F and I don't see a big deal as the L&F can easily be configured. I'd stick to the current selection.