Would like to see waypoint descriptions in JOSM

[burkhardm]

Dear JOSM developers,

before I start mapping something in JOSM, I import .gpx tracks from my Garmin GPS using GPS Babel. Then I load the .gpx file into JOSM. It nicely displays both the track and the waypoints. However the waypoint descriptions that I entered into the device during my mapping tour are not visible. While working in JOSM, I usually have the .gpx file open in my text editor to view the descriptions, i.e. the <cmt> / <desc> elements (content seems to be identical), like in this example:

<wpt lat="48.001691625" lon="10.355957877">

<ele>618.729492</ele> <name>441</name> <cmt>26-SEP-09 16:03:25Abtwiler Str</cmt> <desc>26-SEP-09 16:03:25Abtwiler Str</desc> <sym>Flag, Blue</sym>

</wpt>

I'd like to see these descriptions in JOSM so that I wouldn't need to work with my text editor in parallel anymore.

I'm currently using version 1981.

Best Regards,

Burkhard

[reini122]

Hello! I'm new to JOSM but I am a programmer and i implemented the feature you wanted because i would like to have it too.

I added an property to set what is displayed. Possible values for property "draw.gpx.layer.wpt" are: * nameordesc: default and it represents the current behaviour. It displays name or if there is no name desc. * name: displays only the name attribute * desc: displays only the desc attribute * both: display the name and the desc attribute (desc in parenthesis) * none: displays no name for the waypoint

If you would like to get a test-version please contact me.

I'll add the diff to this ticket.

[bastiK]

(In [3386]) applied #3617 (patch by reini122) - display waypoint descriptions in JOSM

[burkhard.meier@…]

Thank you for the change!

I have just tested it and it works fine. Personally I will be OK with setting a property for this. The problem may be that the property is (as it seems) not documented in the JOSM GUI and will be unknown for most people. It would be nice if it could be configured in JOSM's display properties dialog, in the tab for GPS track properties.

Therefore I'm reopening the ticket in the hope that someone will also make the new feature configurable in the Preferences dialog (in another way than adding the property)

One more thing I'm wondering: there are some properties named draw.rawgps.*. Shouldn't the new property be added to this category instead of draw.gpx (which I don't see in the list on JOSM at least)?

[anonymous]

I confirm to you. I've already looked where i can document this feature but I didn't find something. I'll look if I can add this property to the GUI. Then I will rename it to draw.rawgps - the "old" name of the property is not very elaborate.

[bastiK]

Wouldn't it be more useful to improve the default behaviour? E.g. change mode 'nameordesc' to 'auto' where it shows both name and description unless one is a substring of the other.

[bastiK]

PS: Might be good to check if name or desc is the same for all waypoints and then don't show it.

[burkhard.meier@…]

I would be fine with changing the default behaviour too, if there is a good one that covers most cases.

The "one is a substring of the other" condition could cause problems, e.g.: name="10" description="2010/07/30 10:39 blabla" - 10 is a substring of 2010 (on my garmin device the description contains the timestamp by default)

[reini122]

I agree with bastiK, only check if name or desc is the same and then only show one of them in mode auto/nameordesc.

[bastiK]

Replying to burkhard.meier@…:

I would be fine with changing the default behaviour too, if there is a good one that covers most cases. The "one is a substring of the other" condition could cause problems, e.g.: name="10" description="2010/07/30 10:39 blabla" - 10 is a substring of 2010 (on my garmin device the description contains the timestamp by default)

Good point, check for equality should be enough then.

[reini122]

Hey Guys! I've done some changes: * Added the option to change the property in the preferences-dialog * Implemented the "Auto"-Feature and removed the "nameordesc"-Feature * Changed the property name to "draw.rawgps.layer.wpt"

[bastiK]

Either it should update the painting without restart or it should give a warning that restart is required (-> return value for ok() method). Most settings on this page work without restart, so the first option is preferred.

Also, it would be better to apply the whitespace coding standard that is used in JOSM, e.g. no tabs, no space after opening parenthesis and put opening brace at the end of the previous line.

[reini122]

Ok, thank you for the feedback.

I've realized the rapainting freature - so if the option in the preferences is changed, you'll see the change instantly after closing the dialog.

The patch is based on the checked in version - so the other patch (WaypointConfigurableTextPreferences.patch) should be ignored/deleted.

[reini122]

I replaced the old patch - so please use only the new one.

PS: Thank you for the info with the blanks/tabs - i replaced all my tabs with blanks and changed the settings in my IDE. I hope my code style is OK now.

[bastiK]

(In [3396]) applied #3617 (patch by reini122) - Would like to see waypoint descriptions in JOSM

[bastiK]

Replying to reini122:

PS: Thank you for the info with the blanks/tabs - i replaced all my tabs with blanks and changed the settings in my IDE. I hope my code style is OK now.

It's not that important, but it is a little cumbersome to go through each line and fix the formatting. :)

[reini122]

Hey bastiK! I think you forgot to commit the if-statement DrawingPreference.java.

[bastiK]

I haven't investigated, but apparently it gets a repaint somewhere else. Otherwise, all the other options on that page would not update.

If tests show, that it is necessary, i can add it back.