[PATCH] arange orthogonal not working

[MichaelK_OSM@…]

Hello,

I think this is plugin issue but I'm not shure which one is causing the problem.
On my user page (​http://wiki.openstreetmap.org/wiki/User:MichaelK#Software_used_for_OSM) you can find all the plugings I have installed.
I use German language settings, so the description in English is a litte bit difficult => I'll add the german information too.

System: WinXP, JOSM 1788, plugins: "up to date by about August 1st" and appropriate to JOSM1788

Pproblem:
I use the function to make objects orthogonal within tools (Werkzeug | Form rechtwinklig machen). The function complained about "Bitte Funktion mit nahezu rechten Winkeln zum rechtwinklig machen auswählen".

My action:
In my case I was updating a big bilding which has some ways connected to: adding more details (additional corners due to availability of better aerial imagery).

What I found out: (preanalysis)
the problem are the nodes which connected the ways to that building.

Work around:

• select the node which connects the way to the building
• tools | seperate ways (Werkzeug | Wege trennen)
• remove the node which belongs to the building
• make the building orthogonal
• tools | add node to way (Werkzeug | Knoten in Weg einfügen)

=> very uncomfortable and long way to go... :-(

How to reproduce:

• draw a rectangle with 4 nodes
• add an additional node in one of the sides
• select the rectangle
• select tools | ???make rectangleous ??? (Werkzeug | Form rechtwinklig machen)

=> the error message appears (Bitte Funktion mit nahezu rechten Winkeln zum rechtwinklig machen auswählen.)

Idea for a fix (improvement)

• if a node with ways of of an angle of about 180 degree is detected, the function should make the ways at this node to 180 degree (new).
• if a node with ways of of an angle of about 90 or 270 degree is detected, the function should make the ways at this node to 90 or 270 degree (like already OK).

Benefit for the user:
also shapes with additional nodes in the lines can be processed withought big effort.

If you have additional questions (or maybe need a tester for the fix) feel free to contact me via MichaelK_OSM@….

Best regrads,
Michael.

[Gubaer]

OrthogonalizeAction is an action in the core, as far as I can see -> chaning to component core.

Idea for a fix (improvement) - if a node with ways of of an angle of about 180 degree is detected, the function should make the ways at this node to 180 degree (new).

This sounds reasonable. I stumbled across this warning myself when I was "mass procuding" houses in my home town but I didn't dig into it so far.

[dmuecke]

Should be working now.

[stoecker]

(In [2014]) fixed #3205 - patch by dmuecke - arrange orthogonal not working