Modify

Opened 4 years ago

Closed 4 years ago

#2856 closed defect (invalid)

[PATCH] CrossingWays.java incorrectly showing errors

Reported by: delta_foxtrot2 Owned by: delta_foxtrot2
Priority: major Component: Core validator
Version: Keywords:
Cc: delta_foxtrot@…

Description

CrossingWays and OverlappingWays select ways like boundary=administrative and treat them like highways and railways and throw warnings as a result.

I'm currently trying to code a patch for this.

Attachments (0)

Change History (7)

comment:1 Changed 4 years ago by delta_foxtrot2

  • Cc delta_foxtrot@… added

comment:2 Changed 4 years ago by delta_foxtrot2

  • Summary changed from CrossingWays.java and OverlappingWays.java incorrectly showing errors to [PATCH] CrossingWays.java incorrectly showing errors

The overlap error after considering it further is probably valid, however to fix the crossingway error, CrossingWays.java file just needs the following line of code about line 109:

if(es2.ws.way.get("boundary") != null && es2.ws.way.get("highway") == null && railway2 == null && !isCoastline2) continue;

comment:3 Changed 4 years ago by stoecker

  • Owner changed from team to delta_foxtrot2
  • Status changed from new to needinfo

I'm not sure you're right here. Show an example.

comment:4 Changed 4 years ago by anonymous

A lot of ABS (Australian Bureau of Statistics) boundaries were imported earlier this year, ABS boundaries are for census and other statistic purposes and aren't ways of any sort and shouldn't be treated like a way.

However when you get one of their administrative boundaries crossing ways it's reported as a warning. I'm trying to locate the issue I saw before, I should have included it in the original bug report.

comment:5 Changed 4 years ago by anonymous

If you don't want to exclude all boundaries, a boundary=administrative check would achieve the same thing that the code I posted previously does.

comment:6 Changed 4 years ago by stoecker

Actually the code will not take "boundary" into account at all. There must be another issue which causes this problem.

comment:7 Changed 4 years ago by delta_foxtrot2

  • Resolution set to invalid
  • Status changed from needinfo to closed

I'm looking over areas I thought this warning was being triggered, but I'm unable to replicate it at the moment, as I said I should have posted the original URL in the ticket, I'll re-open if I find an example.

Add Comment

Modify Ticket

Change Properties
<Author field>
Action
as closed .
as The resolution will be set. Next status will be 'closed'.
The resolution will be deleted. Next status will be 'reopened'.
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.