nullpointerexception when downloading osm data around track

[pweemeeuw@…]

steps:

• start up osm
• load gpx track (2.2 M)
• select download from osm along this track (various settings: 50m around track, 50 sq km)

observed both for latest @ 20090628 and version 1566
on 901 eee pc (1 Mb memory; ubuntu 0904)

Path: trunk
URL: ​http://josm.openstreetmap.de/svn/trunk
Repository Root: ​http://josm.openstreetmap.de/svn
Repository UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b
Revision: 1708
Node Kind: directory
Last Changed Author: stoecker
Last Changed Rev: 1708
Last Changed Date: 2009-06-27 15:59:15 +0200 (Sat, 27 Jun 2009)

Memory Usage: 50 MB / 508 MB (19 MB allocated, but free)
Java version: 1.6.0_0

Plugins: colorschemelivegpsroutingslippymapsurveyorusertoolsutilspluginvalidator
Plugin colorscheme Version: 14233
Plugin livegps Version: 14120
Plugin routing Version: 14404
Plugin slippymap Version: 14015
Plugin usertools Version: 14125
Plugin utilsplugin Version: 14356
Plugin validator Version: 14123
Plugin surveyor Version: 14233

java.lang.NullPointerException

at java.awt.Container.createHierarchyEvents(Container.java:1415)
at java.awt.Container.createHierarchyEvents(Container.java:1415)
at java.awt.Container.createHierarchyEvents(Container.java:1415)
at java.awt.Container.createHierarchyEvents(Container.java:1415)
at java.awt.Dialog.conditionalShow(Dialog.java:959)
at java.awt.Dialog.show(Dialog.java:1061)
at java.awt.Component.show(Component.java:1464)
at java.awt.Component.setVisible(Component.java:1416)
at java.awt.Window.setVisible(Window.java:842)
at java.awt.Dialog.setVisible(Dialog.java:1011)
at org.openstreetmap.josm.gui.PleaseWaitRunnable$3.run(PleaseWaitRunnable.java:96)
at java.awt.event.InvocationEvent.dispatch(InvocationEvent.java:226)
at java.awt.EventQueue.dispatchEvent(EventQueue.java:602)
at java.awt.EventDispatchThread.pumpOneEventForFilters(EventDispatchThread.java:275)
at java.awt.EventDispatchThread.pumpEventsForFilter(EventDispatchThread.java:200)
at java.awt.EventDispatchThread.pumpEventsForHierarchy(EventDispatchThread.java:190)
at java.awt.EventDispatchThread.pumpEvents(EventDispatchThread.java:185)
at java.awt.EventDispatchThread.pumpEvents(EventDispatchThread.java:177)
at java.awt.EventDispatchThread.run(EventDispatchThread.java:138)

[anonymous]

forgot one step in the description above:
delete slippy map layer after loading the gpx track.
I can provide the gpx track as well, if needed.

[stoecker]

Yes, please provide track. But try updating plugins, restart and retry to produce bug before you do so. Some of them are outdated a lot.

[pweemeeuw@…]

I disabled all plugins, and reduced the gpx file to 3% of the original.
I chose the parameters: 1 sq km, withing 50m of track.
I attach the reduced gpx file that still exhibits the problem.

[pweemeeuw@…]

gpx fragment still exhibiting the problem

[jttt]

This is caused by PleaseWaitDlg being accessed from different threads at the same time.

I don't think we can make everybody use EventQueue.invokeLater when manipulating Main.pleasWaitDlg, so probably the dialog instance should be hidden and manipulation allowed only using prepared methods. Unfortunatelly that will require a lot of code refactoring (including plugins). At least BoundingBoxDownloader should be fixed as it has caused the exception in this case.

The bug is not related to download osm data around track, it's just coincidence that PleaseWaitDlg is used a lot in this function so probabily that this happen is higher.

[stoecker]

Actually currently is a good time for such a refactoring as most plugins have been broken anyway.

I once wanted to do that refactoring but then I had other things to do.

[jttt]

I'm working on a patch...

[jttt]

Ticket #2525 has been marked as a duplicate of this ticket.

[jttt]

Ticket #2943 has been marked as a duplicate of this ticket.

[jttt]

Ticket #2932 has been marked as a duplicate of this ticket.

[stoecker]

Ticket #2944 has been marked as a duplicate of this ticket.

[stoecker]

Ticket #2946 has been marked as a duplicate of this ticket.

[jttt]

Here is a patch that replaces Main.pleaseWaitDialog with ProgressMonitor interface. It will require changes in plugins and also something is probably broken as I had to change lots of files.

[anonymous]

Fixed in r1811