Modify

Opened 4 years ago

Closed 4 years ago

#2772 closed defect (fixed)

Conflict dialog doesn't go away when I delete my map layer

Reported by: avar Owned by: Gubaer
Priority: major Component: Core
Version: latest Keywords:
Cc: karl.guggisberg@…

Description

Steps to reproduce:

  • Load a map area
  • Edit
  • Download again
  • JOSM detects a conflict
  • I decide I don't want to deal with some conflict resolution dialog
  • Delete the map area
  • Download again
  • Edit
  • Conflict dialog remains showing unresolved conflicts

Attachments (0)

Change History (6)

comment:1 Changed 4 years ago by stoecker

  • Owner changed from team to Gubaer

comment:2 follow-up: Changed 4 years ago by Gubaer

  • Cc karl.guggisberg@… added
  • Resolution set to fixed
  • Status changed from new to closed

This is probably a feature, not a defect. What do you mean with "Delete the map area"? Do you

  1. select all elements
  2. press DEL or select the menu item Edit->Delete?

Even for elements deleted in this way there may be unresolved conflicts in the conflict resolution dialog, for instance if your node is deleted but has a lower version number than the node from the server (because another mapper updated the node in the meantime).

It is necessary you resolve these conflict manually because otherwise you would not be able to upload the deleted state of the node to the server where it then becomes "invisible".

There is, however, a slight modification of merge logic in r1699. It should generate less conflicts when downloading from the server into a local dataset with lots of deleted elements.

comment:3 in reply to: ↑ 2 Changed 4 years ago by avar

Replying to Gubaer:

This is probably a feature, not a defect. What do you mean with "Delete the map area"? Do you

  1. select all elements
  2. press DEL or select the menu item Edit->Delete?

No, I did not delete every object on the map. In that case it would have been expected that the conflict remained. Rather I deleted the map layer itself in the layer selection. Which should reset all conflicts, but didn't.

comment:4 Changed 4 years ago by stoecker

  • Resolution fixed deleted
  • Status changed from closed to reopened

This was there in previous versions also. Deleting all data layers should also remove all remaining conflicts.

comment:5 Changed 4 years ago by Gubaer

When you delete all data layers the remaining conflicts are gone too. But if you delete a data layer which was the source for a conflict and switch to another layer then the conflict is still there.

JOSM supports an arbitrary number of data layers with one data set each but one global set of conflicts only. Ouch! somebody will have to spend some time on this.

comment:6 Changed 4 years ago by Gubaer

  • Resolution set to fixed
  • Status changed from reopened to closed

fixed in r1750

Add Comment

Modify Ticket

Change Properties
<Author field>
Action
as closed .
as The resolution will be set. Next status will be 'closed'.
The resolution will be deleted. Next status will be 'reopened'.
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.