Modify

Opened 18 years ago

Closed 17 years ago

#262 closed enhancement (fixed)

Deleting a layer with modifications

Reported by: mihau Owned by: josm@…
Priority: major Milestone:
Component: Core Version: tested
Keywords: GUI, usability Cc:

Description

When deleting a layer containing modifications a warning message should be displayed - e.g. similar as the one when exiting the application (Unsaved changes/There are unsaved changes. Discard the changes and continue? Yes/No)

  • create a new layer
  • create some elements (e.g. nodes)
  • delete the layer => layer get's deleted without warning message

It happened to me twice by pressing delete button instead of hide.

Attachments (1)

josm-issue-262.diff (1.3 KB ) - added by dnaber 18 years ago.

Download all attachments as: .zip

Change History (5)

comment:1 by anonymous, 18 years ago

Resolution: wontfix
Status: newclosed

There is usually a confirmation dialog, it can be set to auto-hide by the user.

comment:2 by anonymous, 18 years ago

Resolution: wontfix
Status: closedreopened

The current confirmation appears whether or not the layer contains changes, and says nothing about the layer containing unsaved changes, or losing work if the changes are not uploaded.

This is different from the original request, which was to warn the user if the layer to be deleted contains changes, and that the changes will be lost if they do not upload them.

I do not think it is necessary to ask for confirmation when a layer that does not contain changes is deleted: if one accidentally deletes a layer that has no changes, no work has been lost—it can simply be downloaded again.

However, the confirmation is important if the layer contains changes, as work can be lost if a layer that contains changes is deleted before uploading.

by dnaber, 18 years ago

Attachment: josm-issue-262.diff added

comment:3 by dnaber, 18 years ago

I had the same problem. The attached patch now shows a confirmation dialog in case of changes. It's just like the dialog you get when you close the application, only I left out the "Some changes came from uploading new data to the server" part, as it's not clear to me what exactly that means.

comment:4 by anonymous, 17 years ago

Resolution: fixed
Status: reopenedclosed

Fixed in r745.

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain josm@….
as The resolution will be set.
The resolution will be deleted. Next status will be 'reopened'.

Add Comment


E-mail address and name can be saved in the Preferences .
 
Note: See TracTickets for help on using tickets.