Modify

Ticket #2234 (closed defect: fixed)

Opened 3 years ago

Last modified 21 months ago

Translation can cause JosmActions to illegally handle shortcuts

Reported by: stoecker Owned by: team
Priority: major Component: Core
Version: Keywords:
Cc:

Description

When titles are translated, the corresponding JosmActions can have equal names and the Main map shortcut handler is built using these names. This results in conflicts of these actions.

Solution: Either change storage or change all JosmAction to use marktr() and translate later. Second solution requires lots of code changes and probably breaks plugins.

Attachments

Change History

comment:1 Changed 21 months ago by jttt

  • Status changed from new to closed
  • Resolution set to fixed

(In [3227]) Fix #2234 Translation can cause JosmActions to illegally handle shortcuts

comment:2 Changed 21 months ago by jttt

  • Status changed from closed to reopened
  • Resolution fixed deleted

Fix reverted, some parts of JOSM relies on actions being saved by name in InputMap

comment:3 Changed 21 months ago by stoecker

Did you find a place where this happens. I searched, but could not really find these places.

comment:4 Changed 21 months ago by jttt

Escape is registered in UnselectAllAction.

I think proper fix for this issue will be replacing direct access to Main.contentPane by method, that takes action and shortcut and register them. Then it wouldn't matter how are actions stored internally.

comment:5 Changed 21 months ago by stoecker

Right. Sounds good.

comment:6 Changed 21 months ago by jttt

  • Status changed from reopened to closed
  • Resolution set to fixed

Fixed in r3252

View

Add a comment

Modify Ticket

Change Properties
<Author field>
Action
as closed
as The resolution will be set. Next status will be 'closed'
The resolution will be deleted. Next status will be 'reopened'
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.