Translation can cause JosmActions to illegally handle shortcuts

[stoecker]

When titles are translated, the corresponding JosmActions can have equal names and the Main map shortcut handler is built using these names. This results in conflicts of these actions.

Solution: Either change storage or change all JosmAction to use marktr() and translate later. Second solution requires lots of code changes and probably breaks plugins.

[jttt]

(In [3227]) Fix #2234 Translation can cause JosmActions to illegally handle shortcuts

[jttt]

Fix reverted, some parts of JOSM relies on actions being saved by name in InputMap

[stoecker]

Did you find a place where this happens. I searched, but could not really find these places.

[jttt]

Escape is registered in UnselectAllAction.

I think proper fix for this issue will be replacing direct access to Main.contentPane by method, that takes action and shortcut and register them. Then it wouldn't matter how are actions stored internally.

[stoecker]

Right. Sounds good.

[jttt]

Fixed in r3252