Opened 4 years ago
Closed 3 years ago
#2234 closed defect (fixed)
Translation can cause JosmActions to illegally handle shortcuts
| Reported by: | stoecker | Owned by: | team |
|---|---|---|---|
| Priority: | major | Component: | Core |
| Version: | Keywords: | ||
| Cc: |
Description
When titles are translated, the corresponding JosmActions can have equal names and the Main map shortcut handler is built using these names. This results in conflicts of these actions.
Solution: Either change storage or change all JosmAction to use marktr() and translate later. Second solution requires lots of code changes and probably breaks plugins.
Attachments (0)
Change History (6)
comment:1 Changed 3 years ago by jttt
- Resolution set to fixed
- Status changed from new to closed
comment:2 Changed 3 years ago by jttt
- Resolution fixed deleted
- Status changed from closed to reopened
Fix reverted, some parts of JOSM relies on actions being saved by name in InputMap
comment:3 Changed 3 years ago by stoecker
Did you find a place where this happens. I searched, but could not really find these places.
comment:4 Changed 3 years ago by jttt
Escape is registered in UnselectAllAction.
I think proper fix for this issue will be replacing direct access to Main.contentPane by method, that takes action and shortcut and register them. Then it wouldn't matter how are actions stored internally.
comment:5 Changed 3 years ago by stoecker
Right. Sounds good.
comment:6 Changed 3 years ago by jttt
- Resolution set to fixed
- Status changed from reopened to closed
Fixed in r3252
(In [3227]) Fix #2234 Translation can cause JosmActions to illegally handle shortcuts