Modify

Opened 4 years ago

Closed 4 years ago

#2124 closed defect (fixed)

AgPifoJ plugin: images not located

Reported by: guillaume.audirac@… Owned by: Christian Gallioz
Priority: minor Component: Plugin
Version: tested Keywords: AgPifoJ
Cc:

Description

Hello,

My pictures are not located with the plugin AgPifoJ. I checked the date and time of the points, as well as the EXIF data and they should match.
I am using the stable JOSM release 1344. I attach the relevant files.

Thanks,
Guillaume

Attachments (8)

dscf0001_2.jpg (54.1 KB) - added by guillaume.audirac@… 4 years ago.
one picture of my Holux for time reference (image size has been reduced)
Holux_M-241_Start_20090125-105419_Finish_20090125-110510.gpx (35.7 KB) - added by guillaume.audirac@… 4 years ago.
GPX trace
trace.gpx (35.7 KB) - added by guillaume.audirac@… 4 years ago.
Resend same trace file (other seems corrupted)
photo_for_trace.jpg (54.1 KB) - added by guillaume.audirac@… 4 years ago.
resend photo (other seems corrupted)
trace.2.gpx (35.7 KB) - added by guillaume.audirac 4 years ago.
trace_gpsbabel.gpx (38.0 KB) - added by guillaume.audirac@… 4 years ago.
GPX trace converted from KLM with GPSBabel
agpifoj range support.patch (4.9 KB) - added by xeen 4 years ago.
Uploading WIP so this doesn't get lost
Interval support for agpifoj (now without matching images twice).patch (7.3 KB) - added by xeen 4 years ago.
Likely my final version unless something else shows up.

Download all attachments as: .zip

Change History (20)

Changed 4 years ago by guillaume.audirac@…

one picture of my Holux for time reference (image size has been reduced)

Changed 4 years ago by guillaume.audirac@…

GPX trace

comment:1 Changed 4 years ago by Christian Gallioz

  • Owner changed from framm to Christian Gallioz

comment:2 follow-up: Changed 4 years ago by xeen

  • Priority changed from major to minor

The image you uploaded does not contain any EXIF information, it probably got lost during compressing. Also, your GPX track does not render at all for me… does it show up for you? It uses if different format than the one my GPS produces, maybe that's the reason?

comment:3 in reply to: ↑ 2 Changed 4 years ago by guillaume.audirac@…

Indeed, when I download the two files, both are corrupted. I try to attach them again.
For info, I checked the EXIF content with Gthumb. And the GPX file is converted from KML with GPSBabel.
Please have a look at the new attachments: trace.gpx and photo_for_trace.jpg
If there is still something wrong, please contact me by email and I can forward them.

Changed 4 years ago by guillaume.audirac@…

Resend same trace file (other seems corrupted)

Changed 4 years ago by guillaume.audirac@…

resend photo (other seems corrupted)

Changed 4 years ago by guillaume.audirac

comment:4 follow-up: Changed 4 years ago by GeoJ <geoj@…>

The picture has been taken on 2009:01:25 10:53:30 (local time) and the GPX file covers on 2009-01-25 the time from 05:24:19Z to 05:35:10Z.

For matching image and GPX trace you would have to live in the time zone GMT +5.5 is that right?

comment:5 in reply to: ↑ 4 Changed 4 years ago by anonymous

Replying to GeoJ <geoj@quantentunnel.de>:

For matching image and GPX trace you would have to live in the time zone GMT +5.5 is that right?

Perfectly right. I live in India (GMT + 5:30) for some time.
Could you please confirm that my GPX trace and JPG image are usable, because the files are corrupted when I download them.

comment:6 follow-up: Changed 4 years ago by xeen

Your photo's fine now, but I still can't open your GPX file though – I believe it's uploaded correctly but JOSM can't parse it. At least I can't see any GPX points or lines being drawn. Does that work for you? If so, could you mail me the GPX file to stefan@… so it doesn't get corrupted?

Changed 4 years ago by guillaume.audirac@…

GPX trace converted from KLM with GPSBabel

comment:7 in reply to: ↑ 6 Changed 4 years ago by anonymous

Replying to xeen:

Your photo's fine now, but I still can't open your GPX file though – I believe it's uploaded correctly but JOSM can't parse it. At least I can't see any GPX points or lines being drawn. Does that work for you? If so, could you mail me the GPX file to stefan@… so it doesn't get corrupted?

Ok, I have sent it to you. And I have now attached the GPX file converted with GPSBabel (trace_gpsbabel.gpx) as the others have been converted with the Holux Windows utility. Thanks in advance for your feedback.

comment:8 Changed 4 years ago by xeen

I've looked at the GPX file you sent me and for some reason the timestamps for the GPS points are only added as description/comment, but not in the normal time format one would expect. The only valid time stamp I can find dates on the 4th Feb this year (is this when you converted the file?).

I'll see what I can find out about the original file uploaded here.

Changed 4 years ago by xeen

Uploading WIP so this doesn't get lost

comment:9 follow-up: Changed 4 years ago by xeen

Apparently the problem was that AgPifoJ doesn't support ranges. E.g. if there's a GPS point at 12:23:40 and at 12:23:45 but the photo has been made at 12:23:42 it will not match the photo.

The patch adds the ability to detect intervals from the given GPX trace and chooses the best match automatically. No interpolation is done, so if the interval is set to 30 seconds and three photos are made in between all of them will be displayed at one GPS point (if AgPifoJ does that, I believe it skips if there is more than one photo to be displayed).

Still waiting for reply from the original poster to see if it really solves the problem.

comment:10 Changed 4 years ago by stoecker

Probably you should contact Christian here as well. I don't think he reads trac reports very often.

Changed 4 years ago by xeen

Likely my final version unless something else shows up.

comment:11 in reply to: ↑ 9 Changed 4 years ago by guillaume.audirac@…

Replying to xeen:

Still waiting for reply from the original poster to see if it really solves the problem.

I confirm the patched plugin solves the problem.
Thank you very much, Stefan.

comment:12 Changed 4 years ago by anonymous

  • Resolution set to fixed
  • Status changed from new to closed

In 13775.

Add Comment

Modify Ticket

Change Properties
<Author field>
Action
as closed .
as The resolution will be set. Next status will be 'closed'.
The resolution will be deleted. Next status will be 'reopened'.
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.