Modify ↓

Opened 3 years ago

Closed 3 years ago

Last modified 3 years ago

#20684 closed enhancement (fixed)

[Patch] add canal=qanat

Reported by: Don-vip Owned by: team
Priority: normal Milestone: 21.04
Component: Internal preset Version:
Keywords: canal qanat Cc: francois.lacombe

Description

Followup from https://josm.openstreetmap.de/ticket/20651#comment:5

What should we do about canal=qanat?

Attachments (1)

josm_20684_canal.patch​ (1.4 KB ) - added by skyper 3 years ago.
patch adding the subkey and some combo options

Download all attachments as: .zip

Change History (6)

comment:1 by francois.lacombe, 3 years ago

Hi Don-Vip

I'm ok with canal=qanat.
It's compatible with tunnel=flooded, waterway=canal so no problem

canal=* key would be completed later with another values.

In Josm, just add a combobox with qanat as the only possible value (or null obviously)

by skyper, 3 years ago

Attachment: josm_20684_canal.patch​ added

patch adding the subkey and some combo options

comment:2 by skyper, 3 years ago

Summary: add/ignore canal=qanat → [Patch] add canal=qanat

Please find attached patch file​ which adds the subkey and little combo options.

comment:3 by Klumbumbus, 3 years ago

Resolution: → fixed
Status: new → closed

In 17818/josm:

fix #20684 - Add canal=qanat combo box to waterway=canal preset (patch by skyper)

comment:4 by Klumbumbus, 3 years ago

Milestone: → 21.04

comment:5 by Klumbumbus, 3 years ago

numeric values like in layer are automatically not part of i18n

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain team.
as The resolution will be set.
The resolution will be deleted. Next status will be 'reopened'.

Add Comment
E-mail address and name can be saved in the Preferences .
Attachments ↑ Description ↑
 
Note: See TracTickets for help on using tickets.