Warn about building overlapping with building:part

[Klumbumbus]

follow up from ticket:16707#comment:14

[Klumbumbus]

In 16783/josm:

fix #19544 - Warn about building overlapping with building:part and revert r16779 (overlapping building:part)

[Davidleci]

I think there is a problem with empty spaces inside buildings like claustres, patios or courtyards. Editors usually use multipolygon relations with outer and inner members to map those structures instead building relations. However, in order to map buildings properly, a building part may be mapped with a multipolygon relation. If this happens, JOSM warns about overlapping buildings and wrong members with part role, as one can see on the Colosseum.

[GerdP]

Thanks for your report, however your ticket is incomplete and therefore not helpful in its current form.

Please add all needed information according to this list:

• The required parts of the Status Report from your JOSM.
  • Please, use Report Bug from Help menu and copy & paste.
• Describe what behaviour you expected.
• Describe what did happen instead.
• Describe if and how the issue is reproducible.
• Add any relevant information like error messages or screenshots.

To ensure that all technical relevant information is contained, create new tickets by clicking in JOSMs Main Menu on Help → Report Bug.

[Davidleci]

What steps will reproduce the problem?

1. Download the object of the relation ​6326618.
2. Download all the members within the members that are relations too.
3. Request validation errors.

What is the expected result?

No warning as the parent building relation is properly compounded.

What happens instead?

Warnings such as overlapping buildings when there is only one building or parts of the building relation that do not match her requirements.

Please provide any additional information below. Attach a screenshot if possible.

In multipolygon relations there are outers and inners; but in buldings relations there is outline and...

URL:https://josm.openstreetmap.de/svn/trunk
Repository:UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b
Last:Changed Date: 2020-11-21 14:56:29 +0100 (Sat, 21 Nov 2020)
Build-Date:2020-11-22 02:30:52
Revision:17329
Relative:URL: ^/trunk

Identification: JOSM/1.5 (17329 es) Windows 10 64-Bit
OS Build number: Windows 10 Home 2009 (19042)
Memory Usage: 247 MB / 989 MB (79 MB allocated, but free)
Java version: 1.8.0_271-b09, Oracle Corporation, Java HotSpot(TM) Client VM
Look and Feel: com.sun.java.swing.plaf.windows.WindowsLookAndFeel
Screen: \Display0 1366x768 (scaling 1.0x1.0)
Maximum Screen Size: 1366x768
Best cursor sizes: 16x16 -> 32x32, 32x32 -> 32x32
Dataset consistency test: No problems found

Plugins:
+ Mapillary (1.5.27)
+ RoadSigns (35640)
+ apache-commons (35524)
+ apache-http (35589)
+ imagery_offset_db (35640)
+ javafx-windows (35458)
+ jna (35458)
+ tageditor (35640)
+ turnlanes (35640)
+ turnlanes-tagging (288)
+ turnrestrictions (35640)

Last errors/warnings:
- 00036,274 W: java.nio.file.FileSystemException: %UserProfile%\AppData\Local\Temp\josm_exec_powershell_4084408392703263880.txt: El proceso no tiene acceso al archivo porque está siendo utilizado por otro proceso.
- 00036,290 W: Unable to request certificate of https://grca.nat.gov.tw
- 00792,733 W: JCS - Silent failure during download: http://wms.pcn.minambiente.it/ogc?MAP=/ms_ogc/WMS_v1.3/raster/ortofoto_colore_12.map&LAYERS=OI.ORTOIMMAGINI.2012.32,OI.ORTOIMMAGINI.2012.33&STYLES=,&FORMAT=image/jpeg&CRS=EPSG:3857&WIDTH=512&HEIGHT=512&BBOX=1390236.6704508,5144212.0035924,1390542.4185639,5144517.7517055&VERSION=1.3.0&SERVICE=WMS&REQUEST=GetMap
- 00795,357 W: JCS - Silent failure during download: http://wms.pcn.minambiente.it/ogc?MAP=/ms_ogc/WMS_v1.3/raster/ortofoto_colore_12.map&LAYERS=OI.ORTOIMMAGINI.2012.32,OI.ORTOIMMAGINI.2012.33&STYLES=,&FORMAT=image/jpeg&CRS=EPSG:3857&WIDTH=512&HEIGHT=512&BBOX=1390542.4185639,5143906.2554792,1390848.1666771,5144212.0035924&VERSION=1.3.0&SERVICE=WMS&REQUEST=GetMap
- 00796,286 W: JCS - Silent failure during download: http://wms.pcn.minambiente.it/ogc?MAP=/ms_ogc/WMS_v1.3/raster/ortofoto_colore_12.map&LAYERS=OI.ORTOIMMAGINI.2012.32,OI.ORTOIMMAGINI.2012.33&STYLES=,&FORMAT=image/jpeg&CRS=EPSG:3857&WIDTH=512&HEIGHT=512&BBOX=1390542.4185639,5144517.7517055,1390848.1666771,5144823.4998186&VERSION=1.3.0&SERVICE=WMS&REQUEST=GetMap

[GerdP]

OK, I am not an expert reg. building:part but the overlapping part is the area that is built by the ways

way 135619527
way 136190589
way 136190580
way 136190579
way 136190577

The multipolygon relation 1834825 contains this area, the multipolygon relation 1834818 doesn't.