[PATCH] Finish last step of modeless editing: Draw command

[anonymous]

Currently only one step for modeless editing is missing: The draw command.

A possible suggestion would be

• call draw command
• draw nodes and ways until the last node is pressed twice which ends drawing.

This Potlatch like style would allow to draw nodes and ways easily.

[xeen]

• Adds convenience functions firstNode(), lastNode() and isFirstLastNode() to the way primitive which makes code more readable.
• Added check to prevent ways like <---> (for more detail, see comment in patch)
• Will mark a way "finished" if last node is clicked again or a double (triple, …) click is performed.
• To make the last change actually useful, it will clear the selection if it can't "continue" from it and start anew instead

I did a quick test with all the cases I could make up and it worked fine.

[anonymous]

We also need a command for this which returns to select mode after finishing to get really modeless (i.e. like DELETE key compared to delete mode).

[xeen]

Yeah going to select mode when a way is finished and going to draw mode if clicking no-where in select mode should pretty much make it modeless. The only case left is where a node is selected and the user wants to draw a way from it. Potlatch uses "Shift+Click" to do this, but my take is that switching draw modes (i.e. pressing "a") is on par here.

Still, one step at a time, this is no trivial change.

[anonymous]

Applied in r1400.

[xeen]

I'm new to Eclipse

[xeen]

This makes draw/select behave like Potlatch and thus really modeless. It also fixes the "doesn't work for nodes" bug if it's enabled. I'd prefer to keep mode drawing at least as hidden variable, so I'll see if I can fix that, too.

[xeen]

This patch makes mode drawing as well as modeless drawing work fine. Adding single nodes by double clicking now works for both. If you want to continue drawing from a selected mode, you need to select draw mode then click (Potlatch: Shift+Click).

Normally I'd prefer using the same modifier keys, but shift is already taken for add to selection which is a nice and important feature, too. Pressing A, then Click is equal to holding Shift and then Click so that's no disadvantage.

Modeless defaults to off and should be for a while in case errors or bad behaviour are found. We could announce it in the MOTD so get feedback from interested users, though.

[anonymous]

I added a preferences option for it :-)