Wrong exclamation mark parsing in Overpass wizard

[gaben]

What steps will reproduce the problem?

1. Make an Overpass query containing an exclamation mark (negation), eg. oneway!=no
2. Check the result

What is the expected result?

["oneway"!="no"]

What happens instead?

["oneway!"="no"]

Please provide any additional information below. Attach a screenshot if possible.

The ​https://overpass-turbo.eu/ website working fine.

URL:https://josm.openstreetmap.de/svn/trunk
Repository:UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b
Last:Changed Date: 2020-04-17 21:45:35 +0200 (Fri, 17 Apr 2020)
Build-Date:2020-04-18 01:30:45
Revision:16330
Relative:URL: ^/trunk

Identification: JOSM/1.5 (16330 hu) Windows 10 64-Bit
OS Build number: Windows 10 Pro for Workstations 1909 (18363)
Memory Usage: 560 MB / 1820 MB (267 MB allocated, but free)
Java version: 1.8.0_251-b08, Oracle Corporation, Java HotSpot(TM) 64-Bit Server VM
Screen: \Display0 1920x1200
Maximum Screen Size: 1920x1200
VM arguments: [-Djava.security.manager, -Djava.security.policy=file:<java.home>\lib\security\javaws.policy, -DtrustProxy=true, -Djnlpx.home=<java.home>\bin, -Djnlpx.origFilenameArg=%UserProfile%\AppData\LocalLow\Sun\Java\Deployment\cache\6.0\31\583aa85f-404a7071, -Djnlpx.remove=false, -Djava.util.Arrays.useLegacyMergeSort=true, -Djnlpx.heapsize=NULL,2048m, -Djnlpx.splashport=59949, -Djnlp.application.href=https://josm.openstreetmap.de/download/josm-latest.jnlp, -Djnlpx.jvm=<java.home>\bin\javaw.exe]

[simon04]

In #18164, the Overpass wizard has been migrated to Java and now is based on the standard JOSM search. The syntax now is -oneway=no or -oneway?.

[gaben]

Ah, I see. Maybe it's worth highlighting the changed syntax for one or two releases to prevent further tickets.

For me, it was a 'feature' that I could copy-paste the same query from the overpass-turbo website to JOSM. I already miss it.

[simon04]

I see two types of users:

• people familiar with JOSM and JOSM search – they can use the same syntax for the new Overpass wizard
• people familiar with the Overpass syntax – they can input the Overpass QL directly

Copying from overpass-turbo – why don't you copy the entire query?

[Klumbumbus]

The sentence in the wizard with the link to the wiki schould be updated as it is no longer valid.

[simon04]

Agreed. I was considering to show the standard JOSM search dialog instead (plus a hint for the "… in Austria" syntax). Then the expected input syntax would be very clear.

[simon04]

Replying to simon04:

Agreed. I was considering to show the standard JOSM search dialog instead.

Done in r16354.

[Klumbumbus]

So the wizard is no longer really related to overpass turbo, right?

[gaben]

Replying to simon04:

I see two types of users:

• people familiar with JOSM and JOSM search – they can use the same syntax for the new Overpass wizard
• people familiar with the Overpass syntax – they can input the Overpass QL directly

Copying from overpass-turbo – why don't you copy the entire query?

Yeah, I copy from the website, because it is saved there. I'm not always opening JOSM to check if a query returns the expected results. That's because I'm more into QA and don't know what people do differently, what to search for or what's missing.

Copying the entire query will be the solution because:

• the text field is so small in JOSM (6-7px), barely see anything*
• the new syntax missing !~ operator and can't do key regex

If you would ask me, I vote for the old syntax, strictly from user perspective.

---

*: JRE8 on W10, HiDPI environment, 125% scaling. It is declared as Java 'bug', but anything over Java 8 is unusable for me. They changed the scaling and everything became overly big, aside from that JOSM was much slower when I tried.

[simon04]

Replying to Klumbumbus:

So the wizard is no longer really related to overpass turbo, right?

Right. I'll clarify the strings and labels.

[Klumbumbus]

org/openstreetmap/josm/gui/download/OverpassDownloadSource.java

@@ -104 +104 @@
         private static final String ACTION_IMG_SUBDIR = "dialogs";
 
         private static final StringProperty DOWNLOAD_QUERY = new StringProperty("download.overpass.query",
-                "/*\n" + tr("Place your Overpass query below or generate one using the Overpass Turbo Query Wizard") + "\n*/");
+                "/*\n" + tr("Place your Overpass query below or generate one using the Overpass Query Wizard.") + "\n*/");
 
         private final JosmTextArea overpassQuery;
         private final UserQueryList overpassQueryList;

org/openstreetmap/josm/gui/download/OverpassQueryWizardDialog.java

@@ -41 +41 @@
      */
     public OverpassQueryWizardDialog(OverpassWizardCallbacks callbacks) {
         super(new SearchSetting(), OVERPASS_WIZARD_HISTORY.get(), new PanelOptions(false, true), callbacks.getParent(),
-                tr("Overpass Turbo Query Wizard"),
+                tr("Overpass Query Wizard"),
                 tr("Build query"), tr("Build query and execute"), tr("Cancel"));
         this.callbacks = callbacks;
         setButtonIcons("dialogs/magic-wand", "download-overpass", "cancel");

[Klumbumbus]

(see r16359)

[GerdP]

see also #19151

[Klumbumbus]

Milestone renamed