Modify

Opened 4 years ago

Closed 4 months ago

#18726 closed enhancement (fixed)

Use {apikey} everywhere

Reported by: Don-vip Owned by: team
Priority: normal Milestone: Longterm
Component: Core imagery Version:
Keywords: api key apikey mapkey Cc: Stereo, stoecker, sommerluk

Description (last modified by stoecker)

Follow-up of #18440:

  • Wait for JOSM users to all run r15855+
  • Replace _apiKey_ by {apikey} in Maxar entries
  • Remove _apiKey_ support in JMapViewer
  • Use {apikey} in all relevant entries:
    • Maps/Worldwide
      • Bing
      • Mapbox
      • mapbox_locator_overlay
      • Maxar-Premium
      • Maxar-Standard Removed
      • opencylemap
      • tf-landscape
      • tf-outdoors
    • Maps/Australia
      • City_of_Melbourne_Feb_2019
      • City_of_Melbourne_May_2018
    • Maps/Austria
      • geoimage.at
    • Maps/Brazil
      • IBGE_DF_Addresses
      • IBGE_Nomes_Ruas
      • IBGE_Salvador_Streets Removed?
    • Maps/New Zealand
      • LINZ_NZ_Aerial_Imagery
      • LINZ_NZ_Topo50_Gridless_Maps
    • Maps/Norway
      • geovekst-nib
    • Maps/Sweden
      • lantmateriet-orto1960
      • lantmateriet-orto1975
      • lantmateriet-topowebb
      • lantmateriet-orto-historic
    • Maps/USA
      • New_and_Misaligned_TIGER_Roads-2013
      • US_Forest_Service_roads_overlay
      • US-TIGER-Roads-2017
      • US-TIGER-Roads-2018
      • US-TIGER-Roads-2019
      • WSDOT-Roads-2017 (2017->2021)
  • Update the apikey workaround/support in ELI-Sync-tool

Attachments (0)

Change History (16)

comment:1 by sommerluk, 4 years ago

Cc: sommerluk added

comment:2 by Don-vip, 4 years ago

Description: modified (diff)
Summary: Use {apiKey} everywhereUse {apikey} everywhere

comment:3 by Don-vip, 4 years ago

Milestone: Longterm20.08

comment:4 by Klumbumbus, 4 years ago

Description: modified (diff)

comment:5 by anonymous, 4 years ago

ELI just addded an {apikey} value to URLs https://github.com/osmlab/editor-layer-index/pull/548. For people who use ELI directly in JOSM https://osmlab.github.io/editor-layer-index/imagery.xml this now gives a warning/error.

Is this ticket tracking support for this?

comment:6 by aharvey, 4 years ago

I was not logged in anonymous message was from me.

in reply to:  5 comment:7 by Don-vip, 4 years ago

Replying to anonyme:

For people who use ELI directly in JOSM

What's the point? JOSM has more entries than ELI, and we check for their validity, so the JOSM dataset is greatly superior both in quantity and quality.

comment:8 by stoecker, 4 years ago

Description: modified (diff)

comment:9 by Stereo, 4 years ago

The workaround if you come across this in JOSM is to upgrade to the latest version. But yeah, like Vincent said, I don't know anyone who uses ELI in JOSM apart from ourselves, the ELI maintainers :).

comment:10 by simon04, 4 years ago

Milestone: 20.08Longterm

comment:11 by simon04, 4 years ago

Keywords: apikey mapkey added

comment:12 by Don-vip, 3 years ago

Owner: changed from Don-vip to team
Status: assignednew

comment:13 by taylor.smock, 17 months ago

Description: modified (diff)

comment:14 by stoecker, 17 months ago

Description: modified (diff)

Added missing apikeys. Update status.

Last point ELI-tools: getUrlStripped() should be adapted to also handle other apikey places like /token/{apikey} which are now much easier to detect.

Last edited 17 months ago by stoecker (previous) (diff)

comment:15 by stoecker, 17 months ago

Description: modified (diff)

comment:16 by stoecker, 4 months ago

Resolution: fixed
Status: newclosed

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain team.
as The resolution will be set.
The resolution will be deleted. Next status will be 'reopened'.

Add Comment


E-mail address and name can be saved in the Preferences .
 
Note: See TracTickets for help on using tickets.