Modify

Opened 4 years ago

Closed 4 years ago

#1841 closed defect (fixed)

[patch] Version information of manifest not displayed

Reported by: osm@… Owned by: framm
Priority: minor Component: Core
Version: latest Keywords:
Cc: osm@…

Description

Builds out of SVN use a different method of inserting version information. Here the manifest is used.
The classloader trys to locate the Manifest in classpath order. It is not guaranteed that the right manifest is retrieved.

It should use this one:
jar:file:/C:/Documents%20and%20Settings/Stephan/workspace/josm/core/dist/josm-custom.jar!/META-INF/MANIFEST.MF

but found that one first:
file:/C:/Program%20Files/Java/jre6/lib/ext/QTJava.zip!/META-INF/MANIFEST.MF

The patch fixes this by first determining the location of the jar containing "our" class file.

Once the "official" build process also uses the manifest for version information the call trying to fetch "REVISION" can be removed.

Another fix was the regular expression retrieving the version. This ignored the "SVN" suffix added by the build process.

Attachments (2)

josm-1841-manifest_lookup.patch (1.5 KB) - added by osm@… 4 years ago.
patch fixing the described problem
josm-1841-manifest_and_versioncheck.patch (5.9 KB) - added by osm@… 4 years ago.
Path additionally address not working check for required JOSM version

Download all attachments as: .zip

Change History (4)

Changed 4 years ago by osm@…

patch fixing the described problem

comment:1 Changed 4 years ago by anonymous

The pattern was for numeric part on purpose, as the numeric part is used for version checks.

Changed 4 years ago by osm@…

Path additionally address not working check for required JOSM version

comment:2 Changed 4 years ago by anonymous

  • Resolution set to fixed
  • Status changed from new to closed

Applied.

Add Comment

Modify Ticket

Change Properties
<Author field>
Action
as closed .
as The resolution will be set. Next status will be 'closed'.
The resolution will be deleted. Next status will be 'reopened'.
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.