JOSM settings: does not remember language

[anonymous]

I am trying to set language which is different from my OS language.
Open Settings -> Look and Feel -> Select Language -> Restart -> Open Settings -> Look and Feel -> Language: Default (Auto determined).
And that happens all time.
JSOM version: 15492.
Target language: Ukrainian.
OS language: English.

[Klumbumbus]

Thanks for your report, however your ticket is incomplete and therefore not helpful in its current form.

Please add all needed information according to this list:

• The required parts of the Status Report from your JOSM.
  • Please, use Report Bug from Help menu and copy & paste.
• Describe what behaviour you expected.
• Describe what did happen instead.
• Describe if and how the issue is reproducible.
• Add any relevant information like error messages or screenshots.

To ensure that all technical relevant information is contained, create new tickets by clicking in JOSMs Main Menu on Help → Report Bug.

[skyper]

What steps will reproduce the problem?

1. open preferences
2. change language under Display Settings -> Look and Feel (anything but not English) and close preference dialog with "OK".
3. open preferences
4. change anything (I checked plus unchecked expert mode) and close preference dialog with "OK".

What is the expected result?

No changes at all in preferences

What happens instead?

1. a dialog about restart
2. the language is changed to "Default"

Please provide any additional information below. Attach a screenshot if possible.

• Did check it with different languages. Only English was not changed.
• Did try it with different changes in settings. All seem to trigger the bug.

Relative:URL: ^/trunk
Repository:UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b
Last:Changed Date: 2019-11-24 21:23:35 +0100 (Sun, 24 Nov 2019)
Revision:15541
Build-Date:2019-11-25 02:31:03
URL:https://josm.openstreetmap.de/svn/trunk

Identification: JOSM/1.5 (15541 en) Linux Debian GNU/Linux 10 (buster)
Memory Usage: 184 MB / 964 MB (79 MB allocated, but free)
Java version: 11.0.5+10-post-Debian-1deb10u1, Debian, OpenJDK 64-Bit Server VM
Screen: :0.0 1366x768
Maximum Screen Size: 1366x768
Java package: openjdk-11-jre:amd64-11.0.5+10-1~deb10u1
Java ATK Wrapper package: libatk-wrapper-java:all-0.33.3-22
libcommons-compress-java: libcommons-compress-java:all-1.18-2
libcommons-logging-java: libcommons-logging-java:all-1.2-2
fonts-noto: fonts-noto:all-20181227-1
VM arguments: [-Djosm.home=<josm.pref>]

Last errors/warnings:
- W: No configuration settings found.  Using hardcoded default values for all pools.
- W: Region [TMS_BLOCK_v2] Resetting cache
- W: Region [WMS_BLOCK_v2] Resetting cache
- W: Region [WMTS_BLOCK_v2] Resetting cache

[Klumbumbus]

So it happens when you cancel the restart and reopen preferences before you restart, right?
It seems to be another regression of r15395. It works with josm-snapshot-15390 but not with josm-snapshot-15400, if I didn't tangle up during my tests.

[skyper]

Replying to Klumbumbus:

So it happens when you cancel the restart and reopen preferences before you restart, right?

Yes, but you can also restart. It does not matter.

It seems to be another regression of r15395. It works with josm-snapshot-15390 but not with josm-snapshot-15400, if I didn't tangle up during my tests.

Yes.

[Don-vip]

Replying to skyper:

What steps will reproduce the problem?

I tried various languages changes and everything behaves fine. I changed language from French to Asturian, then to Belarusian, then to English. What's wrong? A step is probably missing in your description.

[Klumbumbus]

This is how I can reproduce. See attachment. (I cropped the part during restart).

[Don-vip]

Even using Cancel I don't reproduce. Language changed correctly for every combination I tried.

[skyper]

Replying to Don-vip:

Replying to skyper:

What steps will reproduce the problem?

I tried various languages changes and everything behaves fine. I changed language from French to Asturian, then to Belarusian, then to English. What's wrong? A step is probably missing in your description.

I tried to show a short way but that was not a good idea.

• The language changes if you restart after setting it in preferences but when closing the preferences dialog with "OK", the next time, it will be changed back to "default".
• a work around is to always use the --language=<> option on start up.

Long version how to reproduce:

What steps will reproduce the problem?

1. open preferences
2. change language under Display Settings -> Look and Feel (anything but not English) and close preference dialog with "OK".
3. click on "restart"
4. josm starts in previous chosen language
5. open preferences
6. close preference dialog with "OK"
7. click on "restart"

What is the expected result?

after 6. no changes in preferences

What happens instead?

1. a dialog about restart in 7.
2. the language is changed to "Default" on next start up

Please provide any additional information below. Attach a screenshot if possible.

My system default language is English and the user language is set to English.

For me, the problem seems to be the language box, which should reflect/show the current language settings but which does always changes to "Default".

[Don-vip]

OK thank you now I can reproduce.

[Don-vip]

In 15547/josm:

fix #18355 - fix regression in determination of locale/country (introduced in r15395)

[anonymous]

Big thanks for fixing this!