Modify ↓

Opened 5 years ago

Closed 4 years ago

#1598 closed defect (fixed)

[PATCH] JOSM does not check if password dialog of upload is aborted

Reported by: plaicy Owned by: framm
Priority: major Component: Core
Version: latest Keywords:
Cc:

Description

Hello,

I have not saved my password in josm. So if I upload something josm asks for the password. If abort this dialog, josm ask in a endless loop for the password. In the console is written: "got return: 401 with id". After a few tries josm even backoff for 10 seconds. I think the return value of this dialogue is not checked.

Greetings

Attachments (2)

MakeAbortingMoreResponsive.patch​ (2.8 KB) - added by xeen 4 years ago.
MakeAbortingMoreResponsive.2.patch​ (2.8 KB) - added by xeen 4 years ago.
Forgot updating the patch before uploading, this is the right one

Download all attachments as: .zip

Change History (4)

Changed 4 years ago by xeen

Changed 4 years ago by xeen

Forgot updating the patch before uploading, this is the right one

comment:1 Changed 4 years ago by xeen

  • Summary changed from JOSM does not check if password dialog of upload is aborted to [PATCH] JOSM does not check if password dialog of upload is aborted

This makes canceling more responsive by instead of sleeping for 10s, it will sleep for 1s, wake up and check if the user canceled and either cancel or sleep again for 1s. Canceling the password dialog will have an effect now.

comment:2 Changed 4 years ago by anonymous

  • Resolution set to fixed
  • Status changed from new to closed

Applied in r1395.

Add Comment

Modify Ticket

Change Properties
<Author field>
Action
as closed .
as The resolution will be set. Next status will be 'closed'.
The resolution will be deleted. Next status will be 'reopened'.
Author


E-mail address and user name can be saved in the Preferences.

Attachments ↑ Description ↑
 
Note: See TracTickets for help on using tickets.