Changeset 6264 in josm for trunk/src/org/openstreetmap/josm/gui/SplashScreen.java

Timestamp:

2013-09-27T01:16:28+02:00 (11 years ago)

Author:

Don-vip

Message:

Sonar/FindBugs - Performance - Method concatenates strings using + in a loop

File:

• trunk/src/org/openstreetmap/josm/gui/SplashScreen.java (modified) (3 diffs)

trunk/src/org/openstreetmap/josm/gui/SplashScreen.java

@@ -40 +40 @@
     private SwingRenderingProgressMonitor progressMonitor;
 
+    /**
+     * Constructs a new {@code SplashScreen}.
+     */
     public SplashScreen() {
         super();
@@ -157 +160 @@
         public void setCustomText(String message) {
             if(message.isEmpty())
-                message = " "; /* prevent killing of additional line */
+                message = " "; // prevent killing of additional line
             lblCustomText.setText(message);
             repaint();
@@ -198 +201 @@
                 messages.add(taskTitle);
             }
-            String html = "";
+            StringBuilder html = new StringBuilder();
             int i = 0;
             for (String m : messages) {
-                html += "<p class=\"entry" + (++i) + "\">" + m + "</p>";
+                html.append("<p class=\"entry").append(++i).append("\">").append(m).append("</p>");
             }