Changeset 5671 in josm for trunk/src/org/openstreetmap/josm/gui/layer/ValidatorLayer.java

Timestamp:

2013-01-26T16:49:29+01:00 (11 years ago)

Author:

Don-vip

Message:

Improve validator layer painting performance (major slowdown seen with #3346 test file)

File:

• trunk/src/org/openstreetmap/josm/gui/layer/ValidatorLayer.java (modified) (5 diffs)

trunk/src/org/openstreetmap/josm/gui/layer/ValidatorLayer.java

@@ -17 +17 @@
 import org.openstreetmap.josm.data.osm.visitor.BoundingXYVisitor;
 import org.openstreetmap.josm.data.validation.OsmValidator;
+import org.openstreetmap.josm.data.validation.PaintVisitor;
 import org.openstreetmap.josm.data.validation.Severity;
 import org.openstreetmap.josm.data.validation.TestError;
@@ -35 +36 @@
     private int updateCount = -1;
 
+    /**
+     * Constructs a new Validator layer
+     */
     public ValidatorLayer() {
         super(tr("Validation errors"));
@@ -60 +64 @@
         if (root == null || root.getChildCount() == 0)
             return;
+        
+        PaintVisitor paintVisitor = new PaintVisitor(g, mv);
 
         DefaultMutableTreeNode severity = (DefaultMutableTreeNode) root.getLastChild();
@@ -67 +73 @@
                 Object tn = errorMessages.nextElement().getUserObject();
                 if (tn instanceof TestError) {
-                    ((TestError) tn).paint(g, mv);
+                    paintVisitor.visit(((TestError) tn));
                 }
             }
@@ -74 +80 @@
             severity = severity.getPreviousSibling();
         }
+        
+        paintVisitor.clearPaintedObjects();
     }