Changeset 10179 in josm for trunk/src/org/openstreetmap/josm/gui/preferences/SourceEditor.java

Timestamp:

2016-05-11T02:44:10+02:00 (8 years ago)

Author:

Don-vip

Message:

sonar - squid:AssignmentInSubExpressionCheck - Assignments should not be made from within sub-expressions

File:

• trunk/src/org/openstreetmap/josm/gui/preferences/SourceEditor.java (modified) (3 diffs)

trunk/src/org/openstreetmap/josm/gui/preferences/SourceEditor.java

@@ -1486 +1486 @@
                         Matcher m = Pattern.compile("^(.+);(.+)$").matcher(line);
                         if (m.matches()) {
-                            sources.add(last = new ExtendedSourceEntry(m.group(1), m.group(2)));
+                            last = new ExtendedSourceEntry(m.group(1), m.group(2));
+                            sources.add(last);
                         } else {
                             Main.error(tr(getStr(I18nString.ILLEGAL_FORMAT_OF_ENTRY), url, line));
@@ -1528 +1529 @@
 
     class FileOrUrlCellEditor extends JPanel implements TableCellEditor {
-        private JosmTextField tfFileName;
+        private final JosmTextField tfFileName = new JosmTextField();
         private final CopyOnWriteArrayList<CellEditorListener> listeners;
         private String value;
@@ -1544 +1545 @@
             gc.weightx = 1.0;
             gc.weighty = 1.0;
-            add(tfFileName = new JosmTextField(), gc);
+            add(tfFileName, gc);
 
             gc.gridx = 1;