Ignore:
Timestamp:
2016-03-17T01:50:12+01:00 (8 years ago)
Author:
Don-vip
Message:

sonar - Local variable and method parameter names should comply with a naming convention

File:
1 edited

Legend:

Unmodified
Added
Removed
  • trunk/src/org/openstreetmap/josm/gui/layer/geoimage/ImageViewerDialog.java

    r9543 r10001  
    9191        Shortcut scPrev = Shortcut.registerShortcut(
    9292                "geoimage:previous", tr("Geoimage: {0}", tr("Show previous Image")), KeyEvent.VK_PAGE_UP, Shortcut.DIRECT);
    93         final String APREVIOUS = "Previous Image";
     93        final String previousImage = "Previous Image";
    9494        Main.registerActionShortcut(prevAction, scPrev);
    95         btnPrevious.getInputMap(JComponent.WHEN_IN_FOCUSED_WINDOW).put(scPrev.getKeyStroke(), APREVIOUS);
    96         btnPrevious.getActionMap().put(APREVIOUS, prevAction);
     95        btnPrevious.getInputMap(JComponent.WHEN_IN_FOCUSED_WINDOW).put(scPrev.getKeyStroke(), previousImage);
     96        btnPrevious.getActionMap().put(previousImage, prevAction);
    9797        btnPrevious.setEnabled(false);
    9898
    99         final String DELETE_TEXT = tr("Remove photo from layer");
    100         ImageAction delAction = new ImageAction(COMMAND_REMOVE, ImageProvider.get("dialogs", "delete"), DELETE_TEXT);
     99        final String removePhoto = tr("Remove photo from layer");
     100        ImageAction delAction = new ImageAction(COMMAND_REMOVE, ImageProvider.get("dialogs", "delete"), removePhoto);
    101101        JButton btnDelete = new JButton(delAction);
    102102        btnDelete.setPreferredSize(buttonDim);
     
    104104                "geoimage:deleteimagefromlayer", tr("Geoimage: {0}", tr("Remove photo from layer")), KeyEvent.VK_DELETE, Shortcut.SHIFT);
    105105        Main.registerActionShortcut(delAction, scDelete);
    106         btnDelete.getInputMap(JComponent.WHEN_IN_FOCUSED_WINDOW).put(scDelete.getKeyStroke(), DELETE_TEXT);
    107         btnDelete.getActionMap().put(DELETE_TEXT, delAction);
     106        btnDelete.getInputMap(JComponent.WHEN_IN_FOCUSED_WINDOW).put(scDelete.getKeyStroke(), removePhoto);
     107        btnDelete.getActionMap().put(removePhoto, delAction);
    108108
    109109        ImageAction delFromDiskAction = new ImageAction(COMMAND_REMOVE_FROM_DISK,
     
    113113        Shortcut scDeleteFromDisk = Shortcut.registerShortcut(
    114114                "geoimage:deletefilefromdisk", tr("Geoimage: {0}", tr("Delete File from disk")), KeyEvent.VK_DELETE, Shortcut.CTRL_SHIFT);
    115         final String ADELFROMDISK = "Delete image file from disk";
     115        final String deleteImage = "Delete image file from disk";
    116116        Main.registerActionShortcut(delFromDiskAction, scDeleteFromDisk);
    117         btnDeleteFromDisk.getInputMap(JComponent.WHEN_IN_FOCUSED_WINDOW).put(scDeleteFromDisk.getKeyStroke(), ADELFROMDISK);
    118         btnDeleteFromDisk.getActionMap().put(ADELFROMDISK, delFromDiskAction);
     117        btnDeleteFromDisk.getInputMap(JComponent.WHEN_IN_FOCUSED_WINDOW).put(scDeleteFromDisk.getKeyStroke(), deleteImage);
     118        btnDeleteFromDisk.getActionMap().put(deleteImage, delFromDiskAction);
    119119
    120120        ImageAction copyPathAction = new ImageAction(COMMAND_COPY_PATH, ImageProvider.get("copy"), tr("Copy image path"));
     
    123123        Shortcut scCopyPath = Shortcut.registerShortcut(
    124124                "geoimage:copypath", tr("Geoimage: {0}", tr("Copy image path")), KeyEvent.VK_C, Shortcut.ALT_CTRL_SHIFT);
    125         final String ACOPYPATH = "Copy image path";
     125        final String copyImage = "Copy image path";
    126126        Main.registerActionShortcut(copyPathAction, scCopyPath);
    127         btnCopyPath.getInputMap(JComponent.WHEN_IN_FOCUSED_WINDOW).put(scCopyPath.getKeyStroke(), ACOPYPATH);
    128         btnCopyPath.getActionMap().put(ACOPYPATH, copyPathAction);
     127        btnCopyPath.getInputMap(JComponent.WHEN_IN_FOCUSED_WINDOW).put(scCopyPath.getKeyStroke(), copyImage);
     128        btnCopyPath.getActionMap().put(copyImage, copyPathAction);
    129129
    130130        ImageAction nextAction = new ImageAction(COMMAND_NEXT, ImageProvider.get("dialogs", "next"), tr("Next"));
     
    133133        Shortcut scNext = Shortcut.registerShortcut(
    134134                "geoimage:next", tr("Geoimage: {0}", tr("Show next Image")), KeyEvent.VK_PAGE_DOWN, Shortcut.DIRECT);
    135         final String ANEXT = "Next Image";
     135        final String nextImage = "Next Image";
    136136        Main.registerActionShortcut(nextAction, scNext);
    137         btnNext.getInputMap(JComponent.WHEN_IN_FOCUSED_WINDOW).put(scNext.getKeyStroke(), ANEXT);
    138         btnNext.getActionMap().put(ANEXT, nextAction);
     137        btnNext.getInputMap(JComponent.WHEN_IN_FOCUSED_WINDOW).put(scNext.getKeyStroke(), nextImage);
     138        btnNext.getActionMap().put(nextImage, nextAction);
    139139        btnNext.setEnabled(false);
    140140
Note: See TracChangeset for help on using the changeset viewer.