Changes between Version 4 and Version 5 of Styles/DiscGolfCourse

Timestamp:

2024-03-20T08:50:26+01:00 (22 months ago)

Author:

negreheb

Comment:

Added the common errors

Styles/DiscGolfCourse

@@ -3 +3 @@
 == Description ==
 
-I made this style to simplify tagging of disc golf courses in JOSM. With this style, mapping tees, baskets, holes, and ohter elements of a disc gold course become more intuitive and efficient. The clear visual representation and use of symbols and colors hopefully makes mapping easier.
+I made this style to simplify tagging of disc golf courses in JOSM. With this style, mapping tees, baskets, holes, and other elements of a disc gold course become more intuitive and efficient. The clear visual representation and use of symbols and colors hopefully makes mapping easier.
 
-Suggestions possible at:
+The style tries to catch common mapping pitfalls as found on https://wiki.openstreetmap.org/wiki/Tag:leisure%3Ddisc_golf_course 
+
+- Using disc_golf=pin instead of disc_golf=basket.
+- Using ref=* somewhere else than on hole.
+- Using name=* on every hole instad or additionally to ref=* to force a rendering. (https://wiki.openstreetmap.org/wiki/Tagging_for_the_renderer)
+- Using landuse=* or natural=* to indicate its surface. Use surface=* instead.
+
+=== Suggestions possible at === 
 
 - https://community.openstreetmap.org/t/custom-map-style-for-josm-for-disc-golf-course/110688
@@ -17 +24 @@
 
 meta {
-    title: "Disc Golf Course";
+    title: "Disc Golf Course Testing";
     version: "0.[[revision]]_[[date]]";
     description: "Colouring and icons for a Disc Golf Course to make mapping it easier.";
-    icon: "DiscGolfCourseIcon.svg";
+    icon:"DiscGolfCourse.svg";
     author: "Negreheb";
     link: "https://josm.openstreetmap.de/wiki/Styles/DiscGolfCourse";
@@ -82 +89 @@
 }
 
+/* If mando is tagged to an existing node like natural=tree, it will not get rendered */
+/* But the text will appear next to it */
 node[disc_golf=mando]{
         text: eval("Mando");
         text-color: red;
         font-weight: bold;
-        font-size: 10;
-        symbol-size: 20;
+        font-size: 15;
+                symbol-size: 20;
         symbol-shape: triangle;
         symbol-fill-color: red;
-        symbol-fill-opacity: 0.5;       
+        symbol-fill-opacity: 0.5;
 }
 
@@ -96 +105 @@
         fill-color: red;
         text: eval("OB");
-        font-size: 15;
+                text-color: red;
         font-weight: bold;
-        text-color: red;
+                font-size: 15;
         /*text-halo-color: black;*/
 }
 
+/**********************************************/
+/*                            Common pitfalls */
+/**********************************************/
+
+/* ************** disc_golf=pin instead of basket */
+node[disc_golf=pin]{
+        text: eval("Use basket");
+        text-color: purple;
+        font-size: 20;
+        font-weight: bold;
+        color: purple;
+        width: 30;
+        opacity: 1;
+        dashes: 0;
+        symbol-size: 40;
+        symbol-shape: circle;
+        symbol-fill-color: purple;
+}
+
+/* ************** Catch a name on an hole */
+way[disc_golf=hole][name]{
+        text: eval("NO NAME ON HOLE");
+        text-color: purple;
+        font-size: 20;
+                font-weight: bold;
+                text-offset-y: 30;
+}
+
+/* ************** Catch everything tagged with golf=* */
+*[golf]{
+        color: purple;
+        width: 30;
+        opacity: 1;
+        dashes: 0;
+        symbol-size: 40;
+        symbol-shape: circle;
+        symbol-fill-color: purple;
+}
+
 }}}