Changes between Version 13 and Version 14 of Rules/ValidatingBuildingsInHOTTMProjects

Timestamp:

2023-04-10T18:53:37+02:00 (3 years ago)

Author:

Patrik_B

Comment:

removed test node, added test for Unclassified highway shorter than 50 meters.

Rules/ValidatingBuildingsInHOTTMProjects

@@ -3 +3 @@
 meta
 {
-  title: "Validating tasks in HOT TM projects.";
+  title: "Validating tasks in HOT TM projects";
   version: "[[revision]]_[[date]]";
   description: "Few rules for checking mistakes mostly made by beginners using ID Editor.";
@@ -11 +11 @@
 }
 
-
 /*
-  Building with layer tag with exception for building=roof
+  Uploaded part of taskgrid. Added thanks to adiatmad (dinar)
 */
-*[building][building!=roof][layer]{
-throwWarning: tr("_Fix - Building has layer tag");
-fixRemove: "layer";
-group: tr("HOT TM Validator Checker");
-}
-
-/*
-  Building with different tag then yes
-*/
-way[building][building!=yes]{
-throwWarning: tr("Building has different tag then yes");
-group: tr("HOT TM Validator Checker");
-}
-
-/*
-  Node with building tag
-*/
-node[building]{
-throwWarning: tr("Node has a building tag");
+*[taskId][taskStatus]{
+throwError: tr("Part of project taskgrid");
 group: tr("HOT TM Validator Checker");
 }
@@ -56 +38 @@
 
 /*
+  Building with layer tag with exception for building=roof
+*/
+*[building][building!=roof][layer]{
+throwWarning: tr("_Fix - Building has layer tag");
+fixRemove: "layer";
+group: tr("HOT TM Validator Checker");
+}
+
+/*
   Highway with layer tag with exception for tunnel and bridge. Added thanks to martien-176
 */
-*[highway][tunnel!=yes][bridge!=yes][layer]{
+*[highway][!bridge][!tunnel][layer]{
 throwWarning: tr("_Fix - Highway has layer tag");
 fixRemove: "layer";
@@ -67 +58 @@
   Waterway with layer tag. Added thanks to martien-176
 */
-*[waterway][tunnel!=culvert][layer]{
+*[waterway][!bridge][!tunnel][layer]{
 throwWarning: tr("_Fix - Waterway has layer tag");
 fixRemove: "layer";
@@ -74 +65 @@
 
 /*
-  Square of a TM project taskgrid. Added thanks to Adiatma IRM-RV (dinar)
+  Building with different tag then yes
 */
-*[taskId][taskStatus]{
-throwError: tr("Part of project taskgrid");
+way[building][building!=yes]{
+throwWarning: tr("Building has different tag then yes");
 group: tr("HOT TM Validator Checker");
 }
 
 /*
-  Testing update system
+  Node with building tag
 */
-node[SpecialTagThatShouldNotBeUsuallyInOSMtoNotScareUsers=ewfjgvhewhfjke24ewf4585wef2wef88qse4gwhtzrjki86u]{
-throwWarning: tr("If you see this please contact Patrik_B");
+node[building]{
+throwWarning: tr("Node has a building tag");
 group: tr("HOT TM Validator Checker");
 }
+
+/*
+  Too short unclassified highway (highway probably having wrong tag). Added thanks to adiatmad (dinar)
+*/
+way[highway=unclassified][waylength() < 50][!bridge][!tunnel] {
+throwWarning: tr("Unclassified highway shorter than 50 meters.");
+group: tr("HOT TM Validator Checker");
+}
+
 }}}