Changes between Version 11 and Version 12 of Rules/UkrainePhoneNumbers

Timestamp:

2022-05-27T20:29:46+02:00 (3 years ago)

Author:

andygol

Comment:

Added rules for PrivatBank short number; fixed bug with emergency phones

Rules/UkrainePhoneNumbers

@@ -8 +8 @@
 Toll-free phones `0 800 ххх ххх` must be specified without a country code, the `phone:UA` key is used to record them.
 
-Use `emergency:phone=*` tag to add emergency numbers.
+Use `emergency:phone=*` tag for adding emergency numbers.
 - 112 - general emergency number, one for all services
 - 101 - firefighters
@@ -15 +15 @@
 - 104 - gas service
 - 109 - information desk
+
+Use `contact:phone=*` tag for adding short service numbers. So far, the rules for checking the short number of PrivatBank (3700).
 
 {{{
@@ -34 +36 @@
 }
 
-*[/^(contact:)?(phone|fax)(?!:UA)$/][/^(contact:)?(phone|fax)(?!:UA)$/ !~ /^((;?(?=(\+\b380 [3-9][0-9][0-9 ]{9}\b)|(0 800 \d{3} \d{3}))(?=.*((0 800 \d{3} \d{3})|(\+\b380 (?:\d{2} \d{3} \d{4}|\d{3} \d{2} \d{4}|\d{4} \d{2} \d{3})\b)))((0 800 \d{3} \d{3})|(\+\b380 (?:\d{2} \d{3} \d{4}|\d{3} \d{2} \d{4}|\d{4} \d{2} \d{3})\b)))*)$/][inside("UA")] {
+*[/^(contact:)?(phone|fax)(?!:UA)$/][/^(contact:)?(phone|fax)(?!:UA)$/ !~ /^((;?(?=(\+\b380 [3-9][0-9][0-9 ]{9}\b)|(0 800 \d{3} \d{3})|(3700))(?=.*(\b(3700)\b|\b(0 800 \d{3} \d{3})\b|(\+\b380 (?:\d{2} \d{3} \d{4}|\d{3} \d{2} \d{4}|\d{4} \d{2} \d{3})\b)))(\b(3700)\b|\b(0 800 \d{3} \d{3})\b|(\+\b380 (?:\d{2} \d{3} \d{4}|\d{3} \d{2} \d{4}|\d{4} \d{2} \d{3})\b)))*)$/][inside("UA")] {
     throwWarning: tr("{0}", "{0.tag}");
     group: tr("Incorrect \"phone\" tag");
@@ -42 +44 @@
 }
 
-*["phone" =~ /^(;?(0 800 \d{3} \d{3}))*$/][inside("UA")] {
+*["phone" =~ /^(;?(0 800 \d{3} \d{3}))*$/][inside("UA")],
+*["contact:phone" =~ /^(;?(0 800 \d{3} \d{3}))*$/][inside("UA")] {
     throwError: tr("{0}", "");
     group: tr("A toll-free phone number is listed in the \"phone\" tag");
-    fixChangeKey: "phone=>phone:UA";
+    fixChangeKey: "{0.key}=>phone:UA";
     assertMatch: "node phone=0 800 500 609";
     assertMatch: "way phone=0 800 500 609";
@@ -68 +71 @@
 }
 
-*[/^(contact:)?(phone|fax)(?!:UA)$/ =~ /^.*(;?(?=\b(112|10[1-49])\b)(112|10[1-49])*)(?<=(112|10[1-49])).*$/][inside("UA")] {
+/*+380 3333 00 102 - fixed. Here, 102 is a part of the number, not an emergency phone by itself*/
+*[/^(contact:)?(phone|fax)(?!:UA)$/][/^(contact:)?(phone|fax)(?!:UA)$/ =~ /;?(?=\b(112|10[1-49])\b)(?<! )(112|10[1-49])*/][inside("UA")] {
     throwWarning: tr("Emergency phone number is in the \"phone\" tag");
     suggestAlternative: tr("\"emergency:phone=*\"");
 }
 
-*[/(phone|fax)/ =~ /; *$/][inside("UA")] {
+*[/(phone|fax)/ =~ /\d; *$/][inside("UA")] {
     throwWarning: tr("{0}", "");
-    group: tr("Empty value after \";\" at the end of the tag");
+    group: tr("Empty value after \";\" at the end of the phone/fax tag");
+}
+
+/* privatbank short number - not tested yet */
+*["phone" =~ /\b3700\b/][/^name(:\w\w)?$/ =~ /^(?i)(?u)(ПриватБанк)$/][inside("UA")] {
+    throwError: tr("{0}", "");
+    group: tr("Privatbank short number is listed in the \"phone\" tag");
+    suggestAlternative: tr("contact:phone = 3700 for short number");
 }
 }}}