Changes between Version 2 and Version 3 of Rules/QAToolInspiredValidations


Ignore:
Timestamp:
2019-01-28T21:37:30+01:00 (7 years ago)
Author:
abalosc1
Comment:

fix item 1210

Legend:

Unmodified
Added
Removed
Modified

  • Rules/QAToolInspiredValidations

    v2 v3  
    3030}
    3131
    32 *[amenity = chocolatier]{
     32*[amenity = chocol/* not-connected highway/cycleway -- OSMOSE Item 1210 */
     33
     34/* Set connected_node */
     35
     36way[highway] node:connection {
     37        set connected_node;
     38}
     39
     40/* set nodes in downloaded area */
     41
     42way[highway] node:in-downloaded-area {
     43        set downloaded;
     44}
     45
     46/* Unconnected Cycleway */
     47
     48way[highway=cycleway]!:closed!.connected_node.downloaded >[index=1] node[noexit!=yes][amenity!=parking_entrance][amenity!=parking],
     49way[highway=cycleway]!:closed!.connected_node.downloaded >[index=-1] node[noexit!=yes][amenity!=parking_entrance][amenity!=parking] {
     50                throwWarning: "Unconnected Cycleway";
     51        group: tr("Not-connected highway/cycleway -- OSMOSE Item 1210");
     52}
     53
     54/* Unconnected Major Road -- Motorway to Tertiary */
     55
     56way[highway=~/^(motorway|trunk|primary|secondary|tertiary)$/]!:closed!.connected_node.downloaded >[index=-1] node[noexit!=yes][amenity!=parking_entrance][amenity!=parking],
     57way[highway=~/^(motorway|trunk|primary|secondary|tertiary)$/]!:closed!.connected_node.downloaded >[index=1] node[noexit!=yes][amenity!=parking_entrance][amenity!=parking] {
     58                throwWarning: "Unconnected Major Road";
     59        group: tr("Not-connected highway/cycleway -- OSMOSE Item 1210");
     60}atier]{
    3361        throwWarning: "{0.tag} is deprecated";
    3462    group: tr("deprecated tagging - Osmose tagwatch cleaner 3030");             
    … …  
    4270    group: tr("deprecated tagging - Osmose tagwatch cleaner 3030");             
    4371        suggestAlternative: "shop=dry_cleaning";
    44         fixAdd: "shop=dry_cleaning";
     72        fixAdd: "s/* not-connected highway/cycleway -- OSMOSE Item 1210 */
     73
     74/* Set connected_node */
     75
     76way[highway] node:connection {
     77        set connected_node;
     78}
     79
     80/* set nodes in downloaded area */
     81
     82way[highway] node:in-downloaded-area {
     83        set downloaded;
     84}
     85
     86/* Unconnected Cycleway */
     87
     88way[highway=cycleway]!:closed!.connected_node.downloaded >[index=1] node[noexit!=yes][amenity!=parking_entrance][amenity!=parking],
     89way[highway=cycleway]!:closed!.connected_node.downloaded >[index=-1] node[noexit!=yes][amenity!=parking_entrance][amenity!=parking] {
     90                throwWarning: "Unconnected Cycleway";
     91        group: tr("Not-connected highway/cycleway -- OSMOSE Item 1210");
     92}
     93
     94/* Unconnected Major Road -- Motorway to Tertiary */
     95
     96way[highway=~/^(motorway|trunk|primary|secondary|tertiary)$/]!:closed!.connected_node.downloaded >[index=-1] node[noexit!=yes][amenity!=parking_entrance][amenity!=parking],
     97way[highway=~/^(motorway|trunk|primary|secondary|tertiary)$/]!:closed!.connected_node.downloaded >[index=1] node[noexit!=yes][amenity!=parking_entrance][amenity!=parking] {
     98                throwWarning: "Unconnected Major Road";
     99        group: tr("Not-connected highway/cycleway -- OSMOSE Item 1210");
     100}hop=dry_cleaning";
    45101        fixRemove: "amenity"
    46102}
    … …  
    83139*[shop *= "driver education"] {
    84140        throwWarning: tr("{0}", "{0.tag}");
    85         suggestAlternative: "shop=driving_school";
     141        suggestAlte/* not-connected highway/cycleway -- OSMOSE Item 1210 */
     142
     143/* Set connected_node */
     144
     145way[highway] node:connection {
     146        set connected_node;
     147}
     148
     149/* set nodes in downloaded area */
     150
     151way[highway] node:in-downloaded-area {
     152        set downloaded;
     153}
     154
     155/* Unconnected Cycleway */
     156
     157way[highway=cycleway]!:closed!.connected_node.downloaded >[index=1] node[noexit!=yes][amenity!=parking_entrance][amenity!=parking],
     158way[highway=cycleway]!:closed!.connected_node.downloaded >[index=-1] node[noexit!=yes][amenity!=parking_entrance][amenity!=parking] {
     159                throwWarning: "Unconnected Cycleway";
     160        group: tr("Not-connected highway/cycleway -- OSMOSE Item 1210");
     161}
     162
     163/* Unconnected Major Road -- Motorway to Tertiary */
     164
     165way[highway=~/^(motorway|trunk|primary|secondary|tertiary)$/]!:closed!.connected_node.downloaded >[index=-1] node[noexit!=yes][amenity!=parking_entrance][amenity!=parking],
     166way[highway=~/^(motorway|trunk|primary|secondary|tertiary)$/]!:closed!.connected_node.downloaded >[index=1] node[noexit!=yes][amenity!=parking_entrance][amenity!=parking] {
     167                throwWarning: "Unconnected Major Road";
     168        group: tr("Not-connected highway/cycleway -- OSMOSE Item 1210");
     169}rnative: "shop=driving_school";
    86170        fixAdd: "shop=car_school";
    87171}
    … …  
    427511}
    428512
     513/* set nodes in downloaded area */
     514
     515way[highway] node:in-downloaded-area {
     516        set downloaded;
     517}
     518
    429519/* Unconnected Cycleway */
    430520
    431 way[highway=cycleway]!:closed!.connected_node >[index=1] node[noexit!=yes][amenity!=parking_entrance][amenity!=parking],
    432 way[highway=cycleway]!:closed!.connected_node >[index=-1] node[noexit!=yes][amenity!=parking_entrance][amenity!=parking] {
     521way[highway=cycleway]!:closed!.connected_node.downloaded >[index=1] node[noexit!=yes][amenity!=parking_entrance][amenity!=parking],
     522way[highway=cycleway]!:closed!.connected_node.downloaded >[index=-1] node[noexit!=yes][amenity!=parking_entrance][amenity!=parking] {
    433523                throwWarning: "Unconnected Cycleway";
    434524        group: tr("Not-connected highway/cycleway -- OSMOSE Item 1210");
    … …  
    437527/* Unconnected Major Road -- Motorway to Tertiary */
    438528
    439 way[highway=~/^(motorway|trunk|primary|secondary|tertiary)$/]!:closed!.connected_node >[index=-1] node[noexit!=yes][amenity!=parking_entrance][amenity!=parking],
    440 way[highway=~/^(motorway|trunk|primary|secondary|tertiary)$/]!:closed!.connected_node >[index=1] node[noexit!=yes][amenity!=parking_entrance][amenity!=parking] {
     529way[highway=~/^(motorway|trunk|primary|secondary|tertiary)$/]!:closed!.connected_node.downloaded >[index=-1] node[noexit!=yes][amenity!=parking_entrance][amenity!=parking],
     530way[highway=~/^(motorway|trunk|primary|secondary|tertiary)$/]!:closed!.connected_node.downloaded >[index=1] node[noexit!=yes][amenity!=parking_entrance][amenity!=parking] {
    441531                throwWarning: "Unconnected Major Road";
    442532        group: tr("Not-connected highway/cycleway -- OSMOSE Item 1210");
    443533}
    444 
    445534}}}